Skip to contentSkip to conversation

Add pine64 keymap

GIT PULL Sean Young 2 participants 2 messages Dec 3, 2020 Media (V4L/DVB)

lore
Share & tools
lore

Sean Young

author
#0 lore raw

The following changes since commit 42ad70c469665387e8f7b53cb6d4581492dff906:

media: rockchip: rkisp1: remove useless debugfs checks (2020-12-03 08:59:10 +0100)

are available in the Git repository at:

git://linuxtv.org/syoung/media_tree.git tags/v5.11d

for you to fetch changes up to 173ae11a204d6e2aaccdb82e8de851f1d361a34e:

media: rc: add keymap for pine64 remote (2020-12-03 10:21:37 +0000)

----------------------------------------------------------------
v5.11d

----------------------------------------------------------------
Jonas Karlman (1):
media: rc: add keymap for pine64 remote

 Documentation/devicetree/bindings/media/rc.yaml |  1 +
 drivers/media/rc/keymaps/Makefile               |  1 +
 drivers/media/rc/keymaps/rc-pine64.c            | 65 +++++++++++++++++++++++++
 include/media/rc-map.h                          |  1 +
 4 files changed, 68 insertions(+)
 create mode 100644 drivers/media/rc/keymaps/rc-pine64.c
#1 lore raw

Re: [GIT PULL FOR v5.11] Add pine64 keymap (#69683)

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/79700/
Build time: 00:03:46

gpg: Signature made Thu 03 Dec 2020 10:22:19 AM UTC
gpg:                using RSA key A624251A26084A9ED9E4C8B6425F639D3960FA9E
gpg:                issuer "[email protected]"
gpg: Good signature from "Sean Young <[email protected]>" [full]

Summary: got 1/1 patches with issues, being 1 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-rc-add-keymap-for-pine64-remote.patch:

allmodconfig: return code #512:
In file included from ../drivers/media/i2c/ccs/ccs.h:19,
from ../drivers/media/i2c/ccs/ccs-core.c:32:
../drivers/media/i2c/ccs/ccs-data.h:40:1: warning: "/*" within comment [-Wcomment]
In file included from ../drivers/media/i2c/ccs/ccs.h:19,
from ../drivers/media/i2c/ccs/ccs-reg-access.c:17:
../drivers/media/i2c/ccs/ccs-data.h:40:1: warning: "/*" within comment [-Wcomment] ../drivers/media/i2c/ccs/ccs-reg-access.c:207:37: error: increment of pointer to an incomplete type ‘struct ccs_reg’ ../drivers/media/i2c/ccs/ccs-reg-access.c:210:11: error: dereferencing pointer to incomplete type ‘struct ccs_reg’ ../drivers/media/i2c/ccs/ccs-reg-access.c:380:37: error: increment of pointer to an incomplete type ‘struct ccs_reg’ In file included from ../include/linux/kernel.h:14,
from ../include/linux/unaligned/access_ok.h:5,
from ../arch/x86/include/asm/unaligned.h:9,
from ../drivers/media/i2c/ccs/ccs-reg-access.c:12:
../include/linux/minmax.h:42:2: error: first argument to ‘__builtin_choose_expr’ not a constant ../include/linux/minmax.h:51:19: note: in expansion of macro ‘__careful_cmp’ ../drivers/media/i2c/ccs/ccs-reg-access.c:388:14: note: in expansion of macro ‘min’
make[4]: *** [../scripts/Makefile.build:283: drivers/media/i2c/ccs/ccs-reg-access.o] Error 1 make[3]: *** [../scripts/Makefile.build:500: drivers/media/i2c/ccs] Error 2
make[2]: *** [../scripts/Makefile.build:500: drivers/media/i2c] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1797: drivers/media] Error 2
make: *** [Makefile:185: __sub-make] Error 2

checkpatch.pl:

	$ cat patches/0001-media-rc-add-keymap-for-pine64-remote.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:34: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
	-:47: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

Error #512 when building PDF docs