drivers: staging: speakup: remove unneeded MODULE_VERSION() call
Subsystems (7)
PATCH 1/11 drivers: staging: speakup: remove unneeded MODULE_VERSION() call
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters.
The drivers have received lots of changes, without the module version (or the underlying DRV_VERSION macro) ever changed, since the code landed in the kernel tree. So, it doesn't seem to have any practical meaning anymore.
--- drivers/accessibility/speakup/main.c | 1 - drivers/accessibility/speakup/speakup_acntpc.c | 1 - drivers/accessibility/speakup/speakup_acntsa.c | 1 - drivers/accessibility/speakup/speakup_apollo.c | 2 -- drivers/accessibility/speakup/speakup_audptr.c | 2 -- drivers/accessibility/speakup/speakup_bns.c | 2 -- drivers/accessibility/speakup/speakup_decext.c | 1 - drivers/accessibility/speakup/speakup_decpc.c | 1 - drivers/accessibility/speakup/speakup_dectlk.c | 1 - drivers/accessibility/speakup/speakup_dtlk.c | 2 -- drivers/accessibility/speakup/speakup_dummy.c | 2 -- drivers/accessibility/speakup/speakup_keypc.c | 1 - drivers/accessibility/speakup/speakup_ltlk.c | 2 -- drivers/accessibility/speakup/speakup_soft.c | 1 - drivers/accessibility/speakup/speakup_spkout.c | 2 -- drivers/accessibility/speakup/speakup_txprt.c | 2 -- 16 files changed, 24 deletions(-)
drivers/accessibility/speakup/main.c +0 -1
@@ -46,7 +46,6 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("Daniel Drake <[email protected]>" );MODULE_DESCRIPTION ("Speakup console speech" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (SPEAKUP_VERSION );char *synth_name;module_param_named (synth, synth_name, charp,0444 );
drivers/accessibility/speakup/speakup_acntpc.c +0 -1
@@ -315,5 +315,4 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Accent PC synthesizer" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_acntsa.c +0 -1
@@ -140,5 +140,4 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Accent SA synthesizer" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_apollo.c +0 -2
@@ -204,5 +204,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Apollo II synthesizer" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_audptr.c +0 -2
@@ -167,5 +167,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Audapter synthesizer" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_bns.c +0 -2
@@ -124,5 +124,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Braille 'n Speak synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_decext.c +0 -1
@@ -236,5 +236,4 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for DECtalk External synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_decpc.c +0 -1
@@ -492,4 +492,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for DECtalk PC synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_dectlk.c +0 -1
@@ -307,5 +307,4 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for DECtalk Express synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_dtlk.c +0 -2
@@ -386,5 +386,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for DoubleTalk PC synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_dummy.c +0 -2
@@ -130,5 +130,3 @@ module_spk_synth(synth_dummy);MODULE_AUTHOR ("Samuel Thibault <[email protected]>" );MODULE_DESCRIPTION ("Speakup support for text console" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_keypc.c +0 -1
@@ -314,5 +314,4 @@ module_spk_synth(synth_keypc);MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Keynote Gold PC synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_ltlk.c +0 -2
@@ -171,5 +171,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for DoubleTalk LT/LiteTalk synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_soft.c +0 -1
@@ -427,4 +427,3 @@ module_spk_synth(synth_soft);MODULE_AUTHOR ("Kirk Reiser <[email protected]>" );MODULE_DESCRIPTION ("Speakup userspace software synthesizer support" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );
drivers/accessibility/speakup/speakup_spkout.c +0 -2
@@ -135,5 +135,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Speak Out synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
drivers/accessibility/speakup/speakup_txprt.c +0 -2
@@ -123,5 +123,3 @@ MODULE_AUTHOR("Kirk Reiser <[email protected]>");MODULE_AUTHOR ("David Borowski" );MODULE_DESCRIPTION ("Speakup support for Transport synthesizers" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION ); -
Signature · 1 line
2.11.0
PATCH 2/11 drivers: staging: gasket: remove unneeded MODULE_VERSION() call
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code has received lots of changes, w/o the versions being actively maintained, so it doesn't seem to have much practical meaning.
--- drivers/staging/gasket/apex_driver.c | 1 - drivers/staging/gasket/gasket_core.c | 1 - 2 files changed, 2 deletions(-)
drivers/staging/gasket/apex_driver.c +0 -1
@@ -718,7 +718,6 @@ static void apex_exit(void)gasket_unregister_device (&apex_desc); }MODULE_DESCRIPTION ("Google Apex driver" ); -MODULE_VERSION (APEX_DRIVER_VERSION );MODULE_LICENSE ("GPL v2" );MODULE_AUTHOR ("John Joseph <[email protected]>" );MODULE_DEVICE_TABLE (pci, apex_pci_ids);
drivers/staging/gasket/gasket_core.c +0 -1
@@ -1809,7 +1809,6 @@ static int __init gasket_init(void) }MODULE_DESCRIPTION ("Google Gasket driver framework" ); -MODULE_VERSION (GASKET_FRAMEWORK_VERSION );MODULE_LICENSE ("GPL v2" );MODULE_AUTHOR ("Rob Springer <[email protected]>" );module_init (gasket_init);
Signature · 1 line
2.11.0
PATCH 3/11 drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters. And the code has received lots of changes, without the version ever been touched (remained constant since landing in the mainline tree), so it doesn't seem to have any practical meaning anymore.
--- drivers/staging/gdm724x/gdm_lte.h | 1 - drivers/staging/gdm724x/gdm_usb.c | 1 - 2 files changed, 2 deletions(-)
drivers/staging/gdm724x/gdm_lte.h +0 -1
@@ -11,7 +11,6 @@#define MAX_NIC_TYPE 4#define MAX_RX_SUBMIT_COUNT 3 -#define DRIVER_VERSION "3.7.17.0"enum TX_ERROR_CODE {TX_NO_ERROR =0 ,
drivers/staging/gdm724x/gdm_usb.c +0 -1
@@ -1003,6 +1003,5 @@ static void __exit gdm_usb_lte_exit(void)module_init (gdm_usb_lte_init);module_exit (gdm_usb_lte_exit); -MODULE_VERSION (DRIVER_VERSION );MODULE_DESCRIPTION ("GCT LTE USB Device Driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.11.0
PATCH 4/11 drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to have much practical purpose. For in-kernel drivers, the kernel version matters. The driver received lots of changes, but version number has remained the same since it's introducing into mainline, seven years ago. So, it doesn't seem to have much practical meaning anymore.
--- drivers/staging/goldfish/goldfish_audio.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/goldfish/goldfish_audio.c +0 -1
@@ -24,7 +24,6 @@MODULE_AUTHOR ("Google, Inc." );MODULE_DESCRIPTION ("Android QEMU Audio Driver" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION ("1.0" );struct goldfish_audio {char __iomem *reg_base;
Signature · 1 line
2.11.0
Re: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
Quoted 16 lines · metux IT consult
Remove
MODULE_VERSION(), as it doesn't seem to have much practical purpose. For in-kernel drivers, the kernel version matters. The driver received lots of changes, but version number has remained the same since it's introducing into mainline, seven years ago. So, it doesn't seem to have much practical meaning anymore.Signed-off-by Enrico Weigelt <[email protected]>--- drivers/staging/goldfish/goldfish_audio.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/goldfish/goldfish_audio.c +0
-0
drivers/staging/goldfish/goldfish_audio.c line 29
Quoted 7 lines
drivers/staging/goldfish/goldfish_audio.c +0
-1@@ -24,7 +24,6 @@MODULE_AUTHOR ("Google, Inc." );MODULE_DESCRIPTION ("Android QEMU Audio Driver" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION ("1.0" );struct goldfish_audio {char __iomem *reg_base;
This file isn't even in my tree, are you sure you made this patch series against the correct branch/tree?
Please fix this series up and resend.
thanks,
greg k-h
PATCH 5/11 drivers: staging: media: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code received lots of changes, but module version remained constant, since the driver landed in mainline. So, this version doesn't seem have any practical meaning anymore.
--- drivers/staging/media/omap4iss/iss.c | 1 - drivers/staging/media/omap4iss/iss_video.h | 1 - 2 files changed, 2 deletions(-)
drivers/staging/media/omap4iss/iss.c +0 -1
@@ -1349,4 +1349,3 @@ module_platform_driver(iss_driver);MODULE_DESCRIPTION ("TI OMAP4 ISS driver" );MODULE_AUTHOR ("Sergio Aguirre <[email protected]>" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (ISS_VIDEO_DRIVER_VERSION );
drivers/staging/media/omap4iss/iss_video.h +0 -1
@@ -18,7 +18,6 @@#include <media/videobuf2-dma-contig.h> #define ISS_VIDEO_DRIVER_NAME "issvideo" -#define ISS_VIDEO_DRIVER_VERSION "0.0.2"struct iss_device ;struct iss_video ;
Signature · 1 line
2.11.0
PATCH 6/11 drivers: staging: qlge: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version really matters. The module version doesn't seem to be maintained and having much practical meaning anymore.
--- drivers/staging/qlge/qlge_main.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/qlge/qlge_main.c +0 -1
@@ -49,7 +49,6 @@ const char qlge_driver_version[] = DRV_VERSION;MODULE_AUTHOR ("Ron Mercer <[email protected]>" );MODULE_DESCRIPTION (DRV_STRING " " );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );static const u32 default_msg = NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK |
Signature · 1 line
2.11.0
PATCH 7/11 drivers: staging: vc04_services: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to have any practical purpose. For in-tree drivers, the kernel version really matters. OTOH, the module version doesn't seem to be actively maintained - the code received changes while the version remained constant.
--- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +0 -1
@@ -2011,5 +2011,4 @@ module_platform_driver(bcm2835_camera_driver)MODULE_DESCRIPTION ("Broadcom 2835 MMAL video capture" );MODULE_AUTHOR ("Vincent Sanders" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (BM2835_MMAL_VERSION );MODULE_ALIAS ("platform:bcm2835-camera" );
Signature · 1 line
2.11.0
PATCH 8/11 drivers: staging: rtl8188eu: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters most. The driver received lots of changes, while module version remained constant, since it landed in mainline, back 7 years ago.
--- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/rtl8188eu/os_dep/os_intfs.c +0 -1
@@ -18,7 +18,6 @@MODULE_LICENSE ("GPL" );MODULE_DESCRIPTION ("Realtek Wireless Lan Driver" );MODULE_AUTHOR ("Realtek Semiconductor Corp." ); -MODULE_VERSION (DRIVERVERSION );MODULE_FIRMWARE ("rtlwifi/rtl8188eufw.bin" );#define RTW_NOTCH_FILTER 0/* 0:Disable, 1:Enable, */
Signature · 1 line
2.11.0
PATCH 9/11 drivers: staging: rtl8192e: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to have any practical purpose:
the driver has received lots of changes, while the module version remained constant. Unmaintained version numbers aren't actually useful.
--- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +0 -1
@@ -2635,7 +2635,6 @@ void rtl92e_check_rfctrl_gpio_timer(struct timer_list *t)***************************************************************************/ MODULE_DESCRIPTION ("Linux driver for Realtek RTL819x WiFi cards" );MODULE_AUTHOR (DRV_COPYRIGHT " " DRV_AUTHOR ); -MODULE_VERSION (DRV_VERSION );MODULE_LICENSE ("GPL" );MODULE_FIRMWARE (RTL8192E_BOOT_IMG_FW );MODULE_FIRMWARE (RTL8192E_MAIN_IMG_FW );
Signature · 1 line
2.11.0
PATCH 10/11 drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to have any pratical purpose. The code received lots of huge changes, but module version remained constant, since it landed in mainline tree, back 11 years go. Unmaintained version numbers aren't actually useful. For in-tree drivers, the kernel version really matters.
--- drivers/staging/rtl8192u/r8192U_core.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/r8192U_core.c +0 -1
@@ -90,7 +90,6 @@ static const struct usb_device_id rtl8192_usb_id_tbl[] = { };MODULE_LICENSE ("GPL" ); -MODULE_VERSION ("V 1.1" );MODULE_DEVICE_TABLE (usb, rtl8192_usb_id_tbl);MODULE_DESCRIPTION ("Linux driver for Realtek RTL8192 USB WiFi cards" );
Signature · 1 line
2.11.0
PATCH 11/11 drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call
In reply to Enrico Weigelt, metux IT consultRemove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. The driver received lots of changes, but module remained constant since it landed in mainline, several years ago.
--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1
@@ -13,7 +13,6 @@MODULE_LICENSE ("GPL" );MODULE_DESCRIPTION ("Realtek Wireless Lan Driver" );MODULE_AUTHOR ("Realtek Semiconductor Corp." ); -MODULE_VERSION (DRIVERVERSION );/* module param defaults */ static int rtw_chip_version;
Signature · 1 line
2.11.0
Quoted 11 lines · metux IT consult
Remove
MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters.The drivers have received lots of changes, without the module version (or the underlying
DRV_VERSIONmacro) ever changed, since the code landed in the kernel tree. So, it doesn't seem to have any practical meaning anymore.Signed-off-by Enrico Weigelt <[email protected]>--- drivers/accessibility/speakup/main.c | 1 -
<snip>
Yous subject line is odd, these are not "staging" drivers anymore, so why do you say they are there?
thanks,
greg k-h
Quoted 9 lines · Greg KH
Quoted 8 lines · metux IT consult
Remove
MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters.The drivers have received lots of changes, without the module version (or the underlying
DRV_VERSIONmacro) ever changed, since the code landed in the kernel tree. So, it doesn't seem to have any practical meaning anymore.
Quoted 8 lines
Quoted 3 lines
Signed-off-by Enrico Weigelt <[email protected]>--- drivers/accessibility/speakup/main.c | 1 -<snip>
Yous subject line is odd, these are not "staging" drivers anymore, so why do you say they are there?
Also putting "drivers:" in the subject always seems superfluous.
regards,
dan carpenter