Skip to contentSkip to conversation

net/bnxt: disable receive end-of-packet padding

PATCH In review Lance Richardson 2 participants 2 messages Dec 3, 2020 – Dec 8, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: disable receive end-of-packet padding

Testing has shown that the packet forwarding rate for packet sizes that are not a multiple of the cache line size is reduced when the DMA size is padded to a multiple of the cache line size. Improve performance for these packet sizes by disabling EOP padding.

Fixes f4253e97e7b0 ("net/bnxt: set padding flags in Rx descriptor")
---
 drivers/net/bnxt/bnxt_rxr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxr.c +1 -1
index fdbe6f71e..af1774844 100644
@@ -1113,7 +1113,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
 	size = rte_pktmbuf_data_room_size(rxq->mb_pool) - RTE_PKTMBUF_HEADROOM;
 	size = RTE_MIN(BNXT_MAX_PKT_LEN, size);
 
-	type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT | RX_PROD_PKT_BD_FLAGS_EOP_PAD;
+	type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT;
 
 	rxr = rxq->rx_ring;
 	ring = rxr->rx_ring_struct;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 10 lines · Lance Richardson

Testing has shown that the packet forwarding rate for packet sizes that are not a multiple of the cache line size is reduced when the DMA size is padded to a multiple of the cache line size. Improve performance for these packet sizes by disabling EOP padding.

Fixes f4253e97e7b0 ("net/bnxt: set padding flags in Rx descriptor")

Patch applied to dpdk-next-net-brcm. Thanks

Quoted 20 lines
---
 drivers/net/bnxt/bnxt_rxr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxr.c +1 -2
index fdbe6f71e..af1774844 100644
@@ -1113,7 +1113,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
        size = rte_pktmbuf_data_room_size(rxq->mb_pool) - RTE_PKTMBUF_HEADROOM;
        size = RTE_MIN(BNXT_MAX_PKT_LEN, size);
 
-       type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT | RX_PROD_PKT_BD_FLAGS_EOP_PAD;
+       type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT;
 
        rxr = rxq->rx_ring;
        ring = rxr->rx_ring_struct;
--

2.25.1

Signature · 11 lines
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.