f2fs: don't allow any writes on readonly mount
Jaegeuk Kim
maintainerPATCH 1/2 f2fs: don't allow any writes on readonly mount
generic_make_request: Trying to write to read-only block-device dm-5 (partno 0)
WARNING: CPU: 7 PID: 546 at block/blk-core.c:2190 generic_make_request_checks+0x664/0x690 pc : generic_make_request_checks+0x664/0x690 lr : generic_make_request_checks+0x664/0x690 Call trace: generic_make_request_checks+0x664/0x690 generic_make_request+0xf0/0x3a4 submit_bio+0x80/0x250 __submit_merged_bio+0x368/0x4e0 __submit_merged_write_cond.llvm.12294350193007536502+0xe0/0x3e8 f2fs_wait_on_page_writeback+0x84/0x128 f2fs_convert_inline_page+0x35c/0x6f8 f2fs_convert_inline_inode+0xe0/0x2e0 f2fs_file_mmap+0x48/0x9c mmap_region+0x41c/0x74c do_mmap+0x40c/0x4fc vm_mmap_pgoff+0xb8/0x114 vm_mmap+0x34/0x48 elf_map+0x68/0x108 load_elf_binary+0x538/0xb70 search_binary_handler+0xac/0x1dc exec_binprm+0x50/0x15c __do_execve_file+0x620/0x740 __arm64_sys_execve+0x54/0x68 el0_svc_common+0x9c/0x168 el0_svc_handler+0x60/0x6c el0_svc+0x8/0xc
--- fs/f2fs/inline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/f2fs/inline.c +2 -1
@@ -188,7 +188,8 @@ int f2fs_convert_inline_inode(struct inode *inode)struct page *ipage, *page;int err =0 ; -if (!f2fs_has_inline_data (inode)) +if (!f2fs_has_inline_data (inode) || +f2fs_hw_is_readonly (sbi) ||f2fs_readonly (sbi->sb))return 0 ; page =f2fs_grab_cache_page (inode->i_mapping,0 , false);
Signature · 8 lines
2.29.2.576.ga3fc446d84-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Jaegeuk Kim
maintainerPATCH 2/2 f2fs: introduce max_io_bytes, a sysfs entry, to limit bio size
This patch adds max_io_bytes to limit bio size when f2fs tries to merge consecutive IOs. This can give a testing point to split out bios and check end_io handles those bios correctly. This is used to capture a recent bug on the decompression and fsverity flow.
--- Documentation/ABI/testing/sysfs-fs-f2fs | 7 +++++++ fs/f2fs/data.c | 3 +++ fs/f2fs/f2fs.h | 1 + fs/f2fs/sysfs.c | 2 ++ 4 files changed, 13 insertions(+)
Documentation/ABI/testing/sysfs-fs-f2fs +7 -0
@@ -370,3 +370,10 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. +What: /sys/fs/f2fs/<disk>/max_io_bytes +Date: December 2020 +Contact: "Jaegeuk Kim" <[email protected]> +Description: This gives a control to limit the bio size in f2fs. + Default is zero, which will follow underlying block layer limit, + whereas, if it has a certain bytes value, f2fs won't submit a + bio larger than that size.
fs/f2fs/data.c +3 -0
@@ -736,6 +736,9 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio)static bool page_is_mergeable (struct f2fs_sb_info *sbi,struct bio *bio,block_t last_blkaddr,block_t cur_blkaddr) { +if (unlikely (sbi->max_io_bytes && + bio->bi_iter.bi_size >= sbi->max_io_bytes)) +return false;if (last_blkaddr +1 != cur_blkaddr)return false;return __same_bdev (sbi, cur_blkaddr, bio);
fs/f2fs/f2fs.h +1 -0
@@ -1446,6 +1446,7 @@ struct f2fs_sb_info {loff_t max_file_blocks;/* max block index of file */ int dir_level;/* directory level */ int readdir_ra;/* readahead inode in readdir */ +u64 max_io_bytes;/* max io bytes to merge IOs */ block_t user_block_count;/* # of user blocks */ block_t total_valid_block_count;/* # of valid blocks */
fs/f2fs/sysfs.c +2 -0
@@ -567,6 +567,7 @@ F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info,F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, iostat_enable, iostat_enable);F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, iostat_period_ms, iostat_period_ms);F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, readdir_ra, readdir_ra); +F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, max_io_bytes, max_io_bytes);F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, gc_pin_file_thresh, gc_pin_file_threshold);F2FS_RW_ATTR (F2FS_SBI , f2fs_super_block, extension_list, extension_list);#ifdef CONFIG_F2FS_FAULT_INJECTION
@@ -651,6 +652,7 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (iostat_enable),ATTR_LIST (iostat_period_ms),ATTR_LIST (readdir_ra), +ATTR_LIST (max_io_bytes),ATTR_LIST (gc_pin_file_thresh),ATTR_LIST (extension_list), #ifdef CONFIG_F2FS_FAULT_INJECTION
Signature · 8 lines
2.29.2.576.ga3fc446d84-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce max_io_bytes, a sysfs entry, to limit bio size
Quoted 6 lines · Jaegeuk Kim
This patch adds
max_io_bytesto limit bio size when f2fs tries to merge consecutive IOs. This can give a testing point to split out bios and checkend_iohandles those bios correctly. This is used to capture a recent bug on the decompression and fsverity flow.Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 28 lines · Jaegeuk Kim
generic_make_request: Trying to write to read-only block-device dm-5 (partno 0)WARNING: CPU: 7 PID: 546 at block/blk-core.c:2190 generic_make_request_checks+0x664/0x690 pc : generic_make_request_checks+0x664/0x690 lr : generic_make_request_checks+0x664/0x690 Call trace: generic_make_request_checks+0x664/0x690 generic_make_request+0xf0/0x3a4 submit_bio+0x80/0x250 __submit_merged_bio+0x368/0x4e0 __submit_merged_write_cond.llvm.12294350193007536502+0xe0/0x3e8 f2fs_wait_on_page_writeback+0x84/0x128 f2fs_convert_inline_page+0x35c/0x6f8 f2fs_convert_inline_inode+0xe0/0x2e0 f2fs_file_mmap+0x48/0x9c mmap_region+0x41c/0x74c do_mmap+0x40c/0x4fc vm_mmap_pgoff+0xb8/0x114 vm_mmap+0x34/0x48 elf_map+0x68/0x108 load_elf_binary+0x538/0xb70 search_binary_handler+0xac/0x1dc exec_binprm+0x50/0x15c __do_execve_file+0x620/0x740 __arm64_sys_execve+0x54/0x68 el0_svc_common+0x9c/0x168 el0_svc_handler+0x60/0x6c el0_svc+0x8/0xc
Quoted 1 line
Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel