Skip to contentSkip to conversation

ASoC: atmel: mchp-spdifrx needs COMMON_CLK

PATCH In review Arnd Bergmann 3 participants 3 messages Dec 3, 2020 – Dec 4, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: atmel: mchp-spdifrx needs COMMON_CLK

From: Arnd Bergmann <[email protected]>

Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with

ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!

Make this is a strict dependency.

Fixes ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
---
 sound/soc/atmel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/atmel/Kconfig +1 -0
index bd8854bfd2ee..142373ec411a 100644
@@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
 config SND_MCHP_SOC_SPDIFRX
 	tristate "Microchip ASoC driver for boards using S/PDIF RX"
 	depends on OF && (ARCH_AT91 || COMPILE_TEST)
+	depends on COMMON_CLK
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with

ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!

Make this is a strict dependency.

Fixes ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")

Thanks!

Quoted 19 lines
---
  sound/soc/atmel/Kconfig | 1 +
  1 file changed, 1 insertion(+)
sound/soc/atmel/Kconfig +1 -1
index bd8854bfd2ee..142373ec411a 100644
@@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
  config SND_MCHP_SOC_SPDIFRX
         tristate "Microchip ASoC driver for boards using S/PDIF RX"
         depends on OF && (ARCH_AT91 || COMPILE_TEST)
+       depends on COMMON_CLK
         select SND_SOC_GENERIC_DMAENGINE_PCM
         select REGMAP_MMIO
         help
--

2.27.0

maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 5 lines · Arnd Bergmann

Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with

ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!

Make this is a strict dependency.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: atmel: mchp-spdifrx needs COMMON_CLK

      commit: 29275309b0e32bb838d67158c6b6e687275f43e9

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark