Skip to contentSkip to conversation

clk: imx: fix build failure on i.MX SCU clk

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 3, 2020 – Dec 5, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: imx: fix build failure on i.MX SCU clk

From: Arnd Bergmann <[email protected]>

When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not, the kernel fails to link with:

aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1
aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-lpcg-scu.o] Error 1

The only sensible configuration at the moment is to have both mean the same thing, so make hide the first one to avoid broken configurations.

Fixes e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
---
 drivers/clk/imx/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/clk/imx/Kconfig +1 -3
index 3b393cb07295..47d9ec3abd2f 100644
@@ -5,9 +5,7 @@ config MXC_CLK
 	depends on ARCH_MXC || COMPILE_TEST
 
 config MXC_CLK_SCU
-	tristate "IMX SCU clock"
-	depends on ARCH_MXC || COMPILE_TEST
-	depends on IMX_SCU && HAVE_ARM_SMCCC
+	tristate
 
 config CLK_IMX1
 	def_bool SOC_IMX1
Signature · 1 line
2.27.0
maintainer
#1 lore raw

Quoting Arnd Bergmann (2020-12-03 15:07:52)

Quoted 10 lines

From: Arnd Bergmann <[email protected]>

When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not, the kernel fails to link with:

aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1
aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-lpcg-scu.o] Error 1

Quoted 7 lines

The only sensible configuration at the moment is to have both mean the same thing, so make hide the first one to avoid broken configurations.

Fixes e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")

Dong sent something similar at
https://lore.kernel.org/r/[email protected]