Skip to contentSkip to conversation

ethernet: select CONFIG_CRC32 as needed

PATCH Applied Arnd Bergmann 6 participants 7 messages Dec 3, 2020 – Dec 4, 2020

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethernet: select CONFIG_CRC32 as needed

From: Arnd Bergmann <[email protected]>

A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise:

arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast':
et131x.c:(.text+0x5918): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit':
macb_main.c:(.text+0x4b88): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode':
ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list':
fec_main.c:(.text+0x6120): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address':
fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0xb68): more undefined references to `crc32_le' follow
arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read':
nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire':
nfp_resource.c:(.text+0x144): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list':
lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do':
rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del':
rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb':
arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index':
dr_ste.c:(.text+0x354): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_netdev_set_multicast':
lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le'

Add the missing 'select CRC32' entries in Kconfig for each of them.

---
 drivers/net/ethernet/agere/Kconfig              | 1 +
 drivers/net/ethernet/cadence/Kconfig            | 1 +
 drivers/net/ethernet/faraday/Kconfig            | 1 +
 drivers/net/ethernet/freescale/Kconfig          | 1 +
 drivers/net/ethernet/freescale/fman/Kconfig     | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
 drivers/net/ethernet/microchip/Kconfig          | 1 +
 drivers/net/ethernet/netronome/Kconfig          | 1 +
 drivers/net/ethernet/nxp/Kconfig                | 1 +
 drivers/net/ethernet/rocker/Kconfig             | 1 +
 10 files changed, 10 insertions(+)
drivers/net/ethernet/agere/Kconfig +1 -0
index d92516ae59cc..9cd750184947 100644
@@ -21,6 +21,7 @@ config ET131X
 	tristate "Agere ET-1310 Gigabit Ethernet support"
 	depends on PCI
 	select PHYLIB
+	select CRC32
 	help
 	  This driver supports Agere ET-1310 ethernet adapters.
 
drivers/net/ethernet/cadence/Kconfig +1 -0
index 85858163bac5..e432a68ac520 100644
@@ -23,6 +23,7 @@ config MACB
 	tristate "Cadence MACB/GEM support"
 	depends on HAS_DMA && COMMON_CLK
 	select PHYLINK
+	select CRC32
 	help
 	  The Cadence MACB ethernet interface is found on many Atmel AT32 and
 	  AT91 parts.  This driver also supports the Cadence GEM (Gigabit
drivers/net/ethernet/faraday/Kconfig +1 -0
index c2677ec0564d..3d1e9a302148 100644
@@ -33,6 +33,7 @@ config FTGMAC100
 	depends on !64BIT || BROKEN
 	select PHYLIB
 	select MDIO_ASPEED if MACH_ASPEED_G6
+	select CRC32
 	help
 	  This driver supports the FTGMAC100 Gigabit Ethernet controller
 	  from Faraday. It is used on Faraday A369, Andes AG102 and some
drivers/net/ethernet/freescale/Kconfig +1 -0
index a1d53ddf1593..3f9175bdce77 100644
@@ -25,6 +25,7 @@ config FEC
 	depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
 		   ARCH_MXC || SOC_IMX28 || COMPILE_TEST)
 	default ARCH_MXC || SOC_IMX28 if ARM
+	select CRC32
 	select PHYLIB
 	imply PTP_1588_CLOCK
 	help
drivers/net/ethernet/freescale/fman/Kconfig +1 -0
index 34150182cc35..48bf8088795d 100644
@@ -4,6 +4,7 @@ config FSL_FMAN
 	depends on FSL_SOC || ARCH_LAYERSCAPE || COMPILE_TEST
 	select GENERIC_ALLOCATOR
 	select PHYLIB
+	select CRC32
 	default n
 	help
 		Freescale Data-Path Acceleration Architecture Frame Manager
drivers/net/ethernet/mellanox/mlx5/core/Kconfig +1 -0
index 99f1ec3b2575..3e371d24c462 100644
@@ -198,6 +198,7 @@ config MLX5_EN_TLS
 config MLX5_SW_STEERING
 	bool "Mellanox Technologies software-managed steering"
 	depends on MLX5_CORE_EN && MLX5_ESWITCH
+	select CRC32
 	default y
 	help
 	Build support for software-managed steering in the NIC.
drivers/net/ethernet/microchip/Kconfig +1 -0
index 31f9a82dc113..d0f6dfe0dcf3 100644
@@ -47,6 +47,7 @@ config LAN743X
 	depends on PCI
 	select PHYLIB
 	select CRC16
+	select CRC32
 	help
 	  Support for the Microchip LAN743x PCI Express Gigabit Ethernet chip
 
drivers/net/ethernet/netronome/Kconfig +1 -0
index d8b99d6a0356..b82758d5beed 100644
@@ -22,6 +22,7 @@ config NFP
 	depends on VXLAN || VXLAN=n
 	depends on TLS && TLS_DEVICE || TLS_DEVICE=n
 	select NET_DEVLINK
+	select CRC32
 	help
 	  This driver supports the Netronome(R) NFP4000/NFP6000 based
 	  cards working as a advanced Ethernet NIC.  It works with both
drivers/net/ethernet/nxp/Kconfig +1 -0
index ee83a71c2509..c84997db828c 100644
@@ -3,6 +3,7 @@ config LPC_ENET
 	tristate "NXP ethernet MAC on LPC devices"
 	depends on ARCH_LPC32XX || COMPILE_TEST
 	select PHYLIB
+	select CRC32
 	help
 	  Say Y or M here if you want to use the NXP ethernet MAC included on
 	  some NXP LPC devices. You can safely enable this option for LPC32xx
drivers/net/ethernet/rocker/Kconfig +1 -0
index 99e1290e0307..2318811ff75a 100644
@@ -19,6 +19,7 @@ if NET_VENDOR_ROCKER
 config ROCKER
 	tristate "Rocker switch driver (EXPERIMENTAL)"
 	depends on PCI && NET_SWITCHDEV && BRIDGE
+	select CRC32
 	help
 	  This driver supports Rocker switch device.
 
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw
Quoted 36 lines · Arnd Bergmann

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

From: Arnd Bergmann <[email protected]>

A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise:

arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast':
et131x.c:(.text+0x5918): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit':
macb_main.c:(.text+0x4b88): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode':
ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list':
fec_main.c:(.text+0x6120): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address':
fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0xb68): more undefined references to `crc32_le' follow
arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read':
nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire':
nfp_resource.c:(.text+0x144): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list':
lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do':
rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del':
rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb':
arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index':
dr_ste.c:(.text+0x354): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_netdev_set_multicast':
lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le'

Quoted 6 lines

Add the missing 'select CRC32' entries in Kconfig for each of them.

---
  drivers/net/ethernet/agere/Kconfig              | 1 +
  drivers/net/ethernet/cadence/Kconfig            | 1 +

For Cadence macb driver:

Quoted 133 lines
  drivers/net/ethernet/faraday/Kconfig            | 1 +
  drivers/net/ethernet/freescale/Kconfig          | 1 +
  drivers/net/ethernet/freescale/fman/Kconfig     | 1 +
  drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
  drivers/net/ethernet/microchip/Kconfig          | 1 +
  drivers/net/ethernet/netronome/Kconfig          | 1 +
  drivers/net/ethernet/nxp/Kconfig                | 1 +
  drivers/net/ethernet/rocker/Kconfig             | 1 +
  10 files changed, 10 insertions(+)
drivers/net/ethernet/agere/Kconfig +1 -0
index d92516ae59cc..9cd750184947 100644
@@ -21,6 +21,7 @@ config ET131X
         tristate "Agere ET-1310 Gigabit Ethernet support"
         depends on PCI
         select PHYLIB
+       select CRC32
         help
           This driver supports Agere ET-1310 ethernet adapters.
 
drivers/net/ethernet/cadence/Kconfig +1 -0
index 85858163bac5..e432a68ac520 100644
@@ -23,6 +23,7 @@ config MACB
         tristate "Cadence MACB/GEM support"
         depends on HAS_DMA && COMMON_CLK
         select PHYLINK
+       select CRC32
         help
           The Cadence MACB ethernet interface is found on many Atmel AT32 and
           AT91 parts.  This driver also supports the Cadence GEM (Gigabit
drivers/net/ethernet/faraday/Kconfig +1 -0
index c2677ec0564d..3d1e9a302148 100644
@@ -33,6 +33,7 @@ config FTGMAC100
         depends on !64BIT || BROKEN
         select PHYLIB
         select MDIO_ASPEED if MACH_ASPEED_G6
+       select CRC32
         help
           This driver supports the FTGMAC100 Gigabit Ethernet controller
           from Faraday. It is used on Faraday A369, Andes AG102 and some
drivers/net/ethernet/freescale/Kconfig +1 -0
index a1d53ddf1593..3f9175bdce77 100644
@@ -25,6 +25,7 @@ config FEC
         depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
                    ARCH_MXC || SOC_IMX28 || COMPILE_TEST)
         default ARCH_MXC || SOC_IMX28 if ARM
+       select CRC32
         select PHYLIB
         imply PTP_1588_CLOCK
         help
drivers/net/ethernet/freescale/fman/Kconfig +1 -0
index 34150182cc35..48bf8088795d 100644
@@ -4,6 +4,7 @@ config FSL_FMAN
         depends on FSL_SOC || ARCH_LAYERSCAPE || COMPILE_TEST
         select GENERIC_ALLOCATOR
         select PHYLIB
+       select CRC32
         default n
         help
                 Freescale Data-Path Acceleration Architecture Frame Manager
drivers/net/ethernet/mellanox/mlx5/core/Kconfig +1 -0
index 99f1ec3b2575..3e371d24c462 100644
@@ -198,6 +198,7 @@ config MLX5_EN_TLS
  config MLX5_SW_STEERING
         bool "Mellanox Technologies software-managed steering"
         depends on MLX5_CORE_EN && MLX5_ESWITCH
+       select CRC32
         default y
         help
         Build support for software-managed steering in the NIC.
drivers/net/ethernet/microchip/Kconfig +1 -0
index 31f9a82dc113..d0f6dfe0dcf3 100644
@@ -47,6 +47,7 @@ config LAN743X
         depends on PCI
         select PHYLIB
         select CRC16
+       select CRC32
         help
           Support for the Microchip LAN743x PCI Express Gigabit Ethernet chip
 
drivers/net/ethernet/netronome/Kconfig +1 -0
index d8b99d6a0356..b82758d5beed 100644
@@ -22,6 +22,7 @@ config NFP
         depends on VXLAN || VXLAN=n
         depends on TLS && TLS_DEVICE || TLS_DEVICE=n
         select NET_DEVLINK
+       select CRC32
         help
           This driver supports the Netronome(R) NFP4000/NFP6000 based
           cards working as a advanced Ethernet NIC.  It works with both
drivers/net/ethernet/nxp/Kconfig +1 -0
index ee83a71c2509..c84997db828c 100644
@@ -3,6 +3,7 @@ config LPC_ENET
         tristate "NXP ethernet MAC on LPC devices"
         depends on ARCH_LPC32XX || COMPILE_TEST
         select PHYLIB
+       select CRC32
         help
           Say Y or M here if you want to use the NXP ethernet MAC included on
           some NXP LPC devices. You can safely enable this option for LPC32xx
drivers/net/ethernet/rocker/Kconfig +1 -1
index 99e1290e0307..2318811ff75a 100644
@@ -19,6 +19,7 @@ if NET_VENDOR_ROCKER
  config ROCKER
         tristate "Rocker switch driver (EXPERIMENTAL)"
         depends on PCI && NET_SWITCHDEV && BRIDGE
+       select CRC32
         help
           This driver supports Rocker switch device.
 
--

2.27.0

Signature · 1 line
Nicolas Ferre
Acked-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 71 lines

-----Original Message-----
From: Arnd Bergmann <[email protected]>
Sent: 04 December 2020 01:21
To: Mark Einon <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; Nicolas Ferre <[email protected]>; Claudiu Beznea <[email protected]>; Madalin Bucur <[email protected]>; Saeed Mahameed <[email protected]>; Leon Romanovsky <[email protected]>; Simon Horman <[email protected]>; Jiri Pirko <[email protected]>
Cc: Arnd Bergmann <[email protected]>; [email protected]; linux- [email protected]; [email protected]; oss- [email protected]
Subject: [PATCH] ethernet: select CONFIG_CRC32 as needed

From: Arnd Bergmann <[email protected]>

A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise:

arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast':
et131x.c:(.text+0x5918): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit':
macb_main.c:(.text+0x4b88): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode':
ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list':
fec_main.c:(.text+0x6120): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address':
fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le' arm-linux-gnueabi-ld:
drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0xb68 ): more undefined references to `crc32_le' follow arm-linux-gnueabi-ld:
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read':
nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be'
arm-linux-gnueabi-ld:
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire':
nfp_resource.c:(.text+0x144): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list':
lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do':
rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del':
rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb':
arm-linux-gnueabi-ld:
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index':
dr_ste.c:(.text+0x354): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_netdev_set_multicast':
lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le'

Add the missing 'select CRC32' entries in Kconfig for each of them.

Quoted 12 lines
---
 drivers/net/ethernet/agere/Kconfig              | 1 +
 drivers/net/ethernet/cadence/Kconfig            | 1 +
 drivers/net/ethernet/faraday/Kconfig            | 1 +
 drivers/net/ethernet/freescale/Kconfig          | 1 +
 drivers/net/ethernet/freescale/fman/Kconfig     | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
 drivers/net/ethernet/microchip/Kconfig          | 1 +
 drivers/net/ethernet/netronome/Kconfig          | 1 +
 drivers/net/ethernet/nxp/Kconfig                | 1 +
 drivers/net/ethernet/rocker/Kconfig             | 1 +
 10 files changed, 10 insertions(+)

For the Freescale FMan driver:

maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Arnd Bergmann
Quoted 69 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise:

arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast':
et131x.c:(.text+0x5918): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit':
macb_main.c:(.text+0x4b88): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode':
ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list':
fec_main.c:(.text+0x6120): undefined reference to `crc32_le' arm-linux-gnueabi-ld:
drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address':
fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le' arm-linux-gnueabi-ld:
drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0 xb68): more undefined references to `crc32_le' follow arm-linux-gnueabi-ld:
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read':
nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be'
arm-linux-gnueabi-ld:
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire':
nfp_resource.c:(.text+0x144): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list':
lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do':
rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del':
rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb':
arm-linux-gnueabi-ld:
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index':
dr_ste.c:(.text+0x354): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o:
in function `lan743x_netdev_set_multicast':
lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le'

Add the missing 'select CRC32' entries in Kconfig for each of them.

---
 drivers/net/ethernet/agere/Kconfig              | 1 + drivers/net/ethernet/cadence/Kconfig            | 1 + drivers/net/ethernet/faraday/Kconfig            | 1 + drivers/net/ethernet/freescale/Kconfig          | 1 + drivers/net/ethernet/freescale/fman/Kconfig     | 1 + drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + drivers/net/ethernet/microchip/Kconfig          | 1 + drivers/net/ethernet/netronome/Kconfig          | 1 + drivers/net/ethernet/nxp/Kconfig                | 1 + drivers/net/ethernet/rocker/Kconfig             | 1 +

Quoted 1 line
 10 files changed, 10 insertions(+)

For the Agere et131x driver:

Acked-by on v1 1/1
#4 lore raw
In reply to Arnd Bergmann
Quoted 37 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise:

arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast':
et131x.c:(.text+0x5918): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit':
macb_main.c:(.text+0x4b88): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode':
ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list':
fec_main.c:(.text+0x6120): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address':
fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0xb68): more undefined references to `crc32_le' follow
arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read':
nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire':
nfp_resource.c:(.text+0x144): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be'
arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list':
lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do':
rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del':
rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb':
arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index':
dr_ste.c:(.text+0x354): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_netdev_set_multicast':
lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le'

Add the missing 'select CRC32' entries in Kconfig for each of them.

Quoted 12 lines
---
 drivers/net/ethernet/agere/Kconfig              | 1 +
 drivers/net/ethernet/cadence/Kconfig            | 1 +
 drivers/net/ethernet/faraday/Kconfig            | 1 +
 drivers/net/ethernet/freescale/Kconfig          | 1 +
 drivers/net/ethernet/freescale/fman/Kconfig     | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
 drivers/net/ethernet/microchip/Kconfig          | 1 +
 drivers/net/ethernet/netronome/Kconfig          | 1 +
 drivers/net/ethernet/nxp/Kconfig                | 1 +
 drivers/net/ethernet/rocker/Kconfig             | 1 +
 10 files changed, 10 insertions(+)

Hi Arnd,

I'm slightly curious to know how you configured the kernel to build the Netronome NFP driver but not CRC32 but nonetheless I have no objection to this change.

For the Netronome portion:

#5 lore raw
Quoted 4 lines · Simon Horman

I'm slightly curious to know how you configured the kernel to build the Netronome NFP driver but not CRC32 but nonetheless I have no objection to this change.

I ran into one link error on a randconfig build and then tried an 'allyesconfig' configuration, turning everything off manually that selects CRC32.

Working through the resulting link errors ended up being more work than I was planning for though, so I don't recommend reproducing this. I have another 25 patches for other subsystems.

Arnd