Skip to contentSkip to conversation

realtime: Remove robust_api check

PATCH New Joerg Vehlow 2 participants 2 messages Dec 4, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 realtime: Remove robust_api check

From: Joerg Vehlow <[email protected]>

pthread_mutexattr_*robust is implemented in glibc for the last 10 years. It is not required anymore to check if it is available. Additonally the implementation is broken, because the macro HAS_PTHREAD_MUTEXTATTR_ROBUST_APIS was not set.

---
 testcases/realtime/configure.ac               |  1 -
 testcases/realtime/func/pi-tests/sbrk_mutex.c | 11 -----------
 testcases/realtime/func/pi-tests/testpi-6.c   |  8 --------
 testcases/realtime/m4/check.m4                | 10 ----------
 4 files changed, 30 deletions(-)
testcases/realtime/configure.ac +0 -1
index 46a616bfc..e483caf0d 100644
@@ -36,7 +36,6 @@ else
 fi
 
 REALTIME_CHECK_PRIO_INHERIT
-REALTIME_CHECK_ROBUST_APIS
 
 LTP_CHECK_EXP10
 
testcases/realtime/func/pi-tests/sbrk_mutex.c +0 -11
index c0431d7da..7ed7969d9 100644
@@ -45,8 +45,6 @@
 #include <unistd.h>
 #include "librttest.h"
 
-#if HAS_PTHREAD_MUTEXTATTR_ROBUST_APIS
-
 #define NUM_MUTEXES 5000
 #define NUM_THREADS 50
 #define NUM_CONCURRENT_LOCKS 50
@@ -150,12 +148,3 @@ int main(int argc, char *argv[])
 
 	return 0;
 }
-
-#else
-int main(void)
-{
-	printf
-	    ("Your system doesn't support the pthread robust mutexattr APIs\n");
-	return 1;
-}
-#endif
testcases/realtime/func/pi-tests/testpi-6.c +0 -8
index 96321f622..637d38355 100644
@@ -41,7 +41,6 @@
 #include <unistd.h>
 #include <librttest.h>
 
-#if HAS_PTHREAD_MUTEXTATTR_ROBUST_APIS
 pthread_mutex_t child_mutex;
 
 void *child_thread(void *arg)
@@ -92,12 +91,5 @@ int do_test(int argc, char **argv)
 
 	return 0;
 }
-#else
-int do_test(int argc, char **argv)
-{
-	printf("Your system doesn't have robust pthread mutex support\n");
-	return 1;
-}
-#endif
 
 #include "test-skeleton.c"
testcases/realtime/m4/check.m4 +0 -10
index 5aa53bd42..e60ae1928 100644
@@ -12,13 +12,3 @@ else
 	AC_MSG_RESULT(no)
 fi
 ])
-
-AC_DEFUN([REALTIME_CHECK_ROBUST_APIS],[
-	AC_CHECK_DECLS([pthread_mutexattr_getrobust, pthread_mutexattr_setrobust],[],[has_robust="no"],[[#include <pthread.h>]])
-	AC_MSG_CHECKING([for pthread_mutexattr_*robust* APIs])
-if test "x$has_robust" != "xno"; then
-	AC_MSG_RESULT(yes)
-else
-	AC_MSG_RESULT(no)
-fi
-])
Signature · 1 line
2.25.1