Skip to contentSkip to conversation

fix dt_binding_check warnings

PATCH Applied Zhen Lei 5 participants 17 messages Dec 4, 2020 – Dec 19, 2020

Subsystems (7)
lore
Share & tools
lore

Zhen Lei

author
#0 lore raw

cover fix dt_binding_check warnings

These patches is based on the latest linux-next code.

When I do dt_binding_check for any YAML file, below wanrings is always reported:

/root/linux-next/Documentation/devicetree/bindings/serial/litex,liteuart.yaml: 'additionalProperties' is a required property /root/linux-next/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml: 'additionalProperties' is a required property /root/linux-next/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml: 'additionalProperties' is a required property /root/linux-next/Documentation/devicetree/bindings/media/coda.yaml: 'additionalProperties' is a required property /root/linux-next/Documentation/devicetree/bindings/media/coda.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/media/coda.yaml /root/linux-next/Documentation/devicetree/bindings/serial/litex,liteuart.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml /root/linux-next/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml /root/linux-next/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml /root/linux-next/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /root/linux-next/Documentation/devicetree/bindings/leds/leds-pwm.yaml

I have done the dtbs_check for all 5 yaml files on both arm32 and arm64.

Zhen Lei (5):
media: dt-bindings: add the required property 'additionalProperties'
dt-bindings: serial: add the required property 'additionalProperties'
dt-bindings: soc: add the required property 'additionalProperties'
dt-bindings: devapc: add the required property 'additionalProperties'
dt-bindings: mfd: correct the node name of the panel led

 Documentation/devicetree/bindings/media/coda.yaml                   | 6 ++++++
 Documentation/devicetree/bindings/mfd/iqs62x.yaml                   | 2 +-
 Documentation/devicetree/bindings/serial/litex,liteuart.yaml        | 2 ++
 .../devicetree/bindings/soc/litex/litex,soc-controller.yaml         | 2 ++
 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml          | 2 ++
 5 files changed, 13 insertions(+), 1 deletion(-)
Signature · 8 lines
1.8.3



_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
author
#1 lore raw

PATCH 1/5 media: dt-bindings: add the required property 'additionalProperties'

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/media/coda.yaml: 'additionalProperties' is a required property xxx/media/coda.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/media/coda.yaml

There are three properties defined in allOf, they should be explicitly declared. Otherwise, "additionalProperties: false" will prohibit them.

---
 Documentation/devicetree/bindings/media/coda.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/coda.yaml +6 -0
index 7bac0057faf7319..199b0826cd01cb6 100644
@@ -52,6 +52,10 @@ properties:
     description: phandle pointing to the SRAM device node
     maxItems: 1
 
+  interrupts: true
+  interrupt-names: true
+  power-domains: true
+
 required:
   - compatible
   - reg
@@ -96,6 +100,8 @@ allOf:
           description: phandle pointing to the PU power domain
           maxItems: 1
 
+additionalProperties: false
+
 examples:
   - |
     vpu: video-codec@63ff4000 {
Signature · 1 line
1.8.3
maintainer
#2 lore raw

Re: [PATCH 1/5] media: dt-bindings: add the required property 'additionalProperties'

Quoted 11 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/media/coda.yaml: 'additionalProperties' is a required property xxx/media/coda.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/media/coda.yaml

There are three properties defined in allOf, they should be explicitly declared. Otherwise, "additionalProperties: false" will prohibit them.

Thank you, there already is a patch to fix this:

https://lore.kernel.org/linux-media/[email protected]/

regards
Philipp

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

#3 lore raw

Re: [PATCH 1/5] media: dt-bindings: add the required property 'additionalProperties'

Quoted 8 lines · Philipp Zabel
Quoted 7 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/media/coda.yaml: 'additionalProperties' is a required property xxx/media/coda.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/media/coda.yaml

Quoted 8 lines
Quoted 4 lines

There are three properties defined in allOf, they should be explicitly declared. Otherwise, "additionalProperties: false" will prohibit them.

Thank you, there already is a patch to fix this:

https://lore.kernel.org/linux-media/[email protected]/

OK. I found it temporarily during do a JSON conversion,I have not subscribed the dt-binding maillist.

Quoted 6 lines

regards
Philipp

.

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#4 lore raw

PATCH 2/5 dt-bindings: serial: add the required property 'additionalProperties'

In reply to Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/serial/litex,liteuart.yaml: 'additionalProperties' is a required property xxx/serial/litex,liteuart.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/serial/litex,liteuart.yaml

---
 Documentation/devicetree/bindings/serial/litex,liteuart.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/serial/litex,liteuart.yaml +2 -0
index bc79b3cca542437..c4f1f489dc2d091 100644
@@ -29,6 +29,8 @@ required:
   - compatible
   - reg
 
+additionalProperties: false
+
 examples:
   - |
     uart0: serial@e0001800 {
Signature · 8 lines
1.8.3



_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer Reviewed-by on v1 2/5
#5 lore raw

Re: [PATCH 2/5] dt-bindings: serial: add the required property 'additionalProperties'

Quoted 12 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/serial/litex,liteuart.yaml: 'additionalProperties' is a required property xxx/serial/litex,liteuart.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/serial/litex,liteuart.yaml

---
 Documentation/devicetree/bindings/serial/litex,liteuart.yaml | 2 ++
 1 file changed, 2 insertions(+)

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer Applied
#6 lore raw

Re: [PATCH 2/5] dt-bindings: serial: add the required property 'additionalProperties'

In reply to Zhen Lei
Quoted 12 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/serial/litex,liteuart.yaml: 'additionalProperties' is a required property xxx/serial/litex,liteuart.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/serial/litex,liteuart.yaml

---
 Documentation/devicetree/bindings/serial/litex,liteuart.yaml | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#7 lore raw

PATCH 3/5 dt-bindings: soc: add the required property 'additionalProperties'

In reply to Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/litex/litex,soc-controller.yaml: 'additionalProperties' is a required property xxx/soc/litex/litex,soc-controller.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/litex/litex,soc-controller.yaml

---
 Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml +2 -0
index e2b788796e791ab..c8b57c7fd08c23d 100644
@@ -28,6 +28,8 @@ required:
   - compatible
   - reg
 
+additionalProperties: false
+
 examples:
   - |
     soc_ctrl0: soc-controller@f0000000 {
Signature · 8 lines
1.8.3



_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer Reviewed-by on v1 3/5
#8 lore raw

Re: [PATCH 3/5] dt-bindings: soc: add the required property 'additionalProperties'

Quoted 12 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/litex/litex,soc-controller.yaml: 'additionalProperties' is a required property xxx/soc/litex/litex,soc-controller.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/litex/litex,soc-controller.yaml

---
 Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml | 2 ++
 1 file changed, 2 insertions(+)

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer Applied
#9 lore raw

Re: [PATCH 3/5] dt-bindings: soc: add the required property 'additionalProperties'

In reply to Zhen Lei
Quoted 12 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/litex/litex,soc-controller.yaml: 'additionalProperties' is a required property xxx/soc/litex/litex,soc-controller.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/litex/litex,soc-controller.yaml

---
 Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

#10 lore raw

Re: [PATCH 3/5] dt-bindings: soc: add the required property 'additionalProperties'

Quoted 8 lines · Rob Herring
Quoted 7 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/litex/litex,soc-controller.yaml: 'additionalProperties' is a required property xxx/soc/litex/litex,soc-controller.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/litex/litex,soc-controller.yaml

Quoted 7 lines
Quoted 5 lines
---
 Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!

Thank you!

-Stafford

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#11 lore raw

PATCH 4/5 dt-bindings: devapc: add the required property 'additionalProperties'

In reply to Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/mediatek/devapc.yaml: 'additionalProperties' is a required property xxx/soc/mediatek/devapc.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/mediatek/devapc.yaml

---
 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/soc/mediatek/devapc.yaml +2 -0
index 6c763f873a632d2..31e4d3c339bfe72 100644
@@ -44,6 +44,8 @@ required:
   - clocks
   - clock-names
 
+additionalProperties: false
+
 examples:
   - |
     #include <dt-bindings/interrupt-controller/arm-gic.h>
Signature · 8 lines
1.8.3



_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer Reviewed-by on v1 4/5
#12 lore raw

Re: [PATCH 4/5] dt-bindings: devapc: add the required property 'additionalProperties'

Quoted 12 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/mediatek/devapc.yaml: 'additionalProperties' is a required property xxx/soc/mediatek/devapc.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/mediatek/devapc.yaml

---
 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml | 2 ++
 1 file changed, 2 insertions(+)

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer Applied
#13 lore raw

Re: [PATCH 4/5] dt-bindings: devapc: add the required property 'additionalProperties'

In reply to Zhen Lei
Quoted 12 lines · Zhen Lei

When I do dt_binding_check for any YAML file, below wanring is always reported:

xxx/soc/mediatek/devapc.yaml: 'additionalProperties' is a required property xxx/soc/mediatek/devapc.yaml: ignoring, error in schema:
warning: no schema found in file: xxx/soc/mediatek/devapc.yaml

---
 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#14 lore raw

PATCH 5/5 dt-bindings: mfd: correct the node name of the panel led

In reply to Zhen Lei

According to the definition in leds-pwm.yaml, the node name of each led must match the regular expression "^led(-[0-9a-f]+)?$". "led" or "led-" followed by a decimal or hexadecimal ID number.

---
 Documentation/devicetree/bindings/mfd/iqs62x.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/iqs62x.yaml +1 -1
index 541b06d80e7337a..044cd7542c2bcf5 100644
@@ -93,7 +93,7 @@ examples:
     pwmleds {
             compatible = "pwm-leds";
 
-            panel {
+            led-1 {
                     pwms = <&iqs620a_pwm 0 1000000>;
                     max-brightness = <255>;
             };
Signature · 8 lines
1.8.3



_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer Reviewed-by on v1 5/5
#15 lore raw

Re: [PATCH 5/5] dt-bindings: mfd: correct the node name of the panel led

Quoted 9 lines · Zhen Lei

According to the definition in leds-pwm.yaml, the node name of each led must match the regular expression "^led(-[0-9a-f]+)?$". "led" or "led-" followed by a decimal or hexadecimal ID number.

---
 Documentation/devicetree/bindings/mfd/iqs62x.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Applied
#16 lore raw

Re: [PATCH 5/5] dt-bindings: mfd: correct the node name of the panel led

In reply to Zhen Lei
Quoted 8 lines · Zhen Lei

According to the definition in leds-pwm.yaml, the node name of each led must match the regular expression "^led(-[0-9a-f]+)?$". "led" or "led-" followed by a decimal or hexadecimal ID number.

---
 Documentation/devicetree/bindings/mfd/iqs62x.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 9 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek