Skip to contentSkip to conversation

nfp: Replace zero-length array with flexible-array member

PATCH Applied Simon Horman 2 participants 2 messages Dec 4, 2020 – Dec 5, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfp: Replace zero-length array with flexible-array member

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays

---
 drivers/net/ethernet/netronome/nfp/crypto/fw.h       | 2 +-
 drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/netronome/nfp/crypto/fw.h +1 -1
index 8d1458896bcb..dcb67c2b5e5e 100644
@@ -40,7 +40,7 @@ struct nfp_crypto_req_add_front {
 	__be16 ipver_vlan __packed;
 	u8 l4_proto;
 #define NFP_NET_TLS_NON_ADDR_KEY_LEN	8
-	u8 l3_addrs[0];
+	u8 l3_addrs[];
 };
 
 struct nfp_crypto_req_add_back {
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c +1 -1
index f18e787fa9ad..10e7d8b21c46 100644
@@ -1070,7 +1070,7 @@ int nfp_nsp_read_module_eeprom(struct nfp_nsp *state, int eth_index,
 		__le16 offset;
 		__le16 readlen;
 		u8 eth_index;
-		u8 data[0];
+		u8 data[];
 	} __packed *buf;
 	int bufsz, ret;
 
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 11 lines · On Fri, 4 Dec 2020 13:56:01 +0100 Simon Horman wrote:

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays

Applied, thank you!