power: bq27xxx: fix polarity of current_now
PATCH 1/1 power: bq27xxx: fix polarity of current_now
current_now has to be negative during discharging and positive during charging, the behavior seen is the other way round.
Tested on GTA04 with Openmoko battery
Signed-off-by Andreas Kemnade <[email protected]>
--- drivers/power/supply/bq27xxx_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/supply/bq27xxx_battery.c +2 -2
@@ -1789,7 +1789,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,if (di->opts &BQ27XXX_O_ZERO ) { flags =bq27xxx_read (di,BQ27XXX_REG_FLAGS , true); -if (flags &BQ27000_FLAG_CHGS ) { +if (!(flags &BQ27000_FLAG_CHGS )) {dev_dbg (di->dev,"negative current!\n" ); curr = -curr; }
@@ -1797,7 +1797,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di, val->intval = curr *BQ27XXX_CURRENT_CONSTANT /BQ27XXX_RS ; }else {/* Other gauges return signed value */ - val->intval = (int )((s16 )curr) *1000 ; + val->intval = -(int )((s16 )curr) *1000 ; }return 0 ;
Signature · 1 line
2.20.1
Hi,
Quoted 7 lines · Andreas Kemnade
current_nowhas to be negative during discharging and positive during charging, the behavior seen is the other way round.Tested on GTA04 with Openmoko battery
Signed-off-by Andreas Kemnade <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 28 lines
drivers/power/supply/bq27xxx_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/power/supply/bq27xxx_battery.c +2
-2@@ -1789,7 +1789,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,if (di->opts &BQ27XXX_O_ZERO ) { flags =bq27xxx_read (di,BQ27XXX_REG_FLAGS , true); -if (flags &BQ27000_FLAG_CHGS ) { +if (!(flags &BQ27000_FLAG_CHGS )) {dev_dbg (di->dev,"negative current!\n" ); curr = -curr; }@@ -1797,7 +1797,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di, val->intval = curr *BQ27XXX_CURRENT_CONSTANT /BQ27XXX_RS ; }else {/* Other gauges return signed value */ - val->intval = (int )((s16 )curr) *1000 ; + val->intval = -(int )((s16 )curr) *1000 ; }return 0 ;Signature · 1 line
2.20.1