Skip to contentSkip to conversation

regulator: da9121: include linux/gpio/consumer.h

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 4, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: da9121: include linux/gpio/consumer.h

From: Arnd Bergmann <[email protected]>

When CONFIG_GPIOLIB is disabled, the declarations from linux/gpio/consumer.h are not visible:

drivers/regulator/da9121-regulator.c:371:14: error: implicit declaration of function 'fwnode_gpiod_get_index' [-Werror,-Wimplicit-function-declaration]
ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
^
drivers/regulator/da9121-regulator.c:372:7: error: use of undeclared identifier 'GPIOD_OUT_HIGH'

                                                GPIOD_OUT_HIGH |
                                                ^

drivers/regulator/da9121-regulator.c:373:7: error: use of undeclared identifier 'GPIOD_FLAGS_BIT_NONEXCLUSIVE'
GPIOD_FLAGS_BIT_NONEXCLUSIVE,

Include this explicitly to help compile testing.

Fixes 46c413d5bb23 ("regulator: da9121: Add support for device variants via devicetree")
---
 drivers/regulator/da9121-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/da9121-regulator.c +1 -0
index 3ead6a171d95..22630eb0b167 100644
@@ -15,6 +15,7 @@
 
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/regulator/of_regulator.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/driver.h>
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 7 lines · Arnd Bergmann

When CONFIG_GPIOLIB is disabled, the declarations from linux/gpio/consumer.h are not visible:

drivers/regulator/da9121-regulator.c:371:14: error: implicit declaration of function 'fwnode_gpiod_get_index' [-Werror,-Wimplicit-function-declaration]
ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
^
drivers/regulator/da9121-regulator.c:372:7: error: use of undeclared identifier 'GPIOD_OUT_HIGH'

Quoted 6 lines
                                                GPIOD_OUT_HIGH |
                                                ^

drivers/regulator/da9121-regulator.c:373:7: error: use of undeclared identifier 'GPIOD_FLAGS_BIT_NONEXCLUSIVE'
GPIOD_FLAGS_BIT_NONEXCLUSIVE,

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: da9121: include linux/gpio/consumer.h

      commit: b4b277760a2167ddb28a309b81363889efd5cc22

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark