Skip to contentSkip to conversation

PCI: dwc: exynos: add back MSI dependency

PATCH In review Arnd Bergmann 2 participants 3 messages Dec 4, 2020 – Dec 7, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: dwc: exynos: add back MSI dependency

From: Arnd Bergmann <[email protected]>

While the exynos driver does not always need MSI, the generic deisgnware host code it uses fails to build without it:

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y])
drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration]

        pp->msi_domain = pci_msi_create_irq_domain(fwnode,
                         ^

Add back the dependency that all other designware controllers have.

Fixes f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant")
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/Kconfig +1 -0
index 020101b58155..e403bb2eeb4c 100644
@@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
 config PCI_EXYNOS
 	tristate "Samsung Exynos PCIe controller"
 	depends on ARCH_EXYNOS || COMPILE_TEST
+	depends on PCI && PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	help
 	  Enables support for the PCIe controller in the Samsung Exynos SoCs
Signature · 1 line
2.27.0
reviewer
#1 lore raw
Quoted 14 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

While the exynos driver does not always need MSI, the generic deisgnware host code it uses fails to build without it:

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y])
drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration]

        pp->msi_domain = pci_msi_create_irq_domain(fwnode,
                         ^
Quoted 7 lines

Add back the dependency that all other designware controllers have.

Fixes f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant")
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Seems like we should rework this to avoid select on options with depends, but that's a separate change.

drivers/pci/controller/dwc/Kconfig config PCIE_DW_PLAT_EP · line 88

Quoted 9 lines
drivers/pci/controller/dwc/Kconfig +1 -0
index 020101b58155..e403bb2eeb4c 100644
@@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
 config PCI_EXYNOS
        tristate "Samsung Exynos PCIe controller"
        depends on ARCH_EXYNOS || COMPILE_TEST
+       depends on PCI && PCI_MSI_IRQ_DOMAIN

PCI isn't needed here.

Quoted 6 lines
drivers/pci/controller/dwc/Kconfig +0 -1
        select PCIE_DW_HOST
        help
          Enables support for the PCIe controller in the Samsung Exynos SoCs
--

2.27.0

#2 lore raw
Quoted 12 lines · Rob Herring

drivers/pci/controller/dwc/Kconfig config PCIE_DW_PLAT_EP · line 88

Quoted 9 lines · Arnd Bergmann
drivers/pci/controller/dwc/Kconfig +1 -0
index 020101b58155..e403bb2eeb4c 100644
@@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
 config PCI_EXYNOS
        tristate "Samsung Exynos PCIe controller"
        depends on ARCH_EXYNOS || COMPILE_TEST
+       depends on PCI && PCI_MSI_IRQ_DOMAIN

PCI isn't needed here.

Ah right. I had copied this from PCIE_DW_PLAT_HOST, and I'm fairly sure it used to be needed at some point in the past, but the Kconfig file has been changed enough over time that it clearly is not needed any more, as the entire menu depends on PCI nowadays, i.e. you can no longer have an endpoint-only configuration.

Arnd