Skip to contentSkip to conversation

phy: mediatek: statify mtk_hdmi_phy_driver

PATCH In review Vinod Koul 2 participants 2 messages Dec 5, 2020

Subsystems (4)
lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH 1/1 phy: mediatek: statify mtk_hdmi_phy_driver

mtk_hdmi_phy_driver is not declared as static, so statify it.

drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 'mtk_hdmi_phy_driver' was not declared. Should it be static?

---
 drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/mediatek/phy-mtk-hdmi.c +1 -1
index 47c029d4b270..c5c61f5a9ea0 100644
@@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
 	{},
 };
 
-struct platform_driver mtk_hdmi_phy_driver = {
+static struct platform_driver mtk_hdmi_phy_driver = {
 	.probe = mtk_hdmi_phy_probe,
 	.driver = {
 		.name = "mediatek-hdmi-phy",
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Acked-by on v1 1/1
#1 lore raw

Hi, Vinod:

Vinod Koul <[email protected]> 於 2020年12月5日 週六 下午5:11寫道:

Quoted 5 lines

mtk_hdmi_phy_driver is not declared as static, so statify it.

drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 'mtk_hdmi_phy_driver' was not declared. Should it be static?

Quoted 19 lines
---
 drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/mediatek/phy-mtk-hdmi.c +1 -2
index 47c029d4b270..c5c61f5a9ea0 100644
@@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
        {},
 };
 
-struct platform_driver mtk_hdmi_phy_driver = {
+static struct platform_driver mtk_hdmi_phy_driver = {
        .probe = mtk_hdmi_phy_probe,
        .driver = {
                .name = "mediatek-hdmi-phy",
--
Quoted 2 lines

2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel