rtc: fix RTC removal
Alexandre Belloni
maintainerPATCH 1/1 rtc: fix RTC removal
Since the rtc_register_device, removing an RTC device will end with arefcount_t: underflow; use-after-free warning since put_device is called twice in the device tear down path.
Fixes fdcfd854333b ("rtc: rework rtc_register_device() resource management")
Signed-off-by Alexandre Belloni <[email protected]>
--- drivers/rtc/class.c | 1 - 1 file changed, 1 deletion(-)
drivers/rtc/class.c +0 -1
@@ -335,7 +335,6 @@ static void devm_rtc_unregister_device(void *data)cdev_device_del (&rtc->char_dev, &rtc->dev); rtc->ops =NULL ;mutex_unlock (&rtc->ops_lock); -put_device (&rtc->dev); }static void devm_rtc_release_device (void *res)
Signature · 1 line
2.28.0
Quoted 24 lines · Alexandre Belloni
Since the
rtc_register_device, removing an RTC device will end with arefcount_t: underflow; use-after-free warning sinceput_deviceis called twice in the device tear down path.Fixes fdcfd854333b ("rtc: rework rtc_register_device() resource management")Signed-off-by Alexandre Belloni <[email protected]>--- drivers/rtc/class.c | 1 - 1 file changed, 1 deletion(-)drivers/rtc/class.c +0
-2@@ -335,7 +335,6 @@ static void devm_rtc_unregister_device(void *data)cdev_device_del (&rtc->char_dev, &rtc->dev); rtc->ops =NULL ;mutex_unlock (&rtc->ops_lock); -put_device (&rtc->dev); }static void devm_rtc_release_device (void *res) --
Quoted 2 lines
2.28.0
Eek! Thanks for fixing that.
Reviewed-by Bartosz Golaszewski <[email protected]>