package/quickjs: bump to version 2020-11-08
PATCH 1/2 package/quickjs: bump to version 2020-11-08
--- package/quickjs/quickjs.hash | 2 +- package/quickjs/quickjs.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/quickjs/quickjs.hash +1 -1
@@ -1,2 +1,2 @@ # Locally calculated -sha256 0021a3e8cdc6b61e225411d05e2841d2437e1ccf4b4cabb9a5f7685ebfb57717 quickjs-2020-09-06.tar.xz +sha256 2e9d63dab390a95ed365238f21d8e9069187f7ed195782027f0ab311bb64187b quickjs-2020-11-08.tar.xz
package/quickjs/quickjs.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -QUICKJS_VERSION = 2020-09-06 +QUICKJS_VERSION = 2020-11-08 QUICKJS_SOURCE = quickjs-$(QUICKJS_VERSION).tar.xz QUICKJS_SITE = https://bellard.org/quickjs QUICKJS_LICENSE = MIT
Signature · 1 line
2.27.0
PATCH 2/2 package/quickjs: depends on glibc
fix build http://autobuild.buildroot.org/results/d45/d456eefffd138a714e367f9520adb662f5e0f57e/
missing include <stdatomic.h>
--- package/quickjs/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
package/quickjs/Config.in +3 -3
@@ -2,7 +2,7 @@ config BR2_PACKAGE_QUICKJS bool "quickjs" depends on !BR2_STATIC_LIBS # No way to check for fenv support. - depends on !BR2_TOOLCHAIN_USES_UCLIBC + depends on BR2_TOOLCHAIN_USES_GLIBC depends on BR2_USE_MMU # fork() help QuickJS is a small and embeddable Javascript engine.
@@ -11,6 +11,6 @@ config BR2_PACKAGE_QUICKJS https://bellard.org/quickjs/ -comment "quickjs needs a glibc or musl toolchain w/ dynamic library" +comment "quickjs needs a glibc toolchain w/ dynamic library" depends on BR2_USE_MMU - depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_USES_GLIBC
Signature · 1 line
2.27.0
PATCH 2/2 package/quickjs: depends on glibc
Quoted 1 line · On Sat, 5 Dec 2020 07:44:42 +0100 Francois Perrad <[email protected]> wrote:
fix build http://autobuild.buildroot.org/results/d45/d456eefffd138a714e367f9520adb662f5e0f57e/
Well, this configuration *is* using glibc, so clearly the patch you're proposing cannot fix this build failure.
stdatomic.h is provided by gcc, not by the C library, so a C library option change most likely cannot be the proper solution.
We already have several atomic-related options in toolchain/Config.in, but I'm not sure any of them is correct to express the need for <stdatomic.h>. In fact, I'm not quite sure in which circumstances is this header not provided by gcc.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 2/2 package/quickjs: depends on glibc
Hello Francois, Thomas,
Quoted 8 lines · Thomas Petazzoni
Quoted 1 line · On Sat, 5 Dec 2020 07:44:42 +0100 Francois Perrad <[email protected]> wrote:
fix build http://autobuild.buildroot.org/results/d45/d456eefffd138a714e367f9520adb662f5e0f57e/
Well, this configuration *is* using glibc, so clearly the patch you're proposing cannot fix this build failure.
Quoted 7 lines
stdatomic.his provided by gcc, not by the C library, so a C library option change most likely cannot be the proper solution.We already have several atomic-related options in toolchain/Config.in, but I'm not sure any of them is correct to express the need for <
stdatomic.h>. In fact, I'm not quite sure in which circumstances is this header not provided by gcc.
According to [1] stdatomic.h is a ISO C11 feature, and despite the gcc info supporting '-std=c11' since gcc-4.7 [2] the release notes from gcc-4.9 [3] make mention of stdatomic.h:
ISO C11 atomics (the _Atomic type specifier and qualifier and the <stdatomic.h> header) are now supported.
So a
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
should do the job...
Regards,
Peter
[1] https://en.wikipedia.org/wiki/C11_(C_standard_revision)
[2] https://gcc.gnu.org/wiki/C11Status
[3] https://gcc.gnu.org/gcc-4.9/changes.html
Quoted 2 lines
Thomas
Thomas Petazzoni
AppliedPATCH 1/2 package/quickjs: bump to version 2020-11-08
In reply to Francois PerradQuoted 5 lines · On Sat, 5 Dec 2020 07:44:41 +0100 Francois Perrad <[email protected]> wrote:
Signed-off-by Francois Perrad <[email protected]>--- package/quickjs/quickjs.hash | 2 +- package/quickjs/quickjs.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com