Skip to contentSkip to conversation

generic/506: require prjquota

PATCH In review Murphy Zhou 2 participants 3 messages Dec 2, 2020 – Dec 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/506: require prjquota

To avoid false failure on overlayfs.

---
 tests/generic/506 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/506 +1 -0
index d5b28cad..edcda6db 100755
@@ -42,6 +42,7 @@ rm -f $seqres.full
 # real QA test starts here
 _supported_fs generic
 
+_require_prjquota
 _require_scratch
 _require_scratch_shutdown
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 12 lines · Murphy Zhou

To avoid false failure on overlayfs.

---
 tests/generic/506 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/506 +0 -0
index d5b28cad..edcda6db 100755

tests/generic/506 rm -f $seqres.full · line 47

Quoted 6 lines
tests/generic/506 +1 -0
@@ -42,6 +42,7 @@ rm -f $seqres.full
 # real QA test starts here
 _supported_fs generic
 
+_require_prjquota
 _require_scratch
 _require_scratch_shutdown

generic/506 already has _require_prjquota below, and it requires the device to be mounted first.

_qmount_option "prjquota"
_qmount
_require_prjquota $SCRATCH_DEV

So would you please give more details on the failure you want to fix?

Thanks,
Eryu

Quoted 3 lines
Signature · 2 lines
-- 
2.20.1
#2 lore raw
Quoted 23 lines · Eryu Guan
Quoted 12 lines · Murphy Zhou

To avoid false failure on overlayfs.

---
 tests/generic/506 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/506 +0 -0
index d5b28cad..edcda6db 100755

tests/generic/506 rm -f $seqres.full · line 47

Quoted 6 lines
tests/generic/506 +1 -0
@@ -42,6 +42,7 @@ rm -f $seqres.full
 # real QA test starts here
 _supported_fs generic
 
+_require_prjquota
 _require_scratch
 _require_scratch_shutdown

generic/506 already has _require_prjquota below, and it requires the device to be mounted first.

Quoted 5 lines

_qmount_option "prjquota"
_qmount
_require_prjquota $SCRATCH_DEV

So would you please give more details on the failure you want to fix?

qmount failed on overlayfs.

-Silence is golden
+mount: /loopsch/ovl-mnt: wrong fs type, bad option, bad superblock on /loopsch, missing codepage or helper program, or other error. +qmount failed>

Since it's required to be mounted before checking, I guess it's better to exclue this one for overlayfs.

Thanks for reviewing!

Quoted 6 lines

Thanks,
Eryu

Quoted 3 lines
Signature · 2 lines
-- 
2.20.1
Signature · 1 line
Murphy