Skip to contentSkip to conversation

python3-salttesting: use SRCREV instead of tag

PATCH In review Chen Qi 2 participants 2 messages Dec 7, 2020 – Dec 8, 2020

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 python3-salttesting: use SRCREV instead of tag

If we enable BB_NO_NETWORK, using tag in SRC_URI causes problem. Merely parsing the recipes will raise error. For example, `bitbake -p'.

So use SRCREV instead of tag to solve this problem.

---
 .../recipes-devtools/python/python3-salttesting_git.bb         | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-openstack/recipes-devtools/python/python3-salttesting_git.bb +2 -1
index 34476219..fdc0341a 100644
@@ -4,10 +4,11 @@ SECTION = "devel/python"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=f36f1e9e3e30f90180efdf7e40d943e5"
 
-SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop;tag=v2018.9.21 \
+SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop \
            file://0001-Add-ptest-output-option-to-test-suite.patch \
            "
 
+SRCREV = "8d21627a4eef316d22cc424deeca16a0ec8472e9"
 PV = "2018.9.21+git${SRCPV}"
 
 S = "${WORKDIR}/git"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Chen Qi

If we enable BB_NO_NETWORK, using tag in SRC_URI causes problem. Merely parsing the recipes will raise error. For example, `bitbake -p'.

I'm surprised we only noticed this now!

Thanks for the fix, it has been merged.

Bruce

Quoted 30 lines

So use SRCREV instead of tag to solve this problem.

---
 .../recipes-devtools/python/python3-salttesting_git.bb         | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-openstack/recipes-devtools/python/python3-salttesting_git.bb +2 -2
index 34476219..fdc0341a 100644
@@ -4,10 +4,11 @@ SECTION = "devel/python"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=f36f1e9e3e30f90180efdf7e40d943e5"
 
-SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop;tag=v2018.9.21 \
+SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop \
            file://0001-Add-ptest-output-option-to-test-suite.patch \
            "
 
+SRCREV = "8d21627a4eef316d22cc424deeca16a0ec8472e9"
 PV = "2018.9.21+git${SRCPV}"
 
 S = "${WORKDIR}/git"
--

2.17.1

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II