Skip to contentSkip to conversation

drm/amdgpu: fix sdma instance fw version and feature version init

PATCH In review Stanley.Yang 3 participants 3 messages Dec 7, 2020 – Dec 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: fix sdma instance fw version and feature version init

each sdma instance fw_version and feature_version
should be set right value when asic type isn't
between SIENNA_CICHILD and CHIP_DIMGREY_CAVEFISH

Change-Id I1edbf3e0557d771eb4c0b686fa5299a3b5f26e35
---
 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +1 -1
index cb5a6f1437f8..3fca9fc20dc4 100644
@@ -197,7 +197,7 @@ static int sdma_v5_2_init_microcode(struct amdgpu_device *adev)
 			if (err)
 				goto out;
 
-			err = sdma_v5_2_init_inst_ctx(&adev->sdma.instance[0]);
+			err = sdma_v5_2_init_inst_ctx(&adev->sdma.instance[i]);
 			if (err)
 				goto out;
 		}
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Stanley.Yang

each sdma instance fw_version and feature_version
should be set right value when asic type isn't
between SIENNA_CICHILD and CHIP_DIMGREY_CAVEFISH

Change-Id I1edbf3e0557d771eb4c0b686fa5299a3b5f26e35
Quoted 20 lines
---
 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +1 -2
index cb5a6f1437f8..3fca9fc20dc4 100644
@@ -197,7 +197,7 @@ static int sdma_v5_2_init_microcode(struct amdgpu_device *adev)
                        if (err)
                                goto out;
 
-                       err = sdma_v5_2_init_inst_ctx(&adev->sdma.instance[0]);
+                       err = sdma_v5_2_init_inst_ctx(&adev->sdma.instance[i]);
                        if (err)
                                goto out;
                }
--

2.17.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Stanley.Yang

[AMD Public Use]

Quoted 38 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Stanley.Yang
Sent: Monday, December 7, 2020 2:47 PM
To: [email protected]
Cc: Yang, Stanley <[email protected]>
Subject: [PATCH 1/1] drm/amdgpu: fix sdma instance fw version and feature version init

each sdma instance fw_version and feature_version should be set right value when asic type isn't between SIENNA_CICHILD and CHIP_DIMGREY_CAVEFISH

Change-Id I1edbf3e0557d771eb4c0b686fa5299a3b5f26e35
---
 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +1 -1
index cb5a6f1437f8..3fca9fc20dc4 100644
@@ -197,7 +197,7 @@ static int sdma_v5_2_init_microcode(struct
 amdgpu_device *adev)
 			if (err)
 				goto out;
 
-			err = sdma_v5_2_init_inst_ctx(&adev-
 >sdma.instance[0]);
+			err = sdma_v5_2_init_inst_ctx(&adev-
 >sdma.instance[i]);
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +0 -1
 			if (err)
 				goto out;
 		}
--

2.17.1

Quoted 10 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
edesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=04%7C01%7Ctao.zhou1%40amd.com%7Cdfd4ec3683174b0e511 f08d89a7bf287%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63742 9204427689208%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=bYQ1Gqd lrYjqRwHNnfbMxUbaOt37VIKsbdeGDWcn494%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx