Skip to contentSkip to conversation

net: tipc: prevent possible null deref of link

PATCH Applied Cengiz Can 2 participants 2 messages Dec 7, 2020 – Dec 8, 2020

Subsystems (3)
lore
Share & tools
lore

Cengiz Can

author
#0 lore raw

PATCH 1/1 net: tipc: prevent possible null deref of link

tipc_node_apply_property does a null check on a tipc_link_entry pointer but also accesses the same pointer out of the null check block.

This triggers a warning on Coverity Static Analyzer because we're implying that e->link can BE null.

Move "Update MTU for node link entry" line into if block to make sure that we're not in a state that e->link is null.

---
 net/tipc/node.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
net/tipc/node.c +4 -2
index c95d037fde51..83978d5dae59 100644
@@ -2181,9 +2181,11 @@ void tipc_node_apply_property(struct net *net, struct tipc_bearer *b,
 							&xmitq);
 			else if (prop == TIPC_NLA_PROP_MTU)
 				tipc_link_set_mtu(e->link, b->mtu);
+
+			/* Update MTU for node link entry */
+			e->mtu = tipc_link_mss(e->link);
 		}
-		/* Update MTU for node link entry */
-		e->mtu = tipc_link_mss(e->link);
+
 		tipc_node_write_unlock(n);
 		tipc_bearer_xmit(net, bearer_id, &xmitq, &e->maddr, NULL);
 	}
Signature · 1 line
2.29.2
maintainer Applied
#1 lore raw

From: Cengiz Can <[email protected]>
Date: Mon, 7 Dec 2020 11:14:24 +0300

Quoted 11 lines

tipc_node_apply_property does a null check on a tipc_link_entry pointer but also accesses the same pointer out of the null check block.

This triggers a warning on Coverity Static Analyzer because we're implying that e->link can BE null.

Move "Update MTU for node link entry" line into if block to make sure that we're not in a state that e->link is null.

---

Applied, thanks.,