nvme-fcloop: Fix sscanf type and list_first_entry_or_null warnings
Subsystems (3)
PATCH 1/1 nvme-fcloop: Fix sscanf type and list_first_entry_or_null warnings
Kernel robot had the following warnings:
Quoted 5 lines
Quoted 5 lines
fcloop.c:1506:6: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [
invalidScanfArgType_int]
if (sscanf(buf, "%x:%d:%d", &opcode, &starting, &amount)!= 3)^
Resolve by changing opcode from and int to an unsigned int
and
Quoted 7 lines
Quoted 7 lines
fcloop.c:1632:32: warning: Uninitialized variable: lport [uninitvar]
ret = __wait_localport_unreg(lport); ^fcloop.c:1615:28: warning: Uninitialized variable: nport [uninitvar]
ret = __remoteport_unreg(nport, rport); ^
These aren't actual issues as the values are assigned prior to use. It appears the tool doesn't understand list_first_entry_or_null(). Regardless, quiet the tool by initializing the pointers to NULL at declaration.
--- drivers/nvme/target/fcloop.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/nvme/target/fcloop.c +4 -3
@@ -1501,7 +1501,8 @@ static ssize_t fcloop_set_cmd_drop(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - int opcode, starting, amount; + unsigned int opcode; +int starting, amount;if (sscanf (buf,"%x:%d:%d" , &opcode, &starting, &amount) !=3 )return -EBADRQC ;
@@ -1588,8 +1589,8 @@ static int __init fcloop_init(void) static void __exit fcloop_exit(void) { -struct fcloop_lport *lport; -struct fcloop_nport *nport; +struct fcloop_lport *lport =NULL ; +struct fcloop_nport *nport =NULL ;struct fcloop_tport *tport;struct fcloop_rport *rport;unsigned long flags;
Signature · 15 lines
2.26.2 -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
AppliedThanks,
applied to nvme-5.11.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme