Skip to contentSkip to conversation

dt-bindings: Correct GV11B GPU register sizes

PATCH Applied Jon Hunter 4 participants 5 messages Nov 24, 2020 – Dec 10, 2020

Subsystems (3)
lore
Share & tools
lore

Jon Hunter

author
#0 lore raw

PATCH 1/1 dt-bindings: Correct GV11B GPU register sizes

Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU") added the GV11B GPU device-tree bindings information but incorrectly added an additional 0 to the size of the addresses in the example.

Fixes 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
---
 Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt +2 -2
index 662a3c8a7d29..cc6ce5221a38 100644
@@ -97,8 +97,8 @@ Example for GV11B:
 
 	gpu@17000000 {
 		compatible = "nvidia,gv11b";
-		reg = <0x17000000 0x10000000>,
-		      <0x18000000 0x10000000>;
+		reg = <0x17000000 0x1000000>,
+		      <0x18000000 0x1000000>;
 		interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "stall", "nonstall";
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Jon Hunter

Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU") added the GV11B GPU device-tree bindings information but incorrectly added an additional 0 to the size of the addresses in the example.

Fixes 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
---
 Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
maintainer Applied
#2 lore raw
In reply to Jon Hunter
Quoted 10 lines · Jon Hunter

Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU") added the GV11B GPU device-tree bindings information but incorrectly added an additional 0 to the size of the addresses in the example.

Fixes 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
---
 Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!

But really, it's just an example and rather than fix trivial things in txt bindings, convert them to schema please.

#3 lore raw
Quoted 12 lines · Rob Herring
Quoted 10 lines · Jon Hunter

Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU") added the GV11B GPU device-tree bindings information but incorrectly added an additional 0 to the size of the addresses in the example.

Fixes 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
---
 Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 4 lines

Applied, thanks!

But really, it's just an example and rather than fix trivial things in txt bindings, convert them to schema please.

The conversion to schema of this binding was part of a series I sent out earlier this year converting a bunch of Tegra-related bindings. At the time you had requested that rather than converting one binding after another it might be easier to review if whole directories were converted at a time.

I've been struggling to find time to do so, so I wonder if you'd prefer me to send out that series again, or perhaps in smaller chunks? That sounds better than not doing any conversions at all because I lack the time to do whole directories at once.

Thierry

maintainer
#4 lore raw
Quoted 16 lines · Thierry Reding
Quoted 14 lines · Rob Herring
Quoted 10 lines · Jon Hunter

Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU") added the GV11B GPU device-tree bindings information but incorrectly added an additional 0 to the size of the addresses in the example.

Fixes 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
---
 Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!

Quoted 8 lines
Quoted 2 lines

But really, it's just an example and rather than fix trivial things in txt bindings, convert them to schema please.

The conversion to schema of this binding was part of a series I sent out earlier this year converting a bunch of Tegra-related bindings. At the time you had requested that rather than converting one binding after another it might be easier to review if whole directories were converted at a time.

That's largely just because the issues tend to be the same (both doing the conversion and reviewing it).

Quoted 4 lines

I've been struggling to find time to do so, so I wonder if you'd prefer me to send out that series again, or perhaps in smaller chunks? That sounds better than not doing any conversions at all because I lack the time to do whole directories at once.

The whole series is fine.

Rob