Skip to contentSkip to conversation

virtiofsd: update FUSE_FORGET comment on "lo_inode.nlookup"

PATCH In review Laszlo Ersek 3 participants 3 messages Dec 8, 2020 – Dec 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtiofsd: update FUSE_FORGET comment on "lo_inode.nlookup"

Miklos confirms it's *only* the FUSE_FORGET request that the client can use for decrementing "lo_inode.nlookup".

Cc "Dr. David Alan Gilbert" <[email protected]>
Cc Miklos Szeredi <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Fixes 1222f015558fc34cea02aa3a5a92de608c82cec8
---
 tools/virtiofsd/passthrough_ll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/virtiofsd/passthrough_ll.c +1 -1
index 06543b20dcbb..d3be680e92c3 100644
@@ -113,7 +113,7 @@ struct lo_inode {
      * This counter keeps the inode alive during the FUSE session.
      * Incremented when the FUSE inode number is sent in a reply
      * (FUSE_LOOKUP, FUSE_READDIRPLUS, etc).  Decremented when an inode is
-     * released by requests like FUSE_FORGET, FUSE_RMDIR, FUSE_RENAME, etc.
+     * released by a FUSE_FORGET request.
      *
      * Note that this value is untrusted because the client can manipulate
      * it arbitrarily using FUSE_FORGET requests.
Signature · 1 line
2.19.1.3.g30247aa5d201
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Laszlo Ersek

Miklos confirms it's *only* the FUSE_FORGET request that the client can use for decrementing "lo_inode.nlookup".

Cc "Dr. David Alan Gilbert" <[email protected]>
Cc Miklos Szeredi <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Fixes 1222f015558fc34cea02aa3a5a92de608c82cec8

Looks correct. unref_inode() calls in lo_rmdir() lo_rename() are dropping ->nlookup they have taken internally during the function execution.

Thanks
Vivek

Quoted 24 lines
---
 tools/virtiofsd/passthrough_ll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/virtiofsd/passthrough_ll.c +1 -1
index 06543b20dcbb..d3be680e92c3 100644
@@ -113,7 +113,7 @@ struct lo_inode {
      * This counter keeps the inode alive during the FUSE session.
      * Incremented when the FUSE inode number is sent in a reply
      * (FUSE_LOOKUP, FUSE_READDIRPLUS, etc).  Decremented when an inode is
-     * released by requests like FUSE_FORGET, FUSE_RMDIR, FUSE_RENAME, etc.
+     * released by a FUSE_FORGET request.
      *
      * Note that this value is untrusted because the client can manipulate
      * it arbitrarily using FUSE_FORGET requests.
Signature · 6 lines
2.19.1.3.g30247aa5d201

_______________________________________________
Virtio-fs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virtio-fs
#2 lore raw
Quoted 10 lines · * Vivek Goyal ([email protected]) wrote:
Quoted 8 lines · Laszlo Ersek

Miklos confirms it's *only* the FUSE_FORGET request that the client can use for decrementing "lo_inode.nlookup".

Cc "Dr. David Alan Gilbert" <[email protected]>
Cc Miklos Szeredi <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Fixes 1222f015558fc34cea02aa3a5a92de608c82cec8
Quoted 4 lines

Looks correct. unref_inode() calls in lo_rmdir() lo_rename() are dropping ->nlookup they have taken internally during the function execution.

Queued.

Quoted 33 lines

Thanks
Vivek

Quoted 24 lines
---
 tools/virtiofsd/passthrough_ll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/virtiofsd/passthrough_ll.c +1 -1
index 06543b20dcbb..d3be680e92c3 100644
@@ -113,7 +113,7 @@ struct lo_inode {
      * This counter keeps the inode alive during the FUSE session.
      * Incremented when the FUSE inode number is sent in a reply
      * (FUSE_LOOKUP, FUSE_READDIRPLUS, etc).  Decremented when an inode is
-     * released by requests like FUSE_FORGET, FUSE_RMDIR, FUSE_RENAME, etc.
+     * released by a FUSE_FORGET request.
      *
      * Note that this value is untrusted because the client can manipulate
      * it arbitrarily using FUSE_FORGET requests.
Signature · 6 lines
2.19.1.3.g30247aa5d201

_______________________________________________
Virtio-fs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virtio-fs

_______________________________________________
Virtio-fs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virtio-fs

Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK