Skip to contentSkip to conversation

apparmor: Remove duplicate macro list_entry_is_head()

PATCH Applied Andy Shevchenko 2 participants 2 messages Dec 8, 2020 – Dec 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 apparmor: Remove duplicate macro list_entry_is_head()

Strangely I hadn't had noticed the existence of the list_entry_is_head() in apparmor code when added the same one in the list.h. Luckily it's fully identical and didn't break builds. In any case we don't need a duplicate anymore, thus remove it from apparmor code.

---
 security/apparmor/apparmorfs.c | 3 ---
 1 file changed, 3 deletions(-)
security/apparmor/apparmorfs.c +0 -3
index 5fd4a64e431f..f95c6bfa8b8e 100644
@@ -2046,9 +2046,6 @@ int __aafs_ns_mkdir(struct aa_ns *ns, struct dentry *parent, const char *name,
 	return error;
 }
 
-
-#define list_entry_is_head(pos, head, member) (&pos->member == (head))
-
 /**
  * __next_ns - find the next namespace to list
  * @root: root namespace to stop search at (NOT NULL)
Signature · 1 line
2.29.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andy Shevchenko

Strangely I hadn't had noticed the existence of the list_entry_is_head() in apparmor code when added the same one in the list.h. Luckily it's fully identical and didn't break builds. In any case we don't need a duplicate anymore, thus remove it from apparmor code.

oh nice,

I will pull into the apparmor tree

Quoted 19 lines
---
 security/apparmor/apparmorfs.c | 3 ---
 1 file changed, 3 deletions(-)
security/apparmor/apparmorfs.c +0 -3
index 5fd4a64e431f..f95c6bfa8b8e 100644
@@ -2046,9 +2046,6 @@ int __aafs_ns_mkdir(struct aa_ns *ns, struct dentry *parent, const char *name,
 	return error;
 }
 
-
-#define list_entry_is_head(pos, head, member) (&pos->member == (head))
-
 /**
  * __next_ns - find the next namespace to list
  * @root: root namespace to stop search at (NOT NULL)