Skip to contentSkip to conversation

clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

PATCH In review [email protected] 2 participants 3 messages Dec 8, 2020 – Dec 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

From: Quanyang Wang <[email protected]>

The Zynqmp Ultrascale clock controller generates clocks for peripherals, so we need to enable it when ARCH_ZYNQMP is selected.

---
 drivers/clk/zynqmp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/zynqmp/Kconfig +1 -0
index 17086059be8b..a8aa58bbb790 100644
@@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
 	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
 	depends on ARCH_ZYNQMP || COMPILE_TEST
 	depends on ZYNQMP_FIRMWARE
+	default ARCH_ZYNQMP
 	help
 	  Support for the Zynqmp Ultrascale clock controller.
 	  It has a dependency on the PMU firmware.
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 15 lines · On 08. 12. 20 13:35, [email protected] wrote:

From: Quanyang Wang <[email protected]>

The Zynqmp Ultrascale clock controller generates clocks for peripherals, so we need to enable it when ARCH_ZYNQMP is selected.

---
 drivers/clk/zynqmp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/zynqmp/Kconfig +0 -0
index 17086059be8b..a8aa58bbb790 100644

drivers/clk/zynqmp/Kconfig config COMMON_CLK_ZYNQMP · line 7

Quoted 4 lines
drivers/clk/zynqmp/Kconfig +1 -0
@@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
 	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
 	depends on ARCH_ZYNQMP || COMPILE_TEST
 	depends on ZYNQMP_FIRMWARE
+	default ARCH_ZYNQMP

This is not right. If you look 2 lines above.

drivers/clk/zynqmp/Kconfig config COMMON_CLK_ZYNQMP · line 10

Quoted 4 lines
drivers/clk/zynqmp/Kconfig +0 -0
 	help
 	  Support for the Zynqmp Ultrascale clock controller.
 	  It has a dependency on the PMU firmware.

And we were talking about enabling this driver in defconfig. Not via Kconfig. This fragment was designed in a way that this clock controller doesn't need to be used. It is our default but if you want to use for example fixed clock you also can.
This enables space for being able to use for example different firmware.

Thanks,
Michal

#2 lore raw

Hi Michal,

Quoted 28 lines · Michal Simek

Hi,

Quoted 15 lines · On 08. 12. 20 13:35, [email protected] wrote:

From: Quanyang Wang <[email protected]>

The Zynqmp Ultrascale clock controller generates clocks for peripherals, so we need to enable it when ARCH_ZYNQMP is selected.

---
  drivers/clk/zynqmp/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/clk/zynqmp/Kconfig +0 -0
index 17086059be8b..a8aa58bbb790 100644

drivers/clk/zynqmp/Kconfig config COMMON_CLK_ZYNQMP · line 7

Quoted 4 lines
drivers/clk/zynqmp/Kconfig +1 -0
@@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
  	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
  	depends on ARCH_ZYNQMP || COMPILE_TEST
  	depends on ZYNQMP_FIRMWARE
+	default ARCH_ZYNQMP

This is not right. If you look 2 lines above.

drivers/clk/zynqmp/Kconfig config COMMON_CLK_ZYNQMP · line 10

Quoted 4 lines
drivers/clk/zynqmp/Kconfig +0 -0
  	help
  	  Support for the Zynqmp Ultrascale clock controller.
  	  It has a dependency on the PMU firmware.
Quoted 5 lines

And we were talking about enabling this driver in defconfig. Not via Kconfig. This fragment was designed in a way that this clock controller doesn't need to be used. It is our default but if you want to use for example fixed clock you also can.
This enables space for being able to use for example different firmware.

Thanks for your reply. I will enable this driver in defconfig.

Best Regards

Quanyang

Quoted 3 lines

Thanks,
Michal