Skip to contentSkip to conversation

quota: Fix error handling path of dquot_resume()

PATCH New Jan Kara 1 participant 1 message Dec 8, 2020

Subsystems (3)
lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH 1/1 quota: Fix error handling path of dquot_resume()

When reloading of quota failed we tried to cleanup using vfs_cleanup_quota_inode() however we passed wrong 'type' argument. Fix that.

Fixes ae45f07d47cc ("quota: Simplify dquot_resume()")
Reported-by [email protected]
---
 fs/quota/dquot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I plan to queue this patch to my tree for the merge window.

Honza

fs/quota/dquot.c +1 -1
index bb02989d92b6..4f1373463766 100644
@@ -2455,7 +2455,7 @@ int dquot_resume(struct super_block *sb, int type)
 		ret = dquot_load_quota_sb(sb, cnt, dqopt->info[cnt].dqi_fmt_id,
 					  flags);
 		if (ret < 0)
-			vfs_cleanup_quota_inode(sb, type);
+			vfs_cleanup_quota_inode(sb, cnt);
 	}
 
 	return ret;
Signature · 1 line
2.16.4