Skip to contentSkip to conversation

gstreamer1.0-plugins-bad: v4l2codecs fix typo

PATCH In review Jose Quaresma 2 participants 11 messages Dec 8, 2020 – Dec 17, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/8 gstreamer1.0-plugins-bad: v4l2codecs fix typo

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +1 -1
index f70437ccd3..f2b8a21abc 100644
@@ -72,6 +72,7 @@ PACKAGECONFIG[srtp]            = "-Dsrtp=enabled,-Dsrtp=disabled,libsrtp"
 PACKAGECONFIG[tinyalsa]        = "-Dtinyalsa=enabled,-Dtinyalsa=disabled,tinyalsa"
 PACKAGECONFIG[ttml]            = "-Dttml=enabled,-Dttml=disabled,libxml2 pango cairo"
 PACKAGECONFIG[uvch264]         = "-Duvch264=enabled,-Duvch264=disabled,libusb1 libgudev"
+PACKAGECONFIG[v4l2codecs]      = "-Dv4l2codecs=enabled,-Dv4l2codecs=disabled,libgudev"
 PACKAGECONFIG[va]              = "-Dva=enabled,-Dva=disabled,libva"
 PACKAGECONFIG[voaacenc]        = "-Dvoaacenc=enabled,-Dvoaacenc=disabled,vo-aacenc"
 PACKAGECONFIG[voamrwbenc]      = "-Dvoamrwbenc=enabled,-Dvoamrwbenc=disabled,vo-amrwbenc"
@@ -81,7 +82,6 @@ PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
 PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"
 PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrtc-audio-processing"
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
-PACKAGECONFIG[v4l2codecs]      = "-D-Dv4l2codecs=enabled,-Dv4l2codecs=disabled,libgudev"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
 #   aom androidmedia applemedia bs2b chromaprint d3dvideosink
Signature · 1 line
2.29.2
#1 lore raw

PATCH v2 2/8 gstreamer1.0-plugins-bad: add support for aom plugin

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb              | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +2 -2
index f2b8a21abc..9de99f60e6 100644
@@ -27,6 +27,7 @@ PACKAGECONFIG ??= " \
     ttml uvch264 webp \
 "
 
+PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
 PACKAGECONFIG[assrender]       = "-Dassrender=enabled,-Dassrender=disabled,libass"
 PACKAGECONFIG[bluez]           = "-Dbluez=enabled,-Dbluez=disabled,bluez5"
 PACKAGECONFIG[bz2]             = "-Dbz2=enabled,-Dbz2=disabled,bzip2"
@@ -84,7 +85,7 @@ PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrt
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
-#   aom androidmedia applemedia bs2b chromaprint d3dvideosink
+#   androidmedia applemedia bs2b chromaprint d3dvideosink
 #   directsound dts fdkaac gme gsm iq kate ladspa lv2 mpeg2enc
 #   mplex musepack nvdec nvenc ofa openexr openni2 opensles
 #   soundtouch spandsp teletext wasapi wildmidi winks
@@ -98,7 +99,6 @@ EXTRA_OEMESON += " \
     -Dipcpipeline=enabled \
     -Dnetsim=enabled \
     -Dshm=enabled \
-    -Daom=disabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
Signature · 1 line
2.29.2
#2 lore raw

PATCH v2 3/8 gstreamer1.0-plugins-bad: add support for x265 plugin

In reply to Jose Quaresma
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb              | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +2 -2
index 9de99f60e6..7016f73c92 100644
@@ -83,13 +83,14 @@ PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
 PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"
 PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrtc-audio-processing"
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
+PACKAGECONFIG[x265]            = "-Dx265=enabled,-Dx265=disabled,x265"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
 #   androidmedia applemedia bs2b chromaprint d3dvideosink
 #   directsound dts fdkaac gme gsm iq kate ladspa lv2 mpeg2enc
 #   mplex musepack nvdec nvenc ofa openexr openni2 opensles
 #   soundtouch spandsp teletext wasapi wildmidi winks
-#   winscreencap wpe x265
+#   winscreencap wpe
 
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
@@ -137,7 +138,6 @@ EXTRA_OEMESON += " \
     -Dwinks=disabled \
     -Dwinscreencap=disabled \
     -Dwpe=disabled \
-    -Dx265=disabled \
     -Dzxing=disabled \
 "
 
Signature · 1 line
2.29.2
#3 lore raw

PATCH v2 4/8 gstreamer1.0-plugins-bad: sctp plugin uses the internal usrsctp static lib

In reply to Jose Quaresma

usrsctp lib source code is provided in gstreamer plugins bad source tree and it is builded staticaly for the sctp plugin.

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +1 -1
index 7016f73c92..dbc9360e1c 100644
@@ -65,7 +65,7 @@ PACKAGECONFIG[resindvd]        = "-Dresindvd=enabled,-Dresindvd=disabled,libdvdr
 PACKAGECONFIG[rsvg]            = "-Drsvg=enabled,-Drsvg=disabled,librsvg"
 PACKAGECONFIG[rtmp]            = "-Drtmp=enabled,-Drtmp=disabled,rtmpdump"
 PACKAGECONFIG[sbc]             = "-Dsbc=enabled,-Dsbc=disabled,sbc"
-PACKAGECONFIG[sctp]            = "-Dsctp=enabled,-Dsctp=disabled,usrsctp"
+PACKAGECONFIG[sctp]            = "-Dsctp=enabled,-Dsctp=disabled"
 PACKAGECONFIG[smoothstreaming] = "-Dsmoothstreaming=enabled,-Dsmoothstreaming=disabled,libxml2"
 PACKAGECONFIG[sndfile]         = "-Dsndfile=enabled,-Dsndfile=disabled,libsndfile1"
 PACKAGECONFIG[srt]             = "-Dsrt=enabled,-Dsrt=disabled,srt"
Signature · 1 line
2.29.2
#4 lore raw

PATCH v2 5/8 gstreamer1.0-plugins-bad: remove unsupported plugins comment

In reply to Jose Quaresma

- all of the unsupported plugins are explicitly disabled on EXTRA_OEMESON

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb           | 7 -------
 1 file changed, 7 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +0 -7
index dbc9360e1c..adddceb799 100644
@@ -85,13 +85,6 @@ PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrt
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
 PACKAGECONFIG[x265]            = "-Dx265=enabled,-Dx265=disabled,x265"
 
-# these plugins currently have no corresponding library in OE-core or meta-openembedded:
-#   androidmedia applemedia bs2b chromaprint d3dvideosink
-#   directsound dts fdkaac gme gsm iq kate ladspa lv2 mpeg2enc
-#   mplex musepack nvdec nvenc ofa openexr openni2 opensles
-#   soundtouch spandsp teletext wasapi wildmidi winks
-#   winscreencap wpe
-
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
     -Ddecklink=enabled \
Signature · 1 line
2.29.2
#5 lore raw

PATCH v2 6/8 gstreamer1.0-plugins-bad: netsim plugin don't have external deps

In reply to Jose Quaresma
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                 | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +0 -1
index adddceb799..9c8fea1f41 100644
@@ -91,7 +91,6 @@ EXTRA_OEMESON += " \
     -Ddvb=enabled \
     -Dfbdev=enabled \
     -Dipcpipeline=enabled \
-    -Dnetsim=enabled \
     -Dshm=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
Signature · 1 line
2.29.2
#6 lore raw

PATCH v2 7/8 gstreamer1.0-plugins-bad: transcode plugin external deps is always present

In reply to Jose Quaresma

it only needs gstreamer-pbutils-1.0 from gst-plugins-base

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                 | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +1 -0
index 9c8fea1f41..d37a223254 100644
@@ -92,6 +92,7 @@ EXTRA_OEMESON += " \
     -Dfbdev=enabled \
     -Dipcpipeline=enabled \
     -Dshm=enabled \
+    -Dtranscode=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
Signature · 1 line
2.29.2
#7 lore raw

PATCH v2 8/8 gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

In reply to Jose Quaresma

decklink: libdl (glibc)
dvbk: kernel headers
fbdev: kernel headers
ipcpipeline: gst-plugins-base
shm: librt (glibc)
transcode: gst-plugins-base

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb            | 6 ------
 1 file changed, 6 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +0 -6
index d37a223254..a43261b704 100644
@@ -87,12 +87,6 @@ PACKAGECONFIG[x265]            = "-Dx265=enabled,-Dx265=disabled,x265"
 
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
-    -Ddecklink=enabled \
-    -Ddvb=enabled \
-    -Dfbdev=enabled \
-    -Dipcpipeline=enabled \
-    -Dshm=enabled \
-    -Dtranscode=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
Signature · 1 line
2.29.2

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

Re: [OE-core] [PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

Hi Richard,

I have think about this patch and probably is better to drop it. It is now on master-next

Without this we have meson options for all the gstreamer plugins that have external dependencies.

Probably its better to have it explicity enabled than don't have this options at all and falback to meson auto discovery dependencies.

Jose

A terça, 8/12/2020, 16:13, Jose Quaresma via lists.openembedded.org <[email protected]> escreveu:

Quoted 39 lines

decklink: libdl (glibc)
dvbk: kernel headers
fbdev: kernel headers
ipcpipeline: gst-plugins-base
shm: librt (glibc)
transcode: gst-plugins-base

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb            | 6 ------
 1 file changed, 6 deletions(-)
(quoted diff) +0 -0

gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/ gstreamer1.0-plugins-bad_1.18.2.bb
index d37a223254..a43261b704 100644

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +0 -0
@@ -87,12 +87,6 @@ PACKAGECONFIG[x265]            =

"-Dx265=enabled,-Dx265=disabled,x265"

 EXTRA_OEMESON += " \
     -Ddoc=disabled \
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb +0 -7
-    -Ddecklink=enabled \
-    -Ddvb=enabled \
-    -Dfbdev=enabled \
-    -Dipcpipeline=enabled \
-    -Dshm=enabled \
-    -Dtranscode=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
--

2.29.2

#10 lore raw

Re: [OE-core] [PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

Hi Jose,

Quoted 8 lines · Jose Quaresma

I have think about this patch and probably is better to drop it. It is now on master-next

Without this we have meson options for all the gstreamer plugins that have external dependencies.

Probably its better to have it explicity enabled than don't have this options at all and falback to meson auto discovery dependencies.

FWIW, I agree. I put things in master-next to run through the autobuilder in parallel with other review so just because something makes it there, it doesn't mean its definitely going to be merged. I've dropped this one, thanks for highlighting!

Cheers,

Richard

#11 lore raw

Re: [OE-core] [PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

Hi Richard,

Thanks for overview of the merge process.

Jose

Richard Purdie <[email protected]> escreveu no dia terça, 15/12/2020 à(s) 23:02:

Quoted 22 lines

Hi Jose,

Quoted 8 lines · Jose Quaresma

I have think about this patch and probably is better to drop it. It is now on master-next

Without this we have meson options for all the gstreamer plugins that have external dependencies.

Probably its better to have it explicity enabled than don't have this options at all and falback to meson auto discovery dependencies.

FWIW, I agree. I put things in master-next to run through the autobuilder in parallel with other review so just because something makes it there, it doesn't mean its definitely going to be merged. I've dropped this one, thanks for highlighting!

Cheers,

Richard

Signature · 2 lines
best regards,
José Quaresma