drm/amdkfd: Fix leak in dmabuf import
Subsystems (3)
Felix Kuehling
maintainerPATCH 1/1 drm/amdkfd: Fix leak in dmabuf import
Release dmabuf reference before returning from kfd_ioctl_import_dmabuf. amdgpu_amdkfd_gpuvm_import_dmabuf takes a reference to the underlying GEM BO and doesn't keep the reference to the dmabuf wrapper.
--- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +2 -0
@@ -1736,6 +1736,7 @@ static int kfd_ioctl_import_dmabuf(struct file *filep, }mutex_unlock (&p->mutex); +dma_buf_put (dmabuf); args->handle =MAKE_HANDLE (args->gpu_id, idr_handle);
@@ -1745,6 +1746,7 @@ static int kfd_ioctl_import_dmabuf(struct file *filep,amdgpu_amdkfd_gpuvm_free_memory_of_gpu (dev->kgd, (struct kgd_mem *)mem,NULL ); err_unlock:mutex_unlock (&p->mutex); +dma_buf_put (dmabuf);return r; }
Signature · 6 lines
2.29.2 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Seems logical to me.
Quoted 40 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Felix Kuehling
Sent: Tuesday, December 8, 2020 12:31 PM
To: [email protected]
Subject: [PATCH 1/1] drm/amdkfd: Fix leak in dmabuf importRelease dmabuf reference before returning from
kfd_ioctl_import_dmabuf.amdgpu_amdkfd_gpuvm_import_dmabuftakes a reference to the underlying GEM BO and doesn't keep the reference to the dmabuf wrapper.Signed-off-by Felix Kuehling <[email protected]>--- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +2
-1@@ -1736,6 +1736,7 @@ static int kfd_ioctl_import_dmabuf(struct file *filep, }mutex_unlock (&p->mutex); +dma_buf_put (dmabuf); args->handle =MAKE_HANDLE (args->gpu_id, idr_handle);@@ -1745,6 +1746,7 @@ static int kfd_ioctl_import_dmabuf(struct file *filep,amdgpu_amdkfd_gpuvm_free_memory_of_gpu (dev->kgd, (struct kgd_mem *)mem,NULL ); err_unlock:mutex_unlock (&p->mutex); +dma_buf_put (dmabuf);return r; } --2.29.2
Quoted 10 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.or
g%2Fmailman%2Flistinfo%2Famd- gfx&data=04%7C01%7Ckent.russell%40amd.com%7Cce3f82630f6649b4303408d89b9f1 b2c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637430454956092554%7CUnk nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV CI6Mn0%3D%7C1000&sdata=WzPu3OlZKKBnTQKHqC7KczU5Z19%2BPhTUt2%2FdjKznM Ic%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx