Skip to contentSkip to conversation

whymb: Fix typo in variable name

PATCH Superseded Akira Yokosawa 2 participants 3 messages Dec 6, 2020 – Dec 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 whymb: Fix typo in variable name

From 93f718fcd589225aaf77c5bd804f2ecc07fb6443 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Sun, 5 Dec 2020 13:44:14 +0900
Subject: [PATCH -perfbook] whymb: Fix typo in variable name

It is the variable "b" that CPUs 1 and 2 observe.
This typo was pointed out by Motohiro in his Japanese translation [1].

[1]: https://sites.google.com/site/kandamotohiro/perfbook-d/perfbookappendixc

---
 appendix/whymb/whymemorybarriers.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
appendix/whymb/whymemorybarriers.tex +1 -1
index e6c24f6e..d139c4dd 100644
@@ -1511,7 +1511,7 @@ are both guaranteed to see all assignments by CPU~0 preceding its memory
 barrier on line~2.
 Similarly, CPU~0's memory barrier on line~8 pairs with those of CPUs~1 and 2
 on line~4, so that CPU~0 will not execute the assignment to ``e'' on
-line~9 until after its assignment to ``a'' is visible to both of the
+line~9 until after its assignment to ``b'' is visible to both of the
 other CPUs.
 Therefore, CPU~2's assertion on line~9 is guaranteed \emph{not} to fire.
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 whymb: Fix typo in variable name

From ff659ff1a4927bf0ebfbe5a28a3edc208c688e2d Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Mon, 7 Dec 2020 07:36:07 +0900
Subject: [PATCH -perfbook v2] whymb: Fix typo in variable name

It is the variable "b" that CPUs 1 and 2 observe in Listing C.3. This typo was pointed out by Motohiro in his Japanese translation [1].

[1]: https://sites.google.com/site/kandamotohiro/perfbook-d/perfbookappendixc

Also add a couple of nbsps ("CPU~1 and 2" -> "CPU~1 and~2").

---
v1 -> v2: Add a couple of nbsps

 appendix/whymb/whymemorybarriers.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
appendix/whymb/whymemorybarriers.tex +3 -3
index e6c24f6e..1dae3fc5 100644
@@ -1506,12 +1506,12 @@ All variables are initially zero.
 
 Note that neither CPU~1 nor CPU~2 can proceed to line~5 until they see
 CPU~0's assignment to ``b'' on line~3.
-Once CPU~1 and 2 have executed their memory barriers on line~4, they
+Once CPU~1 and~2 have executed their memory barriers on line~4, they
 are both guaranteed to see all assignments by CPU~0 preceding its memory
 barrier on line~2.
-Similarly, CPU~0's memory barrier on line~8 pairs with those of CPUs~1 and 2
+Similarly, CPU~0's memory barrier on line~8 pairs with those of CPUs~1 and~2
 on line~4, so that CPU~0 will not execute the assignment to ``e'' on
-line~9 until after its assignment to ``a'' is visible to both of the
+line~9 until after its assignment to ``b'' is visible to both of the
 other CPUs.
 Therefore, CPU~2's assertion on line~9 is guaranteed \emph{not} to fire.
 
Signature · 1 line
2.17.1
#2 lore raw
Quoted 8 lines · Akira Yokosawa
Quoted 1 line

From ff659ff1a4927bf0ebfbe5a28a3edc208c688e2d Mon Sep 17 00:00:00 2001

From: Akira Yokosawa <[email protected]>
Date: Mon, 7 Dec 2020 07:36:07 +0900
Subject: [PATCH -perfbook v2] whymb: Fix typo in variable name

It is the variable "b" that CPUs 1 and 2 observe in Listing C.3. This typo was pointed out by Motohiro in his Japanese translation [1].

Quoted 6 lines

[1]: https://sites.google.com/site/kandamotohiro/perfbook-d/perfbookappendixc

Also add a couple of nbsps ("CPU~1 and 2" -> "CPU~1 and~2").

Queued and pushed, thank you!

Thanx, Paul

Quoted 30 lines

---
v1 -> v2: Add a couple of nbsps

 appendix/whymb/whymemorybarriers.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
appendix/whymb/whymemorybarriers.tex +3 -3
index e6c24f6e..1dae3fc5 100644
@@ -1506,12 +1506,12 @@ All variables are initially zero.
 
 Note that neither CPU~1 nor CPU~2 can proceed to line~5 until they see
 CPU~0's assignment to ``b'' on line~3.
-Once CPU~1 and 2 have executed their memory barriers on line~4, they
+Once CPU~1 and~2 have executed their memory barriers on line~4, they
 are both guaranteed to see all assignments by CPU~0 preceding its memory
 barrier on line~2.
-Similarly, CPU~0's memory barrier on line~8 pairs with those of CPUs~1 and 2
+Similarly, CPU~0's memory barrier on line~8 pairs with those of CPUs~1 and~2
 on line~4, so that CPU~0 will not execute the assignment to ``e'' on
-line~9 until after its assignment to ``a'' is visible to both of the
+line~9 until after its assignment to ``b'' is visible to both of the
 other CPUs.
 Therefore, CPU~2's assertion on line~9 is guaranteed \emph{not} to fire.
 
Signature · 1 line
2.17.1