PCI: qcom: Fix using uninitialized smmu_sid_base variable
Subsystems (4)
PATCH 1/1 PCI: qcom: Fix using uninitialized smmu_sid_base variable
smmu_sid_base should hold the base of SMMU SID extracted from the first entry of iommu-map. This value will be used to extract the successive SMMU SID values. Fix it by assigning the first SMMU SID base before for loop.
Reported-by kernel test robot <[email protected]>
Signed-off-by Manivannan Sadhasivam <[email protected]>
--- drivers/pci/controller/dwc/pcie-qcom.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pci/controller/dwc/pcie-qcom.c +3 -0
@@ -1297,6 +1297,9 @@ static int qcom_pcie_config_sid_sm8250(struct qcom_pcie *pcie)/* Registers need to be zero out first */ memset_io (bdf_to_sid_base,0 ,CRC8_TABLE_SIZE *sizeof (u32)); +/* Extract the SMMU SID base from the first entry of iommu-map */ + smmu_sid_base = map[0 ].smmu_sid; +/* Look for an available entry to hold the mapping */ for (i =0 ; i < nr_map; i++) {u16 bdf_be =cpu_to_be16 (map[i].bdf);
Signature · 1 line
2.25.1