nfp: silence set but not used warning with IPV6=n
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 nfp: silence set but not used warning with IPV6=n
Test robot reports:
drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req':drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable]
477 | struct ipv6hdr *ipv6h;
| ^~~~~
In file included from include/linux/compiler_types.h:65,
from <command-line>:drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
208 | # define fallthrough __attribute__((__fallthrough__))
| ^~~~~~~~~~~~~
drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
299 | fallthrough;
| ^~~~~~~~~~~Use the IPv6 header in the switch, it doesn't matter which header we use to read the version field.
--- drivers/net/ethernet/netronome/nfp/crypto/tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/netronome/nfp/crypto/tls.c +1 -1
@@ -492,7 +492,7 @@ int nfp_net_tls_rx_resync_req(struct net_device *netdev, goto err_cnt_ign; } -switch (iph->version) { +switch (ipv6h->version) {case 4 : sk = inet_lookup_established(dev_net(netdev), &tcp_hashinfo, iph->saddr, th->source, iph->daddr,
Signature · 1 line
2.26.2
Quoted 16 lines · Jakub Kicinski
Test robot reports:
drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req':drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable]
477 | struct ipv6hdr *ipv6h;
| ^~~~~
In file included frominclude/linux/compiler_types.h:65,
from <command-line>:drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]208 | # define fallthrough __attribute__((__fallthrough__)) | ^~~~~~~~~~~~~ drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough' 299 | fallthrough; | ^~~~~~~~~~~
Quoted 5 lines
Use the IPv6 header in the switch, it doesn't matter which header we use to read the version field.
Reported-by kernel test robot <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>
Thanks Jakub,
this looks good to me.
From: Jakub Kicinski <[email protected]>
Date: Wed, 9 Dec 2020 08:18:21 -0800
Quoted 16 lines
Test robot reports:
drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req':drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable]
477 | struct ipv6hdr *ipv6h;
| ^~~~~
In file included frominclude/linux/compiler_types.h:65,
from <command-line>:drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]208 | # define fallthrough __attribute__((__fallthrough__)) | ^~~~~~~~~~~~~ drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough' 299 | fallthrough; | ^~~~~~~~~~~
Quoted 5 lines
Use the IPv6 header in the switch, it doesn't matter which header we use to read the version field.
Reported-by kernel test robot <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>
Applied, thanks.