Skip to contentSkip to conversation

Convert Tegra HDA doc to json-schema

PATCH RESEND In review Sameer Pujar 3 participants 6 messages Dec 3, 2020 – Dec 11, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Convert Tegra HDA doc to json-schema

Convert Tegra HDA doc to YAML format. Ran binding validation checks to ensure there are no warnings/errors for HDA.

Patch "arm64: tegra: Fix Tegra194 HDA {clock,reset}-names ordering" is already merged and hence not included here.

Sameer Pujar (2):
dt-bindings: tegra: Convert HDA doc to json-schema
dt-bindings: tegra: Add missing HDA properties

 .../bindings/sound/nvidia,tegra30-hda.txt          |  35 -------
 .../bindings/sound/nvidia,tegra30-hda.yaml         | 112 +++++++++++++++++++++
 2 files changed, 112 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
Signature · 1 line
2.7.4
#1 lore raw

PATCH RESEND 1/2 dt-bindings: tegra: Convert HDA doc to json-schema

Convert Tegra HDA doc to YAML format.

---
 .../bindings/sound/nvidia,tegra30-hda.txt          | 35 --------
 .../bindings/sound/nvidia,tegra30-hda.yaml         | 98 ++++++++++++++++++++++
 2 files changed, 98 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.txt deleted +0 -35
deleted file mode 100644
index 21cd310..0000000
@@ -1,35 +0,0 @@
-NVIDIA Tegra30 HDA controller
-
-Required properties:
-- compatible : For Tegra30, must contain "nvidia,tegra30-hda".  Otherwise,
-  must contain '"nvidia,<chip>-hda", "nvidia,tegra30-hda"', where <chip> is
-  tegra114, tegra124, or tegra132.
-- reg : Should contain the HDA registers location and length.
-- interrupts : The interrupt from the HDA controller.
-- clocks : Must contain an entry for each required entry in clock-names.
-  See ../clocks/clock-bindings.txt for details.
-- clock-names : Must include the following entries: hda, hda2hdmi, hda2codec_2x
-- resets : Must contain an entry for each entry in reset-names.
-  See ../reset/reset.txt for details.
-- reset-names : Must include the following entries: hda, hda2hdmi, hda2codec_2x
-
-Optional properties:
-- nvidia,model : The user-visible name of this sound complex. Since the property
-  is optional, legacy boards can use default name provided in hda driver.
-
-Example:
-
-hda@70030000 {
-	compatible = "nvidia,tegra124-hda", "nvidia,tegra30-hda";
-	reg = <0x0 0x70030000 0x0 0x10000>;
-	interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
-	clocks = <&tegra_car TEGRA124_CLK_HDA>,
-		 <&tegra_car TEGRA124_CLK_HDA2HDMI>,
-		 <&tegra_car TEGRA124_CLK_HDA2CODEC_2X>;
-	clock-names = "hda", "hda2hdmi", "hda2codec_2x";
-	resets = <&tegra_car 125>, /* hda */
-		 <&tegra_car 128>, /* hda2hdmi */
-		 <&tegra_car 111>; /* hda2codec_2x */
-	reset-names = "hda", "hda2hdmi", "hda2codec_2x";
-	nvidia,model = "jetson-tk1-hda";
-};
Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml new file +98 -0

98 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/2
#2 lore raw

Re: [RESEND PATCH 1/2] dt-bindings: tegra: Convert HDA doc to json-schema

Quoted 10 lines · Sameer Pujar

Convert Tegra HDA doc to YAML format.

---
 .../bindings/sound/nvidia,tegra30-hda.txt          | 35 --------
 .../bindings/sound/nvidia,tegra30-hda.yaml         | 98 ++++++++++++++++++++++
 2 files changed, 98 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
#3 lore raw

PATCH RESEND 2/2 dt-bindings: tegra: Add missing HDA properties

In reply to Sameer Pujar

Document the missing properties which are currently required for Tegra186/Tegra194 DT files.

---
 .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml +14 -0
index 3059bc3..e543a61 100644
@@ -60,6 +60,20 @@ properties:
       - const: hda2hdmi
       - const: hda2codec_2x
 
+  power-domains:
+    maxItems: 1
+
+  interconnects:
+    maxItems: 2
+
+  interconnect-names:
+    items:
+      - const: dma-mem
+      - const: write
+
+  iommus:
+    maxItems: 1
+
   nvidia,model:
     $ref: /schemas/types.yaml#/definitions/string
     description: |
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 2/2
#4 lore raw

Re: [RESEND PATCH 2/2] dt-bindings: tegra: Add missing HDA properties

Quoted 8 lines · Sameer Pujar

Document the missing properties which are currently required for Tegra186/Tegra194 DT files.

---
 .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
maintainer
#5 lore raw
In reply to Sameer Pujar
Quoted 11 lines · Sameer Pujar

Convert Tegra HDA doc to YAML format. Ran binding validation checks to ensure there are no warnings/errors for HDA.

Patch "arm64: tegra: Fix Tegra194 HDA {clock,reset}-names ordering" is already merged and hence not included here.

Sameer Pujar (2):
dt-bindings: tegra: Convert HDA doc to json-schema
dt-bindings: tegra: Add missing HDA properties

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] dt-bindings: tegra: Convert HDA doc to json-schema

      commit: 2d8f8955fe02c1f5d41c283f48d8c6a2a02ae17f
[2/2] dt-bindings: tegra: Add missing HDA properties
      commit: 3759d5edc07598d55124d87bd292a95f79f47997

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark