Skip to contentSkip to conversation

BPi M2 Zero poweroff support via new regulator-poweroff driver

PATCH Superseded Michael Klein 2 participants 5 messages Dec 9, 2020 – Dec 11, 2020

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover BPi M2 Zero poweroff support via new regulator-poweroff driver

Changes in v2:
- rename DT node

Changes in v3:
- add regulator-poweroff driver
- use regulator-poweroff driver instead of gpio-poweroff

Changes in v4:
- hardcode poweroff timeout to 3000ms, not configurable any more
- remove support for multiple regulators
- fix Documentation issues

Michael Klein (3):
power: reset: new driver regulator-poweroff
Documentation: DT: binding documentation for regulator-poweroff
ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node

 .../power/reset/regulator-poweroff.yaml       | 37 ++++++++
 .../dts/sun8i-h2-plus-bananapi-m2-zero.dts    |  5 ++
 drivers/power/reset/Kconfig                   |  7 ++
 drivers/power/reset/Makefile                  |  1 +
 drivers/power/reset/regulator-poweroff.c      | 86 +++++++++++++++++++
 5 files changed, 136 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml
 create mode 100644 drivers/power/reset/regulator-poweroff.c
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH v4 1/3 power: reset: new driver regulator-poweroff

This driver registers a pm_power_off function to disable a set of regulators defined in the devicetree to turn off the board.

---
 drivers/power/reset/Kconfig              |  7 ++
 drivers/power/reset/Makefile             |  1 +
 drivers/power/reset/regulator-poweroff.c | 86 ++++++++++++++++++++++++
 3 files changed, 94 insertions(+)
 create mode 100644 drivers/power/reset/regulator-poweroff.c
drivers/power/reset/Kconfig +7 -0
index d55b3727e00e..b22c4fdb2561 100644
@@ -177,6 +177,13 @@ config POWER_RESET_QNAP
 
 	  Say Y if you have a QNAP NAS.
 
+config POWER_RESET_REGULATOR
+	bool "Regulator subsystem power-off driver"
+	depends on OF && REGULATOR
+	help
+	  This driver supports turning off your board by disabling a
+	  power regulator defined in the devicetree.
+
 config POWER_RESET_RESTART
 	bool "Restart power-off driver"
 	help
drivers/power/reset/Makefile +1 -0
index c51eceba9ea3..9dc49d3a57ff 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_POWER_RESET_OCELOT_RESET) += ocelot-reset.o
 obj-$(CONFIG_POWER_RESET_PIIX4_POWEROFF) += piix4-poweroff.o
 obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o
 obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o
+obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o
 obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o
 obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o
 obj-$(CONFIG_POWER_RESET_VERSATILE) += arm-versatile-reboot.o
drivers/power/reset/regulator-poweroff.c new file +86 -0

86 lines not on this page · raw message

Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH v4 2/3 Documentation: DT: binding documentation for regulator-poweroff

In reply to Michael Klein

Add devicetree binding documentation for regulator-poweroff driver.

---
 .../power/reset/regulator-poweroff.yaml       | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml
Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml new file +37 -0
new file mode 100644
index 000000000000..c74ac247ab70
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/reset/regulator-poweroff.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Force-disable power regulator to turn the power off.
+
+maintainers:
+  - Michael Klein <[email protected]>
+
+description: |
+  When the power-off handler is called, a power regulator is disabled by
+  calling regulator_force_disable(). If the power is still on and the
+  CPU still running after a 3000ms delay, a warning is emitted.
+
+properties:
+  compatible:
+    const: "regulator-poweroff"
+
+  power-supply:
+    description:
+      regulator to disable on power-down
+
+required:
+  - compatible
+  - power-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    regulator-poweroff {
+        compatible = "regulator-poweroff";
+        power-supply = <&reg_vcc1v2>;
+    };
+...
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Reviewed-by on v4 2/3
#3 lore raw

Re: [PATCH v4 2/3] Documentation: DT: binding documentation for regulator-poweroff

Quoted 8 lines · Michael Klein

Add devicetree binding documentation for regulator-poweroff driver.

---
 .../power/reset/regulator-poweroff.yaml       | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml
#4 lore raw

PATCH v4 3/3 ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node

In reply to Michael Klein

Add add devicetree information for the regulator-poweroff driver.

---
This patch depends on the regulator names added in

 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts +5 -0
index b43028f9e6df..e7370a049ce2 100644
@@ -86,6 +86,11 @@ reg_vcc1v2: vcc1v2 {
 		vin-supply = <&reg_vcc5v0>;
 	};
 
+	poweroff {
+		compatible = "regulator-poweroff";
+		power-supply = <&reg_vcc1v2>;
+	};
+
 	wifi_pwrseq: wifi_pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel