x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk
PATCH v2 1/1 x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk
From: Dan Nicholson <[email protected]>
The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot. It works without problem after adding the parameter reboot=bios.
---
v2:
- fix typo in the commit message.
arch/x86/kernel/reboot.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/x86/kernel/reboot.c +10 -0
@@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = { }, }, +/* GIGABYTE */ + {/* Workaround hard disk crash on ACPI reboot */ + .callback = set_bios_reboot, + .ident = "GIGABYTE BRIX BXBT-2807", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"GIGABYTE" ), + DMI_MATCH(DMI_PRODUCT_NAME, "GB-BXBT-2807"), + }, + }, + /* Hewlett-Packard */ { /* Handle problems with rebooting on HP laptops */ .callback = set_bios_reboot,
Signature · 1 line
2.20.1
Borislav Petkov
maintainerQuoted 4 lines · Chris Chiu
From: Dan Nicholson <[email protected]>
The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot.
Is that what the "hard disk crash" in the comment below, refers to?
Quoted 6 lines
It works without problem after adding the parameter reboot=bios.
Signed-off-by Dan Nicholson <[email protected]>Signed-off-by Chris Chiu <[email protected]>Signed-off-by Jian-Hong Pan <[email protected]>
What's Jian's S-o-b tag supposed to mean?
Quoted 13 lines
---
v2:
- fix typo in the commit message.arch/x86/kernel/reboot.c | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/x86/kernel/reboot.c +0
-0
arch/x86/kernel/reboot.c static const struct dmi_system_id reboot_dmi_table[] __initconst = { · line 471
Quoted 5 lines
arch/x86/kernel/reboot.c +2
-0@@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = { }, }, +/* GIGABYTE */ + {/* Workaround hard disk crash on ACPI reboot */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 8 lines · Borislav Petkov
Quoted 4 lines · Chris Chiu
From: Dan Nicholson <[email protected]>
The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot.
Is that what the "hard disk crash" in the comment below, refers to?
Hmm, when I wrote this patch several years back there wasn't any hang when rebooting. According to our internal bug tracker, you could hear the disk head crashing on reboot. The workaround was to do a BIOS reboot rather than an ACPI reboot. My original commit message was:
x86/reboot: Use bios reboot for GIGABYTE BRIX BXBT-2807
Using ACPI, the hard disk crashes on reboot. This seems to be avoided when using the BIOS to reboot.
I don't know if this became a hang with more recent kernels as described in this commit message. Chris?
--
Dan