perf report: Support --header-only for pipe mode
Namhyung Kim
maintainerPATCH 1/2 perf report: Support --header-only for pipe mode
The --header-only checks file header and prints the feature data. But as pipe mode doesn't have it in the header it prints almost nothing. Change it to process first few records until it founds HEADER_FEATURE.
Before:
$ perf record -o- true | perf report -i- --header-only # ======== # captured on : Thu Dec 10 14:34:59 2020 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== #
After:
$ perf record -o- true | perf report -i- --header-only
# ========
# captured on : Thu Dec 10 14:49:11 2020
# header version : 1
# data offset : 0
# data size : 0
# feat offset : 0
# ========
#
# hostname : balhae
# os release : 5.7.17-1xxx
# perf version : 5.10.rc6.gdb0ea13cc741
# arch : x86_64
# nrcpus online : 8
# nrcpus avail : 8
# cpudesc : Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz
# cpuid : GenuineIntel,6,142,12
# total memory : 16158916 kB
# cmdline : perf record -o- true
# event : name = cycles, , id = { 81, 82, 83, 84, 85, 86, 87, 88 }, size = 120, ...
# CPU_TOPOLOGY info available, use -I to display
# NUMA_TOPOLOGY info available, use -I to display
# pmu mappings: intel_pt = 9, intel_bts = 8, software = 1, power = 20, uprobe = 7, ...
# time of first sample : 0.000000
# time of last sample : 0.000000
# sample duration : 0.000 ms
# MEM_TOPOLOGY info available, use -I to display
# cpu pmu capabilities: branches=32, max_precise=3, pmu_name=skylake--- tools/perf/builtin-report.c | 9 +++++++++ 1 file changed, 9 insertions(+)
tools/perf/builtin-report.c +9 -0
@@ -226,6 +226,8 @@ static int process_feature_event(struct perf_session *session,pr_err ("failed: wrong feature ID: %" PRI_lu64"\n" , event->feat.feat_id);return -1 ; + }else if (rep->header_only) { + session_done =1 ; }/*
@@ -1512,6 +1514,13 @@ int cmd_report(int argc, const char **argv)perf_session__fprintf_info (session, stdout, report.show_full_info);if (report.header_only) { +if (data.is_pipe) { +/* +* we need to process first few records +* which contains PERF_RECORD_HEADER_FEATURE. +*/ +perf_session__process_events (session); + } ret =0 ; goto error; }
Signature · 1 line
2.29.2.576.ga3fc446d84-goog
Namhyung Kim
maintainerPATCH 2/2 perf evlist: Support pipe mode display
Likewise, perf evlist command should print event attributes by reading PERF_RECORD_HEADER_ATTR records.
Before:
$ perf record -o- true | ./perf evlist -i- (prints nothing)
After:
$ perf record -o- true | ./perf evlist -i- cycles:pppH
--- tools/perf/builtin-evlist.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
tools/perf/builtin-evlist.c +17 -1
@@ -17,6 +17,14 @@#include "util/data.h" #include "util/debug.h" #include <linux/err.h> +#include "util/tool.h" + +static int process_header_feature (struct perf_session *session__maybe_unused , +union perf_event *event__maybe_unused ) +{ + session_done =1 ; +return 0 ; +}static int __cmd_evlist (const char *file_name,struct perf_attr_details *details) {
@@ -27,12 +35,20 @@ static int __cmd_evlist(const char *file_name, struct perf_attr_details *details .mode = PERF_DATA_MODE_READ, .force = details->force, }; +struct perf_tool tool = { +/* only needed for pipe mode */ + .attr = perf_event__process_attr, + .feature = process_header_feature, + };bool has_tracepoint = false; - session =perf_session__new (&data,0 ,NULL ); + session =perf_session__new (&data,0 , &tool);if (IS_ERR (session))return PTR_ERR (session); +if (data.is_pipe) +perf_session__process_events (session); +evlist__for_each_entry (session->evlist, pos) {evsel__fprintf (pos, details, stdout);
Signature · 1 line
2.29.2.576.ga3fc446d84-goog
Re: [PATCH 2/2] perf evlist: Support pipe mode display
Quoted 4 lines · Namhyung Kim
Likewise, perf evlist command should print event attributes by reading
PERF_RECORD_HEADER_ATTRrecords.Before:
Quoted 8 lines
$ perf record -o- true | ./perf evlist -i- (prints nothing)After:
$ perf record -o- true | ./perf evlist -i- cycles:pppHSigned-off-by Namhyung Kim <[email protected]>
thanks,
jirka
Quoted 48 lines
--- tools/perf/builtin-evlist.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)tools/perf/builtin-evlist.c +17
-1@@ -17,6 +17,14 @@#include "util/data.h" #include "util/debug.h" #include <linux/err.h> +#include "util/tool.h" + +static int process_header_feature (struct perf_session *session__maybe_unused , +union perf_event *event__maybe_unused ) +{ + session_done =1 ; +return 0 ; +}static int __cmd_evlist (const char *file_name,struct perf_attr_details *details) {@@ -27,12 +35,20 @@ static int __cmd_evlist(const char *file_name, struct perf_attr_details *details .mode = PERF_DATA_MODE_READ, .force = details->force, }; +struct perf_tool tool = { +/* only needed for pipe mode */ + .attr = perf_event__process_attr, + .feature = process_header_feature, + };bool has_tracepoint = false; - session =perf_session__new (&data,0 ,NULL ); + session =perf_session__new (&data,0 , &tool);if (IS_ERR (session))return PTR_ERR (session); +if (data.is_pipe) +perf_session__process_events (session); +evlist__for_each_entry (session->evlist, pos) {evsel__fprintf (pos, details, stdout);Signature · 1 line
2.29.2.576.ga3fc446d84-goog
Re: [PATCH 2/2] perf evlist: Support pipe mode display
Em Mon, Dec 14, 2020 at 12:00:35AM +0100, Jiri Olsa escreveu:
Quoted 8 lines · Namhyung Kim
Quoted 7 lines
Likewise, perf evlist command should print event attributes by reading
PERF_RECORD_HEADER_ATTRrecords.Before:
$ perf record -o- true | ./perf evlist -i- (prints nothing)
Quoted 7 lines
Quoted 5 lines
After:
$ perf record -o- true | ./perf evlist -i- cycles:pppHSigned-off-by Namhyung Kim <[email protected]>Acked-by Jiri Olsa <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 45 lines · Namhyung Kim
The --header-only checks file header and prints the feature data. But as pipe mode doesn't have it in the header it prints almost nothing. Change it to process first few records until it founds
HEADER_FEATURE.Before:
$ perf record -o- true | perf report -i- --header-only # ======== # captured on : Thu Dec 10 14:34:59 2020 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== #After:
$ perf record -o- true | perf report -i- --header-only # ======== # captured on : Thu Dec 10 14:49:11 2020 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== # # hostname : balhae # os release : 5.7.17-1xxx # perf version : 5.10.rc6.gdb0ea13cc741 # arch : x86_64 # nrcpus online : 8 # nrcpus avail : 8 # cpudesc : Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz # cpuid : GenuineIntel,6,142,12 # total memory : 16158916 kB # cmdline : perf record -o- true # event : name = cycles, , id = { 81, 82, 83, 84, 85, 86, 87, 88 }, size = 120, ... # CPU_TOPOLOGY info available, use -I to display # NUMA_TOPOLOGY info available, use -I to display # pmu mappings: intel_pt = 9, intel_bts = 8, software = 1, power = 20, uprobe = 7, ... # time of first sample : 0.000000 # time of last sample : 0.000000 # sample duration : 0.000 ms # MEM_TOPOLOGY info available, use -I to display # cpu pmu capabilities: branches=32, max_precise=3, pmu_name=skylake
Quoted 1 line
Signed-off-by Namhyung Kim <[email protected]>
thanks,
jirka
Quoted 34 lines
--- tools/perf/builtin-report.c | 9 +++++++++ 1 file changed, 9 insertions(+)tools/perf/builtin-report.c +9
-0@@ -226,6 +226,8 @@ static int process_feature_event(struct perf_session *session,pr_err ("failed: wrong feature ID: %" PRI_lu64"\n" , event->feat.feat_id);return -1 ; + }else if (rep->header_only) { + session_done =1 ; }/* @@ -1512,6 +1514,13 @@ int cmd_report(int argc, const char **argv)perf_session__fprintf_info (session, stdout, report.show_full_info);if (report.header_only) { +if (data.is_pipe) { +/* +* we need to process first few records +* which contains PERF_RECORD_HEADER_FEATURE. +*/ +perf_session__process_events (session); + } ret =0 ; goto error; }Signature · 1 line
2.29.2.576.ga3fc446d84-goog
Em Mon, Dec 14, 2020 at 12:00:19AM +0100, Jiri Olsa escreveu:
Quoted 46 lines · Namhyung Kim
Quoted 45 lines
The --header-only checks file header and prints the feature data. But as pipe mode doesn't have it in the header it prints almost nothing. Change it to process first few records until it founds
HEADER_FEATURE.Before:
$ perf record -o- true | perf report -i- --header-only # ======== # captured on : Thu Dec 10 14:34:59 2020 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== #After:
$ perf record -o- true | perf report -i- --header-only # ======== # captured on : Thu Dec 10 14:49:11 2020 # header version : 1 # data offset : 0 # data size : 0 # feat offset : 0 # ======== # # hostname : balhae # os release : 5.7.17-1xxx # perf version : 5.10.rc6.gdb0ea13cc741 # arch : x86_64 # nrcpus online : 8 # nrcpus avail : 8 # cpudesc : Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz # cpuid : GenuineIntel,6,142,12 # total memory : 16158916 kB # cmdline : perf record -o- true # event : name = cycles, , id = { 81, 82, 83, 84, 85, 86, 87, 88 }, size = 120, ... # CPU_TOPOLOGY info available, use -I to display # NUMA_TOPOLOGY info available, use -I to display # pmu mappings: intel_pt = 9, intel_bts = 8, software = 1, power = 20, uprobe = 7, ... # time of first sample : 0.000000 # time of last sample : 0.000000 # sample duration : 0.000 ms # MEM_TOPOLOGY info available, use -I to display # cpu pmu capabilities: branches=32, max_precise=3, pmu_name=skylake
Quoted 3 lines
Quoted 1 line
Signed-off-by Namhyung Kim <[email protected]>Acked-by Jiri Olsa <[email protected]>
Thanks, applied.
- Arnaldo