vxlan: avoid double unlikely() notation when using IS_ERR()
Subsystems (2)
PATCH 1/1 vxlan: avoid double unlikely() notation when using IS_ERR()
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself.
Clean up code by removing redundant notation.
Signed-off-by Antonio Quartulli <[email protected]>
--- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/vxlan.c +1 -1
@@ -2477,7 +2477,7 @@ static struct dst_entry *vxlan6_get_route(struct vxlan_dev *vxlan, ndst = ipv6_stub->ipv6_dst_lookup_flow (vxlan->net, sock6->sock->sk, &fl6,NULL ); -if (unlikely (IS_ERR (ndst))) { +if (IS_ERR (ndst)) {netdev_dbg (dev,"no route to %pI6\n" , daddr);return ERR_PTR (-ENETUNREACH ); }
Signature · 1 line
2.29.2
From: Antonio Quartulli <[email protected]>
Date: Thu, 10 Dec 2020 09:55:49 +0100
Quoted 8 lines
The definition of
IS_ERR()already applies theunlikely()notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside ofIS_ERR()itself.Clean up code by removing redundant notation.
Signed-off-by Antonio Quartulli <[email protected]>
Applied to net-next, thanks.