setup-scripts - removing confusion for users when script succeeds, but does not include correct version in success message
PATCH 1/2 setup-scripts - removing confusion for users when script succeeds, but does not include correct version in success message
From: a0232989 <[email protected]>
--- setup-host-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
setup-host-check.sh +1 -1
@@ -43,6 +43,6 @@ if [ "$host" != "precise" -a "$host" != "trusty" -a "$host" != "xenial" -a "$ho echo "Unsupported host machine, only Ubuntu 12.04 LTS, Ubuntu 14.04 LTS, Ubuntu 16.04 LTS, and Ubuntu 18.04 LTS are supported" exit 1 fi -echo "Ubuntu 12.04 LTS, Ubuntu 14.04, or Ubuntu 14.04 LTS is being used, continuing.." +echo "Ubuntu 12.04 LTS, Ubuntu 14.04, LTS Ubuntu 16.04 LTS, or Ubuntu 18.04 LTS is being used, continuing.." echo "--------------------------------------------------------------------------------" echo
Signature · 1 line
2.17.1
Quoted 20 lines · Caleb Robey
From:
a0232989<[email protected]>--- setup-host-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)setup-host-check.sh +1
-2@@ -43,6 +43,6 @@ if [ "$host" != "precise" -a "$host" != "trusty" -a "$host" != "xenial" -a "$ho echo "Unsupported host machine, only Ubuntu 12.04 LTS, Ubuntu 14.04 LTS, Ubuntu 16.04 LTS, and Ubuntu 18.04 LTS are supported" exit 1 fi -echo "Ubuntu 12.04 LTS, Ubuntu 14.04, or Ubuntu 14.04 LTS is being used, continuing.." +echo "Ubuntu 12.04 LTS, Ubuntu 14.04, LTS Ubuntu 16.04 LTS, or Ubuntu 18.04 LTS is being used, continuing.." echo "--------------------------------------------------------------------------------" echo --
Quoted 1 line
2.17.1
I don't see the file "setup-host-check.sh" in meta-ti or meta-arago. The list of Ubuntu versions there looks very out of date as well.
Are you sure this patch is being sent to the right place?
Thanks,
Signature · 2 lines
Paul Barker Konsulko Group
Paul
Quoted 24 lines · Paul Barker
Quoted 19 lines · Caleb Robey
From:
a0232989<[email protected]>--- setup-host-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)setup-host-check.sh +1
-2@@ -43,6 +43,6 @@ if [ "$host" != "precise" -a "$host" != "trusty" -a "$host" != "xenial" -a "$ho echo "Unsupported host machine, only Ubuntu 12.04 LTS, Ubuntu 14.04 LTS, Ubuntu 16.04 LTS, and Ubuntu 18.04 LTS are supported" exit 1 fi -echo "Ubuntu 12.04 LTS, Ubuntu 14.04, or Ubuntu 14.04 LTS is being used, continuing.." +echo "Ubuntu 12.04 LTS, Ubuntu 14.04, LTS Ubuntu 16.04 LTS, or Ubuntu 18.04 LTS is being used, continuing.." echo "--------------------------------------------------------------------------------" echo --Quoted 1 line
2.17.1
I don't see the file "
setup-host-check.sh" in meta-ti or meta-arago. The list of Ubuntu versions there looks very out of date as well.
Quoted 1 line
Are you sure this patch is being sent to the right place?
I asked Caleb to send it to this list. But he forgot to add the target repo.
These scripts are part of this repo
http://arago-project.org/git/projects/?p=tisdk-setup-scripts.git;a=summary
Dan
Quoted 27 lines · Dan Murphy
Paul
Quoted 24 lines · Paul Barker
Quoted 19 lines · Caleb Robey
From:
a0232989<[email protected]>--- setup-host-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)setup-host-check.sh +1
-2@@ -43,6 +43,6 @@ if [ "$host" != "precise" -a "$host" != "trusty" -a "$host" != "xenial" -a "$ho echo "Unsupported host machine, only Ubuntu 12.04 LTS, Ubuntu 14.04 LTS, Ubuntu 16.04 LTS, and Ubuntu 18.04 LTS are supported" exit 1 fi -echo "Ubuntu 12.04 LTS, Ubuntu 14.04, or Ubuntu 14.04 LTS is being used, continuing.." +echo "Ubuntu 12.04 LTS, Ubuntu 14.04, LTS Ubuntu 16.04 LTS, or Ubuntu 18.04 LTS is being used, continuing.." echo "--------------------------------------------------------------------------------" echo --Quoted 1 line
2.17.1
I don't see the file "
setup-host-check.sh" in meta-ti or meta-arago. The list of Ubuntu versions there looks very out of date as well.
Quoted 8 lines
Quoted 1 line
Are you sure this patch is being sent to the right place?
I asked Caleb to send it to this list. But he forgot to add the target repo.
These scripts are part of this repo
http://arago-project.org/git/projects/?p=tisdk-setup-scripts.git;a=summary
The patch should not have [meta-ti] nor [dunfell/master] tags in the subject. Instead, it should have [tisdk-setup-scripts] tag to avoid confusion.
Signature · 1 line
Denys
Denys
Quoted 29 lines · Denys Dmytriyenko
Quoted 28 lines · Dan Murphy
Paul
Quoted 25 lines · Paul Barker
Quoted 19 lines · Caleb Robey
From:
a0232989<[email protected]>--- setup-host-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)setup-host-check.sh +1
-2@@ -43,6 +43,6 @@ if [ "$host" != "precise" -a "$host" != "trusty" -a "$host" != "xenial" -a "$ho echo "Unsupported host machine, only Ubuntu 12.04 LTS, Ubuntu 14.04 LTS, Ubuntu 16.04 LTS, and Ubuntu 18.04 LTS are supported" exit 1 fi -echo "Ubuntu 12.04 LTS, Ubuntu 14.04, or Ubuntu 14.04 LTS is being used, continuing.." +echo "Ubuntu 12.04 LTS, Ubuntu 14.04, LTS Ubuntu 16.04 LTS, or Ubuntu 18.04 LTS is being used, continuing.." echo "--------------------------------------------------------------------------------" echo --Quoted 1 line
2.17.1
I don't see the file "
setup-host-check.sh" in meta-ti or meta-arago. The list of Ubuntu versions there looks very out of date as well.Are you sure this patch is being sent to the right place?
Quoted 9 lines
Quoted 6 lines
I asked Caleb to send it to this list. But he forgot to add the target repo.
These scripts are part of this repo
http://arago-project.org/git/projects/?p=tisdk-setup-scripts.git;a=summary
The patch should not have [meta-ti] nor [dunfell/master] tags in the subject. Instead, it should have [tisdk-setup-scripts] tag to avoid confusion.
Yeah these are Caleb's first patches so he is learning. He originally sent them to meta-ti.
Caleb
$subject should be
[tisdk-setup-scripts] [PATCH 1/2] setup-scripts - removing confusion for users when script succeeds, but does not include correct version in success message
Dan
Caleb
Quoted 1 line · Caleb Robey
From:
a0232989<[email protected]>
Please use your real name here
And you did not add the Signed-off-by
Also please fix the $subject
Dan