Skip to contentSkip to conversation

erofs-utils: fuse: fix linking when using --with-selinux

PATCH In review David Michael 3 participants 3 messages Dec 11, 2020 – Dec 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 erofs-utils: fuse: fix linking when using --with-selinux

The libselinux functions selabel_open and selabel_close are called by lib/config.c, so include libselinux in CFLAGS and LIBS to fix building erofsfuse.

---

Hi,

Trying to build both mkfs.erofs with SELinux and erofsfuse at the same time (with both --enable-fuse and --with-selinux) results in the following linking errors:

/usr/bin/ld: ../lib/.libs/liberofs.a(liberofs_la-config.o): in function `erofs_selabel_open':
/home/dm0/rpmbuild/BUILD/erofs-utils-1.2/lib/config.c:75: undefined reference to selabel_open' /usr/bin/ld: ../lib/.libs/liberofs.a(liberofs_la-config.o): in function erofs_exit_configure':
/home/dm0/rpmbuild/BUILD/erofs-utils-1.2/lib/config.c:42: undefined reference to `selabel_close'

Are these programs supposed to be configured separately? If this build configuration is supposed to work, this change fixes linking.

Thanks.

David

 fuse/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fuse/Makefile.am +2 -2
index f14f6fd..e7757bc 100644
@@ -5,6 +5,6 @@ AUTOMAKE_OPTIONS = foreign
 bin_PROGRAMS     = erofsfuse
 erofsfuse_SOURCES = dir.c main.c
 erofsfuse_CFLAGS = -Wall -Werror -I$(top_srcdir)/include
-erofsfuse_CFLAGS += -DFUSE_USE_VERSION=26 ${libfuse_CFLAGS}
-erofsfuse_LDADD = $(top_builddir)/lib/liberofs.la ${libfuse_LIBS} ${liblz4_LIBS}
+erofsfuse_CFLAGS += -DFUSE_USE_VERSION=26 ${libfuse_CFLAGS} ${libselinux_CFLAGS}
+erofsfuse_LDADD = $(top_builddir)/lib/liberofs.la ${libfuse_LIBS} ${liblz4_LIBS} ${libselinux_LIBS}
 
Signature · 1 line
2.29.2
#1 lore raw

Hi David,

Quoted 9 lines · David Michael

The libselinux functions selabel_open and selabel_close are called by lib/config.c, so include libselinux in CFLAGS and LIBS to fix building erofsfuse.

---

Hi,

Quoted 8 lines

Trying to build both mkfs.erofs with SELinux and erofsfuse at the same time (with both --enable-fuse and --with-selinux) results in the following linking errors:

/usr/bin/ld: ../lib/.libs/liberofs.a(liberofs_la-config.o): in function `erofs_selabel_open':
/home/dm0/rpmbuild/BUILD/erofs-utils-1.2/lib/config.c:75: undefined reference to selabel_open' /usr/bin/ld: ../lib/.libs/liberofs.a(liberofs_la-config.o): in function erofs_exit_configure':
/home/dm0/rpmbuild/BUILD/erofs-utils-1.2/lib/config.c:42: undefined reference to `selabel_close'

Many thanks for your patch! I tested with limited compilation options before, that is why I'm now worrying about compile error after 1.2 release :( (I may need to release some 1.2.1 when these build errors are all gone.)

Quoted 3 lines

Are these programs supposed to be configured separately? If this build configuration is supposed to work, this change fixes linking.

It shouldn't supposed to be configured separately, but I'm not sure how to add them to liberofs as a whole decently (I mean with automake/libtool infrastructure)... (and there was a trick to staticly build lz4-1.8.x correctly which should work fine as well :(....)

Thanks,
Gao Xiang

Quoted 24 lines

Thanks.

David

 fuse/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fuse/Makefile.am +2 -2
index f14f6fd..e7757bc 100644
@@ -5,6 +5,6 @@ AUTOMAKE_OPTIONS = foreign
 bin_PROGRAMS     = erofsfuse
 erofsfuse_SOURCES = dir.c main.c
 erofsfuse_CFLAGS = -Wall -Werror -I$(top_srcdir)/include
-erofsfuse_CFLAGS += -DFUSE_USE_VERSION=26 ${libfuse_CFLAGS}
-erofsfuse_LDADD = $(top_builddir)/lib/liberofs.la ${libfuse_LIBS} ${liblz4_LIBS}
+erofsfuse_CFLAGS += -DFUSE_USE_VERSION=26 ${libfuse_CFLAGS} ${libselinux_CFLAGS}
+erofsfuse_LDADD = $(top_builddir)/lib/liberofs.la ${libfuse_LIBS} ${liblz4_LIBS} ${libselinux_LIBS}
 
Signature · 1 line
2.29.2
Reviewed-by Li Guifu Tested-by Li Guifu on v1 1/1
#2 lore raw
In reply to David Michael
Quoted 21 lines · David Michael

The libselinux functions selabel_open and selabel_close are called by lib/config.c, so include libselinux in CFLAGS and LIBS to fix building erofsfuse.

---

Hi,

Trying to build both mkfs.erofs with SELinux and erofsfuse at the same time (with both --enable-fuse and --with-selinux) results in the following linking errors:

/usr/bin/ld: ../lib/.libs/liberofs.a(liberofs_la-config.o): in function `erofs_selabel_open':
/home/dm0/rpmbuild/BUILD/erofs-utils-1.2/lib/config.c:75: undefined reference to selabel_open' /usr/bin/ld: ../lib/.libs/liberofs.a(liberofs_la-config.o): in function erofs_exit_configure':
/home/dm0/rpmbuild/BUILD/erofs-utils-1.2/lib/config.c:42: undefined reference to `selabel_close'

Are these programs supposed to be configured separately? If this build configuration is supposed to work, this change fixes linking.

Quoted 7 lines

Thanks.

David

 fuse/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

It's fixed

Thanks,