Fix audispd crash on ARM 32-Bits
PATCH 1/1 Fix audispd crash on ARM 32-Bits
On ARM 32-Bits, audispd is crashing. Backtrace:
(gdb) bt
0 0xb6e20958 in __GI_raise (sig=sig@entry=6)
at /usr/src/debug/glibc/2.23-r0/git/sysdeps/unix/sysv/linux/raise.c:54
1 0xb6e21e58 in __GI_abort ()
at /usr/src/debug/glibc/2.23-r0/git/stdlib/abort.c:118
2 0xb6e59d64 in __libc_message (do_abort=do_abort@entry=2,
fmt=0xb6f1119c "*** Error in `%s': %s: 0x%s ***\n")
at /usr/src/debug/glibc/2.23-r0/git/sysdeps/posix/libc_fatal.c:175
3 0xb6e60108 in malloc_printerr (action=<optimized out>,
str=0xb6f11354 "double free or corruption (fasttop)", ptr=<optimized out>, ar_ptr=<optimized out>)
at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:5007
4 0xb6e60a98 in _int_free (av=0xb6f2d79c <main_arena>, p=<optimized out>,
have_lock=<optimized out>)
at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:3868
5 0x004234b8 in free_pconfig (config=0x43b398)
at /usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd-pconfig.c:513
6 0x00421244 in main (argc=<optimized out>, argv=<optimized out>)
at /usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd.c:464
(gdb) f 5
(gdb) p config->path
$2 = 0x43b5f0 ""
(gdb) p config->name
$3 = 0x43b370 "h\264C
Be paranoid and overwrite config->path with zero bytes before doing the free().
--- audisp/audispd-pconfig.c | 4 ++++ 1 file changed, 4 insertions(+)
audisp/audispd-pconfig.c +4 -0
@@ -510,7 +510,11 @@ void free_pconfig(plugin_conf_t *config)close (config->plug_pipe[0 ]);if (config->plug_pipe[1 ] >=0 )close (config->plug_pipe[1 ]); +/* Be paranoid and overwrite config->path with zero bytes before doing the +* free() */ +memset (config->path,0 ,strlen (config->path));free ((void *)config->path); + config->path =NULL ;free ((void *)config->name); }
Signature · 6 lines
2.29.2 -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
Hello,
Thanks for the patch. But if its true that this is against audit-2.4.3, then there is a good chance this is fixed by 2.8.5. There were a number of fixes in this area that fixed various issues with plugins.
Best Regards,
-Steve
Quoted 45 lines · EST Javier Tiá
On ARM 32-Bits, audispd is crashing. Backtrace:
(gdb) bt
00xb6e20958in__GI_raise(sig=sig@entry=6)
at/usr/src/debug/glibc/2.23-r0/git/sysdeps/unix/sysv/linux/raise.c:54
10xb6e21e58in__GI_abort()
at/usr/src/debug/glibc/2.23-r0/git/stdlib/abort.c:118
20xb6e59d64in__libc_message(do_abort=do_abort@entry=2,
fmt=0xb6f1119c "*** Error in `%s': %s: 0x%s ***\n")
at/usr/src/debug/glibc/2.23-r0/git/sysdeps/posix/libc_fatal.c:175
30xb6e60108inmalloc_printerr(action=<optimized out>,
str=0xb6f11354 "double free or corruption (fasttop)", ptr=<optimized
out>, ar_ptr=<optimized out>)
at/usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:5007
40xb6e60a98in_int_free(av=0xb6f2d79c <main_arena>, p=<optimized out>,
have_lock=<optimized out>)
at/usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:3868
50x004234b8infree_pconfig(config=0x43b398)
at/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd-pconfig.c:51360x00421244in main (argc=<optimized out>, argv=<optimized out>) at/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd.c:464(gdb) f 5
(gdb) pconfig->path
$2 =0x43b5f0""
(gdb) pconfig->name
$3 =0x43b370"h\264CBe paranoid and overwrite
config->pathwith zero bytes before doing thefree().--- audisp/audispd-pconfig.c | 4 ++++ 1 file changed, 4 insertions(+)audisp/audispd-pconfig.c +1
-0@@ -510,7 +510,11 @@ void free_pconfig(plugin_conf_t *config)close (config->plug_pipe[0 ]);if (config->plug_pipe[1 ] >=0 )close (config->plug_pipe[1 ]); +/* Be paranoid and overwrite config->path with zero bytes before doing the + *
free()*/
audisp/audispd-pconfig.c void free_pconfig(plugin_conf_t *config) · line 519
Quoted 5 lines
audisp/audispd-pconfig.c +2
-0+memset (config->path,0 ,strlen (config->path));free ((void *)config->path); + config->path =NULL ;free ((void *)config->name); }
--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit
Hi Steve,
Thank you for your prompt response and for pointing to a solution.
Yes, this patch it's applied to audit v2.4.3. It's an embedded device, and at the moment, we're unable to upgrade the audit to a higher audit version.
If audit v2.4.y were still maintainable, would you accept this patch for audit v2.4.y?
-Javier
Quoted 45 lines · Steve Grubb
Hello,
Thanks for the patch. But if its true that this is against audit-2.4.3, then there is a good chance this is fixed by 2.8.5. There were a number of fixes in this area that fixed various issues with plugins.
Best Regards,
-SteveQuoted 35 lines · EST Javier Tiá
On ARM 32-Bits, audispd is crashing. Backtrace:
(gdb) bt
00xb6e20958in__GI_raise(sig=sig@entry=6)at /usr/src/debug/glibc/2.23-r0/git/sysdeps/unix/sysv/linux/raise.c:54 1 0xb6e21e58 in __GI_abort () at /usr/src/debug/glibc/2.23-r0/git/stdlib/abort.c:118 2 0xb6e59d64 in __libc_message (do_abort=do_abort@entry=2, fmt=0xb6f1119c "*** Error in `%s': %s: 0x%s ***\n") at /usr/src/debug/glibc/2.23-r0/git/sysdeps/posix/libc_fatal.c:175 3 0xb6e60108 in malloc_printerr (action=<optimized out>, str=0xb6f11354 "double free or corruption (fasttop)", ptr=<optimized out>, ar_ptr=<optimized out>) at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:5007 4 0xb6e60a98 in _int_free (av=0xb6f2d79c <main_arena>, p=<optimized out>, have_lock=<optimized out>) at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:38685
0x004234b8infree_pconfig(config=0x43b398)
at/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd-pconfig.c:51360x00421244in main (argc=<optimized out>, argv=<optimized out>) at/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd.c:464(gdb) f 5
(gdb) pconfig->path
$2 =0x43b5f0""
(gdb) pconfig->name
$3 =0x43b370"h\264CBe paranoid and overwrite
config->pathwith zero bytes before doing thefree().--- audisp/audispd-pconfig.c | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 19 lines
Quoted 10 lines
audisp/audispd-pconfig.c +1
-0@@ -510,7 +510,11 @@ void free_pconfig(plugin_conf_t *config)close (config->plug_pipe[0 ]);if (config->plug_pipe[1 ] >=0 )close (config->plug_pipe[1 ]); +/* Be paranoid and overwrite config->path with zero bytes before doing the + *
free()*/audisp/audispd-pconfig.c void free_pconfig(plugin_conf_t *config) · line 519
Quoted 5 lines
audisp/audispd-pconfig.c +2
-0+memset (config->path,0 ,strlen (config->path));free ((void *)config->path); + config->path =NULL ;free ((void *)config->name); }
--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit
Quoted 5 lines · Javier
Thank you for your prompt response and for pointing to a solution.
Yes, this patch it's applied to audit v2.4.3. It's an embedded device, and at the moment, we're unable to upgrade the audit to a higher audit version.
That's a shame. But if you have a reproducer, it might be worth seeing if its fixed in 2.8.5 and bisecting back to find the official patch if it were fixed.
Quoted 1 line
If audit v2.4.y were still maintainable,
It's not
Quoted 1 line
would you accept this patch for audit v2.4.y?
That depends. You are zeroing out the path and then setting it to NULL. Setting the pointer to NULL should be enough. If not, setting the first byte to 0 should wipe out the whole string for any string function. But usually this kind of fixup is because it gets used again somewhere by accident. That would be a plugin lifecycle issue and would be the root cause. The plugin lifecycle was reworked sometime after the release you have.
So, my guess (and it's pure speculation without a reproducer) is this covers up whatever problem you are seeing. But there may be a deeper issue about a plugin not being fully decommissioned. It's a long way to say, I'd look deeper as to how this goes wrong.
-Steve
Quoted 9 lines
-Javier
Quoted 4 lines · Steve Grubb
Hello,
Thanks for the patch. But if its true that this is against audit-2.4.3, then
there is a good chance this is fixed by 2.8.5. There were a number
Quoted 91 lines
Quoted 91 lines
of fixes in this area that fixed various issues with plugins.
Best Regards,
-SteveQuoted 84 lines · EST Javier Tiá
On ARM 32-Bits, audispd is crashing. Backtrace:
(gdb) bt
00xb6e20958in__GI_raise(sig=sig@entry=6)at /usr/src/debug/glibc/2.23-r0/git/sysdeps/unix/sysv/linux/raise.c:541
0xb6e21e58in__GI_abort()at /usr/src/debug/glibc/2.23-r0/git/stdlib/abort.c:1182
0xb6e59d64in__libc_message(do_abort=do_abort@entry=2,fmt=0xb6f1119c "*** Error in `%s': %s: 0x%s ***\n") at /usr/src/debug/glibc/2.23-r0/git/sysdeps/posix/libc_fatal.c:1753
0xb6e60108inmalloc_printerr(action=<optimized out>,str=0xb6f11354 "double free or corruption (fasttop)", ptr=<optimizedout>, ar_ptr=<optimized out>)
at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:50074
0xb6e60a98in_int_free(av=0xb6f2d79c <main_arena>, p=<optimized out>,have_lock=<optimized out>) at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:38685
0x004234b8infree_pconfig(config=0x43b398)at
/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd-pconfig.c:51360x00421244in main (argc=<optimized out>, argv=<optimized out>) at/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd.c:464(gdb) f 5
(gdb) pconfig->path
$2 =0x43b5f0""
(gdb) pconfig->name
$3 =0x43b370"h\264CBe paranoid and overwrite
config->pathwith zero bytes before doing thefree().
---audisp/audispd-pconfig.c | 4 ++++ 1 file changed, 4 insertions(+)audisp/audispd-pconfig.c +1
-0@@ -510,7 +510,11 @@ void free_pconfig(plugin_conf_t *config)close (config->plug_pipe[0 ]);if (config->plug_pipe[1 ] >=0 )close (config->plug_pipe[1 ]); +/* Be paranoid and overwrite config->path with zero bytes before doing
the + *free()*/audisp/audispd-pconfig.c +2
-0+memset (config->path,0 ,strlen (config->path));free ((void *)config->path); + config->path =NULL ;
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
free((void *)config->name); }
--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit
Hi Steve,
Understood. Thank you for all your comments and suggestions.
-Javier
Quoted 33 lines · Steve Grubb
Quoted 5 lines · Javier
Thank you for your prompt response and for pointing to a solution.
Yes, this patch it's applied to audit v2.4.3. It's an embedded device, and at the moment, we're unable to upgrade the audit to a higher audit version.
That's a shame. But if you have a reproducer, it might be worth seeing if its fixed in 2.8.5 and bisecting back to find the official patch if it were fixed.
Quoted 1 line
If audit v2.4.y were still maintainable,
It's not
Quoted 1 line
would you accept this patch for audit v2.4.y?
That depends. You are zeroing out the path and then setting it to NULL. Setting the pointer to NULL should be enough. If not, setting the first byte to 0 should wipe out the whole string for any string function. But usually this kind of fixup is because it gets used again somewhere by accident. That would be a plugin lifecycle issue and would be the root cause. The plugin lifecycle was reworked sometime after the release you have.
So, my guess (and it's pure speculation without a reproducer) is this covers up whatever problem you are seeing. But there may be a deeper issue about a plugin not being fully decommissioned. It's a long way to say, I'd look deeper as to how this goes wrong.
-Steve
Quoted 3 lines
-Javier
Quoted 110 lines
Quoted 6 lines · Steve Grubb
Quoted 5 lines
Hello,
Thanks for the patch. But if its true that this is against audit-2.4.3, then
there is a good chance this is fixed by 2.8.5. There were a number
Quoted 99 lines
Quoted 99 lines
of fixes in this area that fixed various issues with plugins.
Best Regards,
-SteveQuoted 87 lines · EST Javier Tiá
On ARM 32-Bits, audispd is crashing. Backtrace:
(gdb) bt
00xb6e20958in__GI_raise(sig=sig@entry=6)at /usr/src/debug/glibc/2.23-r0/git/sysdeps/unix/sysv/linux/raise.c:541
0xb6e21e58in__GI_abort()at /usr/src/debug/glibc/2.23-r0/git/stdlib/abort.c:1182
0xb6e59d64in__libc_message(do_abort=do_abort@entry=2,fmt=0xb6f1119c "*** Error in `%s': %s: 0x%s ***\n") at /usr/src/debug/glibc/2.23-r0/git/sysdeps/posix/libc_fatal.c:1753
0xb6e60108inmalloc_printerr(action=<optimized out>,str=0xb6f11354 "double free or corruption (fasttop)", ptr=<optimizedout>, ar_ptr=<optimized out>)
at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:50074
0xb6e60a98in_int_free(av=0xb6f2d79c <main_arena>, p=<optimized out>,have_lock=<optimized out>) at /usr/src/debug/glibc/2.23-r0/git/malloc/malloc.c:38685
0x004234b8infree_pconfig(config=0x43b398)at
/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd-pconfig.c:51360x00421244in main (argc=<optimized out>, argv=<optimized out>) at/usr/src/debug/audit/2.4.3-r8/audit-2.4.3/audisp/audispd.c:464(gdb) f 5
(gdb) pconfig->path
$2 =0x43b5f0""
(gdb) pconfig->name
$3 =0x43b370"h\264CBe paranoid and overwrite
config->pathwith zero bytes before doing thefree().
---audisp/audispd-pconfig.c | 4 ++++ 1 file changed, 4 insertions(+)audisp/audispd-pconfig.c +1
-0@@ -510,7 +510,11 @@ void free_pconfig(plugin_conf_t *config)close (config->plug_pipe[0 ]);if (config->plug_pipe[1 ] >=0 )close (config->plug_pipe[1 ]); +/* Be paranoid and overwrite config->path with zero bytes before doing
the + *free()*/audisp/audispd-pconfig.c +2
-0+memset (config->path,0 ,strlen (config->path));free ((void *)config->path); + config->path =NULL ;free ((void *)config->name); }
--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit