package/ninja: fix to be cmake-3.10 compatible again
PATCH v3 1/1 package/ninja: fix to be cmake-3.10 compatible again
Use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 INCLUDE_DIRECTORIES property (as this one is unknown/unused for older cmake versions and has no effect, resuling in a build failure because of missing extra include path).
Fixes:
- http://lists.busybox.net/pipermail/buildroot/2020-December/298159.html
[ 96%] Building CXX object CMakeFiles/ninja.dir/src/browse.cc.o .../build/host-ninja-1.10.2/src/browse.cc:23:10: fatal error: build/browse_py.h: No such file or directory
23 | #include "build/browse_py.h"
| ^~~~~~~~~~~~~~~~~~~compilation terminated.
---
Changes v1 -> v2:
- really use COMPILE_FLAGS (as the patch subject says) (suggested by Yegor Yefremov)
Changes v2 -> v3:
- add reported-by, reviewed-by Yegor Yefremov
- update commit description
--- ...onform-COMPILE_FLAGS-instead-of-3.15.patch | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 package/ninja/0002-use-cmake-3.10-conform-COMPILE_FLAGS-instead-of-3.15.patch
package/ninja/0002-use-cmake-3.10-conform-COMPILE_FLAGS-instead-of-3.15.patch new file +40 -0
@@ -0,0 +1,40 @@ +From 80c34cb11c093f3f0c4217ecf078a1a626da50bd Mon Sep 17 00:00:00 2001 +From: Peter Seiderer <[email protected]> +Date: Thu, 10 Dec 2020 20:29:19 +0100 +Subject: [PATCH] use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 + INCLUDE_DIRECTORIES property + +Use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 INCLUDE_DIRECTORIES +property (as this one is unknown/unused for older cmake versions and +has no effect, resuling in a build failure because of missing extra +include path). + +Fixes: + + [ 96%] Building CXX object CMakeFiles/ninja.dir/src/browse.cc.o + .../build/host-ninja-1.10.2/src/browse.cc:23:10: fatal error: build/browse_py.h: No such file or directory + 23 | #include "build/browse_py.h" + | ^~~~~~~~~~~~~~~~~~~ + compilation terminated. + +Signed-off-by: Peter Seiderer <[email protected]> +--- + CMakeLists.txt | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 7f03c35..f582d2f 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -156,7 +156,7 @@ if(platform_supports_ninja_browse) + set_source_files_properties(src/browse.cc + PROPERTIES + OBJECT_DEPENDS "${CMAKE_BINARY_DIR}/build/browse_py.h" +- INCLUDE_DIRECTORIES "${CMAKE_BINARY_DIR}" ++ COMPILE_FLAGS "-I${CMAKE_BINARY_DIR}" + COMPILE_DEFINITIONS NINJA_PYTHON="python" + ) + endif() +-- +2.29.2 +
Signature · 1 line
2.29.2
PATCH v3 1/1 package/ninja: fix to be cmake-3.10 compatible again
Hi Peter,
Le 12/12/2020 ? 21:54, Peter Seiderer a ?crit?:
Quoted 11 lines
Use cmake-3.10 conform
COMPILE_FLAGSinstead of 3.15INCLUDE_DIRECTORIESproperty (as this one is unknown/unused for older cmake versions and has no effect, resuling in a build failure because of missing extra include path).Fixes:
- http://lists.busybox.net/pipermail/buildroot/2020-December/298159.html
[ 96%] Building CXX object
CMakeFiles/ninja.dir/src/browse.cc.o.../build/host-ninja-1.10.2/src/browse.cc:23:10: fatal error:build/browse_py.h: No such file or directory
Quoted 7 lines
23 | #include "build/browse_py.h" | ^~~~~~~~~~~~~~~~~~~compilation terminated.
Reported-by Yegor Yefremov <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Reviewed-by Yegor Yefremov <[email protected]>
Regards,
Philippe
Quoted 59 lines
---
Changes v1 -> v2:
- really useCOMPILE_FLAGS(as the patch subject says) (suggested by Yegor Yefremov)Changes v2 -> v3:
- add reported-by, reviewed-by Yegor Yefremov
- update commit description--- ...onform-COMPILE_FLAGS-instead-of-3.15.patch | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+)create mode 100644
package/ninja/0002-use-cmake-3.10-conform-COMPILE_FLAGS-instead-of-3.15.patchpackage/ninja/0002-use-cmake-3.10-conform-COMPILE_FLAGS-instead-of-3.15.patch new file +40
-0@@ -0,0 +1,40 @@ +From 80c34cb11c093f3f0c4217ecf078a1a626da50bd Mon Sep 17 00:00:00 2001 +From: Peter Seiderer <[email protected]> +Date: Thu, 10 Dec 2020 20:29:19 +0100 +Subject: [PATCH] use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 + INCLUDE_DIRECTORIES property + +Use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 INCLUDE_DIRECTORIES +property (as this one is unknown/unused for older cmake versions and +has no effect, resuling in a build failure because of missing extra +include path). + +Fixes: + + [ 96%] Building CXX object CMakeFiles/ninja.dir/src/browse.cc.o + .../build/host-ninja-1.10.2/src/browse.cc:23:10: fatal error: build/browse_py.h: No such file or directory + 23 | #include "build/browse_py.h" + | ^~~~~~~~~~~~~~~~~~~ + compilation terminated. + +Signed-off-by: Peter Seiderer <[email protected]> +--- + CMakeLists.txt | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 7f03c35..f582d2f 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -156,7 +156,7 @@ if(platform_supports_ninja_browse) + set_source_files_properties(src/browse.cc + PROPERTIES + OBJECT_DEPENDS "${CMAKE_BINARY_DIR}/build/browse_py.h" +- INCLUDE_DIRECTORIES "${CMAKE_BINARY_DIR}" ++ COMPILE_FLAGS "-I${CMAKE_BINARY_DIR}" + COMPILE_DEFINITIONS NINJA_PYTHON="python" + ) + endif() +-- +2.29.2 +
PATCH 1/1 package/go: enable ARMv7 optimizations for ARMv8 target
In reply to Peter SeidererPeter, All,
On 2020-12-12 21:54 +0100, Peter Seiderer spake thusly:
Quoted 11 lines
Use cmake-3.10 conform
COMPILE_FLAGSinstead of 3.15INCLUDE_DIRECTORIESproperty (as this one is unknown/unused for older cmake versions and has no effect, resuling in a build failure because of missing extra include path).Fixes:
- http://lists.busybox.net/pipermail/buildroot/2020-December/298159.html
[ 96%] Building CXX object
CMakeFiles/ninja.dir/src/browse.cc.o.../build/host-ninja-1.10.2/src/browse.cc:23:10: fatal error:build/browse_py.h: No such file or directory
Quoted 7 lines
23 | #include "build/browse_py.h" | ^~~~~~~~~~~~~~~~~~~compilation terminated.
Reported-by Yegor Yefremov <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Reviewed-by Yegor Yefremov <[email protected]>
Thanks for the patch and the reviews and tests.
However, I've applied another patch that bumps our requirements over up to cmake-3.15, as more and more packages are going to switch to it. Since we already have two patches to allow ninja to build back to cmake-3.10, I don't think it makes sense to add a third patch, especially since a newer cmake is anyway required for other packages...
Regards,
Yann E. MORIN.
Quoted 66 lines
---
Changes v1 -> v2:
- really useCOMPILE_FLAGS(as the patch subject says) (suggested by Yegor Yefremov)Changes v2 -> v3:
- add reported-by, reviewed-by Yegor Yefremov
- update commit description--- ...onform-COMPILE_FLAGS-instead-of-3.15.patch | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 package/ninja/0002-use-cmake-3.10-conform-COMPILE_FLAGS-instead-of-3.15.patchpackage/ninja/0002-use-cmake-3.10-conform-COMPILE_FLAGS-instead-of-3.15.patch new file +40
-0@@ -0,0 +1,40 @@ +From 80c34cb11c093f3f0c4217ecf078a1a626da50bd Mon Sep 17 00:00:00 2001 +From: Peter Seiderer <[email protected]> +Date: Thu, 10 Dec 2020 20:29:19 +0100 +Subject: [PATCH] use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 + INCLUDE_DIRECTORIES property + +Use cmake-3.10 conform COMPILE_FLAGS instead of 3.15 INCLUDE_DIRECTORIES +property (as this one is unknown/unused for older cmake versions and +has no effect, resuling in a build failure because of missing extra +include path). + +Fixes: + + [ 96%] Building CXX object CMakeFiles/ninja.dir/src/browse.cc.o + .../build/host-ninja-1.10.2/src/browse.cc:23:10: fatal error: build/browse_py.h: No such file or directory + 23 | #include "build/browse_py.h" + | ^~~~~~~~~~~~~~~~~~~ + compilation terminated. + +Signed-off-by: Peter Seiderer <[email protected]> +--- + CMakeLists.txt | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 7f03c35..f582d2f 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -156,7 +156,7 @@ if(platform_supports_ninja_browse) + set_source_files_properties(src/browse.cc + PROPERTIES + OBJECT_DEPENDS "${CMAKE_BINARY_DIR}/build/browse_py.h" +- INCLUDE_DIRECTORIES "${CMAKE_BINARY_DIR}" ++ COMPILE_FLAGS "-I${CMAKE_BINARY_DIR}" + COMPILE_DEFINITIONS NINJA_PYTHON="python" + ) + endif() +-- +2.29.2 +Signature · 6 lines
2.29.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'