Skip to contentSkip to conversation

trusted-firmware-a: Update SRCREV to pick latest

PATCH Superseded praneeth 4 participants 14 messages Dec 12, 2020 – Dec 15, 2020

lore
Share & tools
lore

praneeth

author
#0 lore raw

PATCH 1/1 trusted-firmware-a: Update SRCREV to pick latest

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

---
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +1 -1
index 3ca4a204..7821ed3a 100644
@@ -2,7 +2,7 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
Signature · 1 line
2.17.1
#1 lore raw

Hi Praneeth,

Quoted 3 lines · On 12/12/20 3:23 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

This by itself will not be enough for AM64, but that can be an add-on patch. Need to account for TARGET_BOARD=lite for AM64x.

regards
Suman

Quoted 20 lines
---
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +1 -1
index 3ca4a204..7821ed3a 100644
@@ -2,7 +2,7 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
#2 lore raw

Hello

Quoted 8 lines · Suman Anna

Hi Praneeth,

Quoted 3 lines · On 12/12/20 3:23 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

This by itself will not be enough for AM64, but that can be an add-on patch. Need to account for TARGET_BOARD=lite for AM64x.

Is this something that needs to be added to the recipe.  To be honest I have not yet reviewed the ATF patches to know

Dan

author
#3 lore raw

PATCH v2 1/1 trusted-firmware-a: Update SRCREV to pick latest

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

---
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +2 -1
index 4942bf46..39ef1171 100644
@@ -2,11 +2,12 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
 TFA_SPD_k3 = "opteed"
+TFA_BOARD_am64xx-evm = "lite"
 
 do_compile_append_am65xx-hs-evm() {
 	export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
Signature · 1 line
2.17.1
#4 lore raw

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Dan

author
#5 lore raw
Quoted 8 lines · Dan Murphy

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Thats the new target name for AM64

Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123

TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc

Quoted 3 lines

Dan

#6 lore raw

Praneeth

Quoted 12 lines · Praneeth
Quoted 8 lines · Dan Murphy

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Quoted 9 lines

Thats the new target name for AM64

Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123

TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc

Thanks.  Now if we can just get that in the commit message except for the URL target

Dan

author
#7 lore raw

PATCH v3 1/1 trusted-firmware-a: Update SRCREV for AM64X support

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64X support

commit 65dd16b4e ("ti: k3: Introduce lite device board support") adds support of AM64X platform in ti-atf branch.

This patch updates the SRCREV and also updates the BOARD to "lite" to build for the mentioned platform.

---
Changes since V2:
- Update commit message adding more details on new platform

Changes since V1:
- Update TFA_BOARD target name for AM64 as "lite"

 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +2 -1
index 3ca4a204..a7ca43c3 100644
@@ -2,11 +2,12 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
 TFA_SPD_k3 = "opteed"
+TFA_BOARD_am64xx-evm = "lite"
 
 do_compile_append_am65xx-hs-evm() {
 	export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
Signature · 1 line
2.17.1
author
#8 lore raw

PATCH v4 1/1 trusted-firmware-a: Update SRCREV for AM64X support

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64X support

commit 65dd16b4e ("ti: k3: Introduce lite device board support") adds support of AM64X platform in ti-atf branch.

This patch updates the SRCREV and also updates the BOARD to "lite" to build for the mentioned platform.

---
Changes since V3:
- moved TFA_BOARD definition to am64xx.inc

Changes since V2:
- Update commit message adding more details on new platform

Changes since V1:
- Update TFA_BOARD target name for AM64 as "lite"

 conf/machine/include/am64xx.inc                              | 1 +
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
conf/machine/include/am64xx.inc +1 -0
index 79a403a9..99d573e8 100644
@@ -12,6 +12,7 @@ KERNEL_DEVICETREE = " \
 
 #IMAGE_BOOT_FILES += "sysfw-am64x-evm.itb"
 
+TFA_BOARD_am64xx-evm = "lite"
 OPTEEMACHINE = "k3-am65x"
 OPTEEOUTPUTMACHINE = "k3"
 
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +1 -1
index 4942bf46..4852c560 100644
@@ -2,7 +2,7 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
Signature · 1 line
2.17.1
#9 lore raw

Re: [dunfell/master PATCH V4] trusted-firmware-a: Update SRCREV for AM64X support

Quoted 30 lines · On Tue, Dec 15, 2020 at 04:20:29PM -0600, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64X support

commit 65dd16b4e ("ti: k3: Introduce lite device board support") adds support of AM64X platform in ti-atf branch.

This patch updates the SRCREV and also updates the BOARD to "lite" to build for the mentioned platform.

---
Changes since V3:
- moved TFA_BOARD definition to am64xx.inc

Changes since V2:
- Update commit message adding more details on new platform

Changes since V1:
- Update TFA_BOARD target name for AM64 as "lite"

 conf/machine/include/am64xx.inc                              | 1 +
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
conf/machine/include/am64xx.inc +0 -0
index 79a403a9..99d573e8 100644

conf/machine/include/am64xx.inc KERNEL_DEVICETREE = " \ · line 15

Quoted 4 lines
conf/machine/include/am64xx.inc +1 -0
@@ -12,6 +12,7 @@ KERNEL_DEVICETREE = " \
 
 #IMAGE_BOOT_FILES += "sysfw-am64x-evm.itb"
 
+TFA_BOARD_am64xx-evm = "lite"

Copy/paste error - doesn't need a machine override here:

TFA_BOARD = "lite"

Quoted 19 lines
conf/machine/include/am64xx.inc +0 -0
 OPTEEMACHINE = "k3-am65x"
 OPTEEOUTPUTMACHINE = "k3"
 
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +1 -1
index 4942bf46..4852c560 100644
@@ -2,7 +2,7 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
Signature · 1 line
2.17.1
Signature · 4 lines
Regards,
Denys Dmytriyenko <[email protected]>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964
#10 lore raw
In reply to Dan Murphy
Quoted 20 lines · Dan Murphy via lists.yoctoproject.org

Praneeth

Quoted 17 lines · Praneeth
Quoted 8 lines · Dan Murphy

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Thats the new target name for AM64

Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123

Quoted 6 lines
Quoted 4 lines

TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc

Thanks.  Now if we can just get that in the commit message except for the URL target

Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf machine config...

Signature · 1 line
Denys
author
#11 lore raw
Quoted 25 lines · Denys Dmytriyenko
Quoted 24 lines · Dan Murphy via lists.yoctoproject.org

Praneeth

Quoted 21 lines · Praneeth
Quoted 8 lines · Dan Murphy

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Thats the new target name for AM64

Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123

TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc

Quoted 5 lines
Quoted 2 lines

Thanks.  Now if we can just get that in the commit message except for the URL target

Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf machine config...

Can i move it to conf/machine/include/am64xx.inc instead ? please advise.

Will submit v4 accordingly

Quoted 1 line
#12 lore raw

Praneeth

Quoted 31 lines · Praneeth
Quoted 28 lines · Denys Dmytriyenko
Quoted 26 lines · Dan Murphy via lists.yoctoproject.org

Praneeth

Quoted 12 lines · Praneeth
Quoted 8 lines · Dan Murphy

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Quoted 9 lines

Thats the new target name for AM64

Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123

TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc

Thanks.  Now if we can just get that in the commit message except for the URL target

Quoted 7 lines
Quoted 2 lines

Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf machine config...

Can i move it to conf/machine/include/am64xx.inc instead ? please advise.

Will submit v4 accordingly

If it is common for all/any am64 processors then it belong in that include file

Dan

#13 lore raw
In reply to praneeth
Quoted 31 lines · Praneeth
Quoted 28 lines · Denys Dmytriyenko
Quoted 26 lines · Dan Murphy via lists.yoctoproject.org

Praneeth

Quoted 12 lines · Praneeth
Quoted 8 lines · Dan Murphy

Praneeth

Quoted 3 lines · On 12/15/20 2:51 PM, [email protected] wrote:

From: Praneeth Bajjuri <[email protected]>

Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Quoted 9 lines

Thats the new target name for AM64

Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123

TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc

Thanks.  Now if we can just get that in the commit message except for the URL target

Quoted 6 lines
Quoted 2 lines

Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf machine config...

Can i move it to conf/machine/include/am64xx.inc instead ? please advise.

Will submit v4 accordingly

Sure, am64xx.inc should be fine, even better for when/if possible HS or any other variants in the same SoC family come out.

Signature · 1 line
Denys