Skip to contentSkip to conversation

dt-bindings: iio: imu: mpu6050: Document invensense,mpu6880

PATCH In review Stephan Gerhold 4 participants 6 messages Dec 2, 2020 – Dec 13, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: iio: imu: mpu6050: Document invensense,mpu6880

MPU-6880 seems to be very similar to MPU-6500 / MPU-6050 and it works fine with some minor additions for the mpu6050 driver.
Add a compatible for it to the binding documentation.

Cc Jean-Baptiste Maneyrol <[email protected]>

---
Note: This applies only on top of the patch for the YAML conversion:
https://lore.kernel.org/linux-iio/[email protected]/
I guess that one will be applied very soon so I think this is easier :)

Changes in v2: None :)

---
 .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml          | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml +1 -0
index 9268b6ca2afe..edbc2921aabd 100644
@@ -25,6 +25,7 @@ properties:
       - invensense,mpu6050
       - invensense,mpu6500
       - invensense,mpu6515
+      - invensense,mpu6880
       - invensense,mpu9150
       - invensense,mpu9250
       - invensense,mpu9255
Signature · 1 line
2.29.2
#1 lore raw

PATCH v2 2/2 iio: imu: inv_mpu6050: Add support for MPU-6880

MPU-6880 seems to be very similar to MPU-6500 and it works fine with some minor additions for the mpu6050 driver.

Add the necessary defines for it and make it use the same registers as MPU-6500 but with a FIFO size of 4096.

Cc Jean-Baptiste Maneyrol <[email protected]>

---
I tested this on a Xiaomi Redmi 2 (or Wingtech WT88047).

Changes in v2:
- Mention support for MPU-6880 in Kconfig

---
 drivers/iio/imu/inv_mpu6050/Kconfig        | 8 ++++----
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 9 +++++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c  | 5 +++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h  | 2 ++
 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c  | 5 +++++
 5 files changed, 25 insertions(+), 4 deletions(-)
drivers/iio/imu/inv_mpu6050/Kconfig +4 -4
index 7137ea6f25db..9c625517173a 100644
@@ -16,8 +16,8 @@ config INV_MPU6050_I2C
 	select REGMAP_I2C
 	help
 	  This driver supports the Invensense MPU6050/9150,
-	  MPU6500/6515/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690 and
-	  IAM20680 motion tracking devices over I2C.
+	  MPU6500/6515/6880/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690
+	  and IAM20680 motion tracking devices over I2C.
 	  This driver can be built as a module. The module will be called
 	  inv-mpu6050-i2c.
 
@@ -28,7 +28,7 @@ config INV_MPU6050_SPI
 	select REGMAP_SPI
 	help
 	  This driver supports the Invensense MPU6000,
-	  MPU6500/6515/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690 and
-	  IAM20680 motion tracking devices over SPI.
+	  MPU6500/6515/6880/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690
+	  and IAM20680 motion tracking devices over SPI.
 	  This driver can be built as a module. The module will be called
 	  inv-mpu6050-spi.
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +9 -0
index 18a1898e3e34..453c51c79655 100644
@@ -160,6 +160,14 @@ static const struct inv_mpu6050_hw hw_info[] = {
 		.fifo_size = 512,
 		.temp = {INV_MPU6500_TEMP_OFFSET, INV_MPU6500_TEMP_SCALE},
 	},
+	{
+		.whoami = INV_MPU6880_WHOAMI_VALUE,
+		.name = "MPU6880",
+		.reg = &reg_set_6500,
+		.config = &chip_config_6500,
+		.fifo_size = 4096,
+		.temp = {INV_MPU6500_TEMP_OFFSET, INV_MPU6500_TEMP_SCALE},
+	},
 	{
 		.whoami = INV_MPU6000_WHOAMI_VALUE,
 		.name = "MPU6000",
@@ -1323,6 +1331,7 @@ static int inv_check_and_setup_chip(struct inv_mpu6050_state *st)
 	case INV_MPU6000:
 	case INV_MPU6500:
 	case INV_MPU6515:
+	case INV_MPU6880:
 	case INV_MPU9250:
 	case INV_MPU9255:
 		/* reset signal path (required for spi connection) */
drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c +5 -0
index 28cfae1e61cf..95f16951c8f4 100644
@@ -177,6 +177,7 @@ static const struct i2c_device_id inv_mpu_id[] = {
 	{"mpu6050", INV_MPU6050},
 	{"mpu6500", INV_MPU6500},
 	{"mpu6515", INV_MPU6515},
+	{"mpu6880", INV_MPU6880},
 	{"mpu9150", INV_MPU9150},
 	{"mpu9250", INV_MPU9250},
 	{"mpu9255", INV_MPU9255},
@@ -204,6 +205,10 @@ static const struct of_device_id inv_of_match[] = {
 		.compatible = "invensense,mpu6515",
 		.data = (void *)INV_MPU6515
 	},
+	{
+		.compatible = "invensense,mpu6880",
+		.data = (void *)INV_MPU6880
+	},
 	{
 		.compatible = "invensense,mpu9150",
 		.data = (void *)INV_MPU9150
drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +2 -0
index eb522b38acf3..58188dc0dd13 100644
@@ -70,6 +70,7 @@ enum inv_devices {
 	INV_MPU6050,
 	INV_MPU6500,
 	INV_MPU6515,
+	INV_MPU6880,
 	INV_MPU6000,
 	INV_MPU9150,
 	INV_MPU9250,
@@ -373,6 +374,7 @@ struct inv_mpu6050_state {
 #define INV_MPU6000_WHOAMI_VALUE		0x68
 #define INV_MPU6050_WHOAMI_VALUE		0x68
 #define INV_MPU6500_WHOAMI_VALUE		0x70
+#define INV_MPU6880_WHOAMI_VALUE		0x78
 #define INV_MPU9150_WHOAMI_VALUE		0x68
 #define INV_MPU9250_WHOAMI_VALUE		0x71
 #define INV_MPU9255_WHOAMI_VALUE		0x73
drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c +5 -0
index 6f968ce687e1..b056f3fe2561 100644
@@ -70,6 +70,7 @@ static const struct spi_device_id inv_mpu_id[] = {
 	{"mpu6000", INV_MPU6000},
 	{"mpu6500", INV_MPU6500},
 	{"mpu6515", INV_MPU6515},
+	{"mpu6880", INV_MPU6880},
 	{"mpu9250", INV_MPU9250},
 	{"mpu9255", INV_MPU9255},
 	{"icm20608", INV_ICM20608},
@@ -96,6 +97,10 @@ static const struct of_device_id inv_of_match[] = {
 		.compatible = "invensense,mpu6515",
 		.data = (void *)INV_MPU6515
 	},
+	{
+		.compatible = "invensense,mpu6880",
+		.data = (void *)INV_MPU6880
+	},
 	{
 		.compatible = "invensense,mpu9250",
 		.data = (void *)INV_MPU9250
Signature · 1 line
2.29.2
Acked-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] iio: imu: inv_mpu6050: Add support for MPU-6880

Perfect, thanks.

From: Stephan Gerhold <[email protected]>
Sent: Wednesday, December 2, 2020 11:46
To: Jonathan Cameron <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Jean-Baptiste Maneyrol <[email protected]>; Stephan Gerhold <[email protected]>
Subject: [PATCH v2 2/2] iio: imu: inv_mpu6050: Add support for MPU-6880

 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.

MPU-6880 seems to be very similar to MPU-6500 and it works fine with some minor additions for the mpu6050 driver.

Add the necessary defines for it and make it use the same registers as MPU-6500 but with a FIFO size of 4096.

Cc Jean-Baptiste Maneyrol <[email protected]>

---
I tested this on a Xiaomi Redmi 2 (or Wingtech WT88047).

Changes in v2:
  - Mention support for MPU-6880 in Kconfig
---
 drivers/iio/imu/inv_mpu6050/Kconfig        | 8 ++++---- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 9 +++++++++

 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c  | 5 +++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h  | 2 ++
 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c  | 5 +++++
 5 files changed, 25 insertions(+), 4 deletions(-)
drivers/iio/imu/inv_mpu6050/Kconfig +0 -0
index 7137ea6f25db..9c625517173a 100644
@@ -16,8 +16,8 @@ config INV_MPU6050_I2C

         select REGMAP_I2C
         help
           This driver supports the Invensense MPU6050/9150,
-         MPU6500/6515/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690 and -         IAM20680 motion tracking devices over I2C.
+         MPU6500/6515/6880/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690 +         and IAM20680 motion tracking devices over I2C.
           This driver can be built as a module. The module will be called inv-mpu6050-i2c.

@@ -28,7 +28,7 @@ config INV_MPU6050_SPI
         select REGMAP_SPI
         help
           This driver supports the Invensense MPU6000,
-         MPU6500/6515/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690 and -         IAM20680 motion tracking devices over SPI.
+         MPU6500/6515/6880/9250/9255, ICM20608/20609/20689, ICM20602/ICM20690 +         and IAM20680 motion tracking devices over SPI.
           This driver can be built as a module. The module will be called inv-mpu6050-spi.

drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +0 -0
index 18a1898e3e34..453c51c79655 100644
@@ -160,6 +160,14 @@ static const struct inv_mpu6050_hw hw_info[] = {

                 .fifo_size = 512,
                 .temp = {INV_MPU6500_TEMP_OFFSET, INV_MPU6500_TEMP_SCALE}, },
+       {
+               .whoami = INV_MPU6880_WHOAMI_VALUE,
+               .name = "MPU6880",
+               .reg = &reg_set_6500,
+               .config = &chip_config_6500,
+               .fifo_size = 4096,
+               .temp = {INV_MPU6500_TEMP_OFFSET, INV_MPU6500_TEMP_SCALE}, +       },
         {
                 .whoami = INV_MPU6000_WHOAMI_VALUE,
                 .name = "MPU6000",
@@ -1323,6 +1331,7 @@ static int inv_check_and_setup_chip(struct inv_mpu6050_state *st) case INV_MPU6000:
         case INV_MPU6500:
         case INV_MPU6515:
+       case INV_MPU6880:
         case INV_MPU9250:
         case INV_MPU9255:
                 /* reset signal path (required for spi connection) */

drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c +0 -0
index 28cfae1e61cf..95f16951c8f4 100644
@@ -177,6 +177,7 @@ static const struct i2c_device_id inv_mpu_id[] = {

         {"mpu6050", INV_MPU6050},
         {"mpu6500", INV_MPU6500},
         {"mpu6515", INV_MPU6515},
+       {"mpu6880", INV_MPU6880},
         {"mpu9150", INV_MPU9150},
         {"mpu9250", INV_MPU9250},
         {"mpu9255", INV_MPU9255},
@@ -204,6 +205,10 @@ static const struct of_device_id inv_of_match[] = { .compatible = "invensense,mpu6515",
                 .data = (void *)INV_MPU6515
         },
+       {
+               .compatible = "invensense,mpu6880",
+               .data = (void *)INV_MPU6880
+       },
         {
                 .compatible = "invensense,mpu9150",
                 .data = (void *)INV_MPU9150

drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +0 -0
index eb522b38acf3..58188dc0dd13 100644
@@ -70,6 +70,7 @@ enum inv_devices {

         INV_MPU6050,
         INV_MPU6500,
         INV_MPU6515,
+       INV_MPU6880,
         INV_MPU6000,
         INV_MPU9150,
         INV_MPU9250,
@@ -373,6 +374,7 @@ struct inv_mpu6050_state { #define INV_MPU6000_WHOAMI_VALUE                0x68 #define INV_MPU6050_WHOAMI_VALUE                0x68 #define INV_MPU6500_WHOAMI_VALUE                0x70 +#define INV_MPU6880_WHOAMI_VALUE               0x78 #define INV_MPU9150_WHOAMI_VALUE                0x68 #define INV_MPU9250_WHOAMI_VALUE                0x71 #define INV_MPU9255_WHOAMI_VALUE                0x73

drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c +0 -0
index 6f968ce687e1..b056f3fe2561 100644
@@ -70,6 +70,7 @@ static const struct spi_device_id inv_mpu_id[] = {

         {"mpu6000", INV_MPU6000},
         {"mpu6500", INV_MPU6500},
         {"mpu6515", INV_MPU6515},
+       {"mpu6880", INV_MPU6880},
         {"mpu9250", INV_MPU9250},
         {"mpu9255", INV_MPU9255},
         {"icm20608", INV_ICM20608},
@@ -96,6 +97,10 @@ static const struct of_device_id inv_of_match[] = { .compatible = "invensense,mpu6515",
                 .data = (void *)INV_MPU6515
         },
+       {
+               .compatible = "invensense,mpu6880",
+               .data = (void *)INV_MPU6880
+       },
         {
                 .compatible = "invensense,mpu9250",
                 .data = (void *)INV_MPU9250

Signature · 1 line
2.29.2
Acked-by on v2 1/2
#3 lore raw
In reply to Stephan Gerhold

Perfect, thanks.

From: Stephan Gerhold <[email protected]>
Sent: Wednesday, December 2, 2020 11:46
To: Jonathan Cameron <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Jean-Baptiste Maneyrol <[email protected]>; Stephan Gerhold <[email protected]>
Subject: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Document invensense,mpu6880

 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.

MPU-6880 seems to be very similar to MPU-6500 / MPU-6050 and it works fine with some minor additions for the mpu6050 driver.
Add a compatible for it to the binding documentation.

Cc Jean-Baptiste Maneyrol <[email protected]>

---
Note: This applies only on top of the patch for the YAML conversion:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_linux-2Diio_20201128173343.390165-2D3-2Djic23-40kernel.org_&d=DwIDAg&c=WoJWtq5JV8YrKnzRxvD8NxmTP_1wxfE0prPmo0NeZwg&r=4jiDX_1brsSWfCjfA6Ovj1d4h9MF8q7Xk5aBwG28mVk&m=7Gw_jalJwa1D4BnMzg_LfHmFCU9XHw85vFukmE0KiPM&s=wl10XQo2t0i1smI63VAGI6SEpE9866BnfB1CDdyDRAc&e=
I guess that one will be applied very soon so I think this is easier :)

Changes in v2: None :)
---
 .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml          | 1 +

 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml +0 -0
index 9268b6ca2afe..edbc2921aabd 100644
@@ -25,6 +25,7 @@ properties:

       - invensense,mpu6050
       - invensense,mpu6500
       - invensense,mpu6515
+      - invensense,mpu6880
       - invensense,mpu9150
       - invensense,mpu9250
       - invensense,mpu9255

Signature · 1 line
2.29.2
maintainer Acked-by on v2 1/2
#4 lore raw
In reply to Stephan Gerhold
Quoted 11 lines · Stephan Gerhold

MPU-6880 seems to be very similar to MPU-6500 / MPU-6050 and it works fine with some minor additions for the mpu6050 driver.
Add a compatible for it to the binding documentation.

Cc Jean-Baptiste Maneyrol <[email protected]>

---
Note: This applies only on top of the patch for the YAML conversion:
https://lore.kernel.org/linux-iio/[email protected]/
I guess that one will be applied very soon so I think this is easier :)

Quoted 5 lines

Changes in v2: None :)

---
 .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml          | 1 +
 1 file changed, 1 insertion(+)
maintainer
#5 lore raw
Quoted 12 lines · On Wed, 9 Dec 2020 13:59:32 -0600 Rob Herring <[email protected]> wrote:
Quoted 11 lines · Stephan Gerhold

MPU-6880 seems to be very similar to MPU-6500 / MPU-6050 and it works fine with some minor additions for the mpu6050 driver.
Add a compatible for it to the binding documentation.

Cc Jean-Baptiste Maneyrol <[email protected]>

---
Note: This applies only on top of the patch for the YAML conversion:
https://lore.kernel.org/linux-iio/[email protected]/
I guess that one will be applied very soon so I think this is easier :)

Quoted 7 lines
Quoted 5 lines

Changes in v2: None :)

---
 .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml          | 1 +
 1 file changed, 1 insertion(+)

Series applied to the togreg branch of iio.git and pushed out as testing to see if the autobuilders find anything interesting.

Thanks,

Jonathan