Skip to contentSkip to conversation

remoteproc/mediatek: enable MPU for all memory regions in MT8192 SCP

PATCH Superseded Tzung-Bi Shih 2 participants 2 messages Dec 14, 2020 – Jan 6, 2021

Subsystems (2)
Arm MediaTek Remote processor (remoteproc)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tzung-Bi Shih

author
#0 lore raw

PATCH 1/1 remoteproc/mediatek: enable MPU for all memory regions in MT8192 SCP

Enables MPU for all memory regions in MT8192 SCP.

Signed-off-by Tzung-Bi Shih <[email protected]>
---
 drivers/remoteproc/mtk_common.h | 1 +
 drivers/remoteproc/mtk_scp.c    | 3 +++
 2 files changed, 4 insertions(+)
drivers/remoteproc/mtk_common.h +1 -0
index 94bc54b224ee..5f7cd2336cef 100644
@@ -47,6 +47,7 @@
 
 #define MT8192_CORE0_SW_RSTN_CLR	0x10000
 #define MT8192_CORE0_SW_RSTN_SET	0x10004
+#define MT8192_CORE0_MEM_ATT_PREDEF	0x10008
 #define MT8192_CORE0_WDT_CFG		0x10034
 
 #define SCP_FW_VER_LEN			32
drivers/remoteproc/mtk_scp.c +3 -0
index f025aba67abc..130c0b9511df 100644
@@ -369,6 +369,9 @@ static int mt8192_scp_before_load(struct mtk_scp *scp)
 	mt8192_power_on_sram(scp->reg_base + MT8192_L1TCM_SRAM_PDN);
 	mt8192_power_on_sram(scp->reg_base + MT8192_CPU0_SRAM_PD);
 
+	/* enable MPU for all memory regions */
+	writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF);
+
 	return 0;
 }
Signature · 7 lines
2.29.2.684.gfbc64c5ab5-goog


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer
#1 lore raw
Quoted 1 line · Tzung-Bi Shih

Enables MPU for all memory regions in MT8192 SCP.

Ok but how was it working before this patch? Why is this suddently needed? A changelog that explains all this would certainly be appreciated.

Thanks,
Mathieu

Quoted 36 lines
Signed-off-by Tzung-Bi Shih <[email protected]>
---
 drivers/remoteproc/mtk_common.h | 1 +
 drivers/remoteproc/mtk_scp.c    | 3 +++
 2 files changed, 4 insertions(+)
drivers/remoteproc/mtk_common.h +1 -0
index 94bc54b224ee..5f7cd2336cef 100644
@@ -47,6 +47,7 @@
 
 #define MT8192_CORE0_SW_RSTN_CLR	0x10000
 #define MT8192_CORE0_SW_RSTN_SET	0x10004
+#define MT8192_CORE0_MEM_ATT_PREDEF	0x10008
 #define MT8192_CORE0_WDT_CFG		0x10034
 
 #define SCP_FW_VER_LEN			32
drivers/remoteproc/mtk_scp.c +3 -0
index f025aba67abc..130c0b9511df 100644
@@ -369,6 +369,9 @@ static int mt8192_scp_before_load(struct mtk_scp *scp)
 	mt8192_power_on_sram(scp->reg_base + MT8192_L1TCM_SRAM_PDN);
 	mt8192_power_on_sram(scp->reg_base + MT8192_CPU0_SRAM_PD);
 
+	/* enable MPU for all memory regions */
+	writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF);
+
 	return 0;
 }
Signature · 1 line
2.29.2.684.gfbc64c5ab5-goog

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek