BPi M2 Zero poweroff support via new regulator-poweroff driver
v5 cover BPi M2 Zero poweroff support via new regulator-poweroff driver
Changes in v2:
- rename DT node
Changes in v3:
- add regulator-poweroff driver
- use regulator-poweroff driver instead of gpio-poweroff
Changes in v4:
- hardcode poweroff timeout to 3000ms, not configurable any more
- remove support for multiple regulators
- fix Documentation issues
Changes in v5:
- rename DT property 'power-supply' -> 'cpu-supply'
Michael Klein (3):
power: reset: new driver regulator-poweroff
Documentation: DT: binding documentation for regulator-poweroff
ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node
.../power/reset/regulator-poweroff.yaml | 37 +++++++++ .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 ++ drivers/power/reset/Kconfig | 7 ++ drivers/power/reset/Makefile | 1 + drivers/power/reset/regulator-poweroff.c | 82 +++++++++++++++++++ 5 files changed, 132 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml create mode 100644 drivers/power/reset/regulator-poweroff.c
Signature · 7 lines
2.29.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v5 1/3 power: reset: new driver regulator-poweroff
This driver registers a pm_power_off function to turn off the board by force-disabling a devicetree-defined regulator.
--- drivers/power/reset/Kconfig | 7 ++ drivers/power/reset/Makefile | 1 + drivers/power/reset/regulator-poweroff.c | 82 ++++++++++++++++++++++++ 3 files changed, 90 insertions(+) create mode 100644 drivers/power/reset/regulator-poweroff.c
drivers/power/reset/Kconfig +7 -0
@@ -177,6 +177,13 @@ config POWER_RESET_QNAP Say Y if you have a QNAP NAS. +config POWER_RESET_REGULATOR + bool "Regulator subsystem power-off driver" + depends on OF && REGULATOR + help + This driver supports turning off your board by disabling a + power regulator defined in the devicetree. + config POWER_RESET_RESTART bool "Restart power-off driver" help
drivers/power/reset/Makefile +1 -0
@@ -19,6 +19,7 @@ obj-$(CONFIG_POWER_RESET_OCELOT_RESET) += ocelot-reset.o obj-$(CONFIG_POWER_RESET_PIIX4_POWEROFF) += piix4-poweroff.o obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o +obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o obj-$(CONFIG_POWER_RESET_VERSATILE) += arm-versatile-reboot.o
drivers/power/reset/regulator-poweroff.c new file +82 -0
82 lines not on this page · raw message
Signature · 7 lines
2.29.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sebastian Reichel
maintainerRe: [PATCH v5 1/3] power: reset: new driver regulator-poweroff
Hi,
Quoted 5 lines · Michael Klein
This driver registers a
pm_power_offfunction to turn off the board by force-disabling a devicetree-defined regulator.Signed-off-by Michael Klein <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 132 lines
drivers/power/reset/Kconfig | 7 ++ drivers/power/reset/Makefile | 1 + drivers/power/reset/regulator-poweroff.c | 82 ++++++++++++++++++++++++ 3 files changed, 90 insertions(+) create mode 100644 drivers/power/reset/regulator-poweroff.cdrivers/power/reset/Kconfig +7
-0@@ -177,6 +177,13 @@ config POWER_RESET_QNAP Say Y if you have a QNAP NAS. +config POWER_RESET_REGULATOR + bool "Regulator subsystem power-off driver" + depends on OF && REGULATOR + help + This driver supports turning off your board by disabling a + power regulator defined in the devicetree. + config POWER_RESET_RESTART bool "Restart power-off driver" helpdrivers/power/reset/Makefile +1
-0@@ -19,6 +19,7 @@ obj-$(CONFIG_POWER_RESET_OCELOT_RESET) += ocelot-reset.o obj-$(CONFIG_POWER_RESET_PIIX4_POWEROFF) += piix4-poweroff.o obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o +obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o obj-$(CONFIG_POWER_RESET_VERSATILE) += arm-versatile-reboot.odrivers/power/reset/regulator-poweroff.c new file +82
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Force-disables a regulator to power down a device +* +* Michael Klein <[email protected]> +* +* Copyright (C) 2020 Michael Klein +* +* Based on the gpio-poweroff driver. +*/ +#include <linux/delay.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/pm.h> +#include <linux/regulator/consumer.h> + +#define TIMEOUT_MS 3000 + +/* +* Hold configuration here, cannot be more than one instance of the driver +* since pm_power_off itself is global. +*/ +static struct regulator *cpu_regulator; + +static void regulator_poweroff_do_poweroff (void ) +{ +if (cpu_regulator &®ulator_is_enabled (cpu_regulator)) +regulator_force_disable (cpu_regulator); + +/* give it some time */ +mdelay (TIMEOUT_MS ); + +WARN_ON (1 ); +} + +static int regulator_poweroff_probe (struct platform_device *pdev) +{ +/* If a pm_power_off function has already been added, leave it alone */ +if (pm_power_off !=NULL ) { +dev_err (&pdev->dev, +"%s: pm_power_off function already registered\n" , + __func__); +return -EBUSY ; + } + + cpu_regulator =devm_regulator_get (&pdev->dev,"cpu" ); +if (IS_ERR (cpu_regulator)) +return PTR_ERR (cpu_regulator); + + pm_power_off = ®ulator_poweroff_do_poweroff; +return 0 ; +} + +static int regulator_poweroff_remove (__maybe_unused struct platform_device *pdev) +{ +if (pm_power_off == ®ulator_poweroff_do_poweroff) + pm_power_off =NULL ; + +return 0 ; +} + +static const struct of_device_id of_regulator_poweroff_match[] = { + { .compatible ="regulator-poweroff" , }, + {}, +}; + +static struct platform_driver regulator_poweroff_driver = { + .probe = regulator_poweroff_probe, + .remove = regulator_poweroff_remove, + .driver = { + .name ="poweroff-regulator" , + .of_match_table = of_regulator_poweroff_match, + }, +}; + +module_platform_driver (regulator_poweroff_driver); + +MODULE_AUTHOR ("Michael Klein <[email protected]>" ); +MODULE_DESCRIPTION ("Regulator poweroff driver" ); +MODULE_LICENSE ("GPL v2" ); +MODULE_ALIAS ("platform:poweroff-regulator" );Signature · 7 lines
2.29.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v5 1/3] power: reset: new driver regulator-poweroff
Hi Sebastian,
Quoted 10 lines · Sebastian Reichel
Hi,
Quoted 5 lines · Michael Klein
This driver registers a
pm_power_offfunction to turn off the board by force-disabling a devicetree-defined regulator.Signed-off-by Michael Klein <[email protected]>---
Thanks, queued.
Did you also merge the binding?
Maxime
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sebastian Reichel
maintainerRe: [PATCH v5 1/3] power: reset: new driver regulator-poweroff
Hi Maxime,
Quoted 9 lines · Maxime Ripard
Hi Sebastian,
Quoted 6 lines · Sebastian Reichel
Hi,
Quoted 3 lines · Michael Klein
This driver registers a
pm_power_offfunction to turn off the board by force-disabling a devicetree-defined regulator.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Michael Klein <[email protected]>---
Thanks, queued.
Did you also merge the binding?
Yes.
-- Sebastian
PATCH v5 2/3 Documentation: DT: binding documentation for regulator-poweroff
In reply to Michael KleinAdd devicetree binding documentation for regulator-poweroff driver.
--- .../power/reset/regulator-poweroff.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml
Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml new file +37 -0
@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/reset/regulator-poweroff.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Force-disable power regulator to turn the power off. + +maintainers: + - Michael Klein <[email protected]> + +description: | + When the power-off handler is called, a power regulator is disabled by + calling regulator_force_disable(). If the power is still on and the + CPU still running after a 3000ms delay, a warning is emitted. + +properties: + compatible: + const: "regulator-poweroff" + + cpu-supply: + description: + regulator to disable on power-down + +required: + - compatible + - cpu-supply + +additionalProperties: false + +examples: + - | + regulator-poweroff { + compatible = "regulator-poweroff"; + cpu-supply = <®_vcc1v2>; + }; +...
Signature · 7 lines
2.29.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v5 2/3] Documentation: DT: binding documentation for regulator-poweroff
Quoted 8 lines · Michael Klein
Add devicetree binding documentation for regulator-poweroff driver.
Signed-off-by Michael Klein <[email protected]>--- .../power/reset/regulator-poweroff.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sebastian Reichel
maintainerRe: [PATCH v5 2/3] Documentation: DT: binding documentation for regulator-poweroff
In reply to Michael KleinHi,
Quoted 4 lines · Michael Klein
Add devicetree binding documentation for regulator-poweroff driver.
Signed-off-by Michael Klein <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 55 lines
.../power/reset/regulator-poweroff.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yamlDocumentation/devicetree/bindings/power/reset/regulator-poweroff.yaml new file +37
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/reset/regulator-poweroff.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Force-disable power regulator to turn the power off. + +maintainers: + - Michael Klein <[email protected]> + +description: | + When the power-off handler is called, a power regulator is disabled by + calling regulator_force_disable(). If the power is still on and the + CPU still running after a 3000ms delay, a warning is emitted. + +properties: + compatible: + const: "regulator-poweroff" + + cpu-supply: + description: + regulator to disable on power-down + +required: + - compatible + - cpu-supply + +additionalProperties: false + +examples: + - | + regulator-poweroff { + compatible = "regulator-poweroff"; + cpu-supply = <®_vcc1v2>; + }; +...Signature · 7 lines
2.29.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v5 3/3 ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node
In reply to Michael KleinAdd add devicetree information for the regulator-poweroff driver.
--- arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts +5 -0
@@ -86,6 +86,11 @@ reg_vcc1v2: vcc1v2 { vin-supply = <®_vcc5v0>; }; + poweroff { + compatible = "regulator-poweroff"; + cpu-supply = <®_vcc1v2>; + }; + wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
Signature · 7 lines
2.29.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Maxime Ripard
AppliedRe: [PATCH v5 3/3] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node
Quoted 3 lines · Michael Klein
Add add devicetree information for the regulator-poweroff driver.
Signed-off-by Michael Klein <[email protected]>
Queued for 5.12, thanks!
Maxime
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel