Skip to contentSkip to conversation

drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.

PATCH New Dan Carpenter 1 participant 1 message Dec 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 39/1142 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   eeb611e5394c56d45c5cc8f7dc484c9f19e93143
commit: 2baf6e1cd6f179dd497cfc10294920e99bc3a66e [39/1142] dmaengine: dw-axi-dma: support slave dma mode
config: i386-randconfig-m021-20201209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'. drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'flags'.

vim +941 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

1fe20f1b84548b Eugeniy Paltsev 2018-03-06  912  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  913  static noinline void axi_chan_handle_err(struct axi_dma_chan *chan, u32 status)
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  914  {
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  915  	struct virt_dma_desc *vd;
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  916  	unsigned long flags;
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  917  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  918  	spin_lock_irqsave(&chan->vc.lock, flags);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  919  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  920  	axi_chan_disable(chan);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  921  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  922  	/* The bad descriptor currently is in the head of vc list */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  923  	vd = vchan_next_desc(&chan->vc);
2baf6e1cd6f179 Sia Jee Heng    2020-06-26  924  	if (!vd)
2baf6e1cd6f179 Sia Jee Heng    2020-06-26  925  		return;
                                                                ^^^^^^^

spin_unlock_irqrestore(&chan->vc.lock, flags);
before returning.

2baf6e1cd6f179 Sia Jee Heng    2020-06-26  926  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  927  	/* Remove the completed descriptor from issued list */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  928  	list_del(&vd->node);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  929  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  930  	/* WARN about bad descriptor */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  931  	dev_err(chan2dev(chan),
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  932  		"Bad descriptor submitted for %s, cookie: %d, irq: 0x%08x\n",
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  933  		axi_chan_name(chan), vd->tx.cookie, status);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  934  	axi_chan_list_dump_lli(chan, vd_to_axi_desc(vd));
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  935  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  936  	vchan_cookie_complete(vd);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  937  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  938  	/* Try to restart the controller */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  939  	axi_chan_start_first_queued(chan);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  940  

1fe20f1b84548b Eugeniy Paltsev 2018-03-06 @941 spin_unlock_irqrestore(&chan->vc.lock, flags);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06 942 }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org