Skip to contentSkip to conversation

cifs: Add missing sentinel to smb3_fs_parameters

PATCH In review Dmitry Osipenko 2 participants 2 messages Dec 14, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: Add missing sentinel to smb3_fs_parameters

Add missing sentinel to smb3_fs_parameters. This fixes ARM32 kernel crashing once CIFS is registered.

 Unable to handle kernel paging request at virtual address 33626d73

...
(strcmp) from (fs_validate_description) (fs_validate_description) from (register_filesystem) (register_filesystem) from (init_cifs [cifs]) (init_cifs [cifs]) from (do_one_initcall) (do_one_initcall) from (do_init_module) (do_init_module) from (load_module) (load_module) from (sys_finit_module) (sys_finit_module) from (ret_fast_syscal)

Fixes e07724d1cf38 ("cifs: switch to new mount api")
---
 fs/cifs/fs_context.c | 1 +
 1 file changed, 1 insertion(+)
fs/cifs/fs_context.c +1 -0
index fe5cc60f4393..c41e87af77b6 100644
@@ -173,6 +173,7 @@ const struct fs_parameter_spec smb3_fs_parameters[] = {
 	fsparam_flag_no("mand", Opt_ignore),
 	fsparam_string("cred", Opt_ignore),
 	fsparam_string("credentials", Opt_ignore),
+	{}
 };
 
 int
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Dmitry Osipenko

Add missing sentinel to smb3_fs_parameters. This fixes ARM32 kernel crashing once CIFS is registered.

Thanks for the fix Dmitry.

Cheers,

Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)