Skip to contentSkip to conversation

virtio-blk: change default config-wce to false

PATCH New Tom Yan 1 participant 1 message Dec 14, 2020

lore
Share & tools
lore

Tom Yan

author
#0 lore raw

PATCH 1/1 virtio-blk: change default config-wce to false

This would allow cache= to be respected when if=virtio is used (instead of -device virtio-blk-pci). Since cache=writeback is the default, this does not cause a change in the default behavior.

Also, when config-wce is true, cache.writeback is still overriden.

---
 hw/block/virtio-blk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/block/virtio-blk.c +1 -1
index bac2d6fa2b..0c2ecd22bc 100644
@@ -1284,7 +1284,7 @@ static Property virtio_blk_properties[] = {
     DEFINE_BLOCK_CHS_PROPERTIES(VirtIOBlock, conf.conf),
     DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
     DEFINE_PROP_BIT64("config-wce", VirtIOBlock, host_features,
-                      VIRTIO_BLK_F_CONFIG_WCE, true),
+                      VIRTIO_BLK_F_CONFIG_WCE, false),
 #ifdef __linux__
     DEFINE_PROP_BIT64("scsi", VirtIOBlock, host_features,
                       VIRTIO_BLK_F_SCSI, false),
Signature · 1 line
2.29.2