Skip to contentSkip to conversation

x86: vmlinux.lds.S: explain link error better when PHYSICAL_START is LARGE

PATCH New Randy Dunlap 1 participant 1 message Dec 15, 2020 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: vmlinux.lds.S: explain link error better when PHYSICAL_START is LARGE

On i386, when CONFIG_PHYSICAL_START is very large, it causes a confusing or misleading linker error message:

ld: kernel image bigger than KERNEL_IMAGE_SIZE

so expand this message to include the possibility that the problem could be due to CONFIG_PHYSICAL_START.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
---
 arch/x86/kernel/vmlinux.lds.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/vmlinux.lds.S +1 -1
@@ -458,7 +458,7 @@ SECTIONS
  * The ASSERT() sink to . is intentional, for binutils 2.14 compatibility:
  */
 . = ASSERT((_end - LOAD_OFFSET <= KERNEL_IMAGE_SIZE),
-	   "kernel image bigger than KERNEL_IMAGE_SIZE");
+	   "kernel image bigger than KERNEL_IMAGE_SIZE or CONFIG_PHYSICAL_START too large");
 
 #ifdef CONFIG_X86_64
 /*