Skip to contentSkip to conversation

gitlab-CI: Test 32-bit builds with the fedora-i386-cross container

PATCH In review Thomas Huth 3 participants 3 messages Dec 15, 2020 – Dec 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gitlab-CI: Test 32-bit builds with the fedora-i386-cross container

After adding some missing packages, it's possible to check 32-bit builds and tests with the fedora-i386-cross container in the gitlab-CI, too. Unfortunately, the code in subprojects/ ignores the --extra-cflags (on purpose), so the vhost-user part has to be disabled for this.

While we're at it, update the container to Fedora 31. Unfortunately the gcc from the later versions emits some very dubious format-truncation warnings, so Fedora 32 and 33 are currently unsuitable for this job.

---
 .gitlab-ci.d/crossbuilds.yml                   | 16 ++++++++++++++--
 .../dockerfiles/fedora-i386-cross.docker       | 18 +++++++++++++++---
 2 files changed, 29 insertions(+), 5 deletions(-)
.gitlab-ci.d/crossbuilds.yml +14 -2
index bd6473a75a..2da92e4a6f 100644
@@ -10,7 +10,7 @@
         --target-list-exclude="aarch64-softmmu i386-softmmu microblaze-softmmu
           mips-softmmu mipsel-softmmu mips64-softmmu ppc64-softmmu sh4-softmmu
           xtensa-softmmu"
-    - make -j$(expr $(nproc) + 1) all check-build
+    - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS
 
 # Job to cross-build specific accelerators.
 #
@@ -37,7 +37,7 @@
     - cd build
     - PKG_CONFIG_PATH=$PKG_CONFIG_PATH
       ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system
-    - make -j$(expr $(nproc) + 1) all check-build
+    - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS
 
 cross-armel-system:
   extends: .cross_system_build_job
@@ -69,6 +69,18 @@ cross-arm64-user:
   variables:
     IMAGE: debian-arm64-cross
 
+cross-i386-system:
+  extends: .cross_system_build_job
+  variables:
+    IMAGE: fedora-i386-cross
+    MAKE_CHECK_ARGS: check-qtest
+
+cross-i386-user:
+  extends: .cross_user_build_job
+  variables:
+    IMAGE: fedora-i386-cross
+    MAKE_CHECK_ARGS: check
+
 cross-mips-system:
   extends: .cross_system_build_job
   variables:
tests/docker/dockerfiles/fedora-i386-cross.docker +15 -3
index cd16cd1bfa..a6e411291b 100644
@@ -1,14 +1,26 @@
-FROM fedora:30
+FROM fedora:31
 ENV PACKAGES \
+    bzip2 \
+    diffutils \
+    findutils \
     gcc \
+    git \
+    libtasn1-devel.i686 \
+    libzstd-devel.i686 \
+    make \
+    meson \
+    ninja-build \
     glib2-devel.i686 \
     glibc-devel.i686 \
     glibc-static.i686 \
     gnutls-devel.i686 \
     nettle-devel.i686 \
+    perl-Test-Harness \
     pixman-devel.i686 \
-    zlib-devel.i686 \
-    libzstd-devel.i686
+    zlib-devel.i686
+
+ENV QEMU_CONFIGURE_OPTS --extra-cflags=-m32 --disable-vhost-user
+ENV PKG_CONFIG_PATH /usr/lib/pkgconfig
 
 RUN dnf install -y $PACKAGES
 RUN rpm -q $PACKAGES | sort > /packages.txt
Signature · 1 line
2.27.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Thomas Huth

After adding some missing packages, it's possible to check 32-bit builds and tests with the fedora-i386-cross container in the gitlab-CI, too. Unfortunately, the code in subprojects/ ignores the --extra-cflags (on purpose), so the vhost-user part has to be disabled for this.

While we're at it, update the container to Fedora 31. Unfortunately the gcc from the later versions emits some very dubious format-truncation warnings, so Fedora 32 and 33 are currently unsuitable for this job.

Quoted 5 lines
---
  .gitlab-ci.d/crossbuilds.yml                   | 16 ++++++++++++++--
  .../dockerfiles/fedora-i386-cross.docker       | 18 +++++++++++++++---
  2 files changed, 29 insertions(+), 5 deletions(-)
Quoted 76 lines
.gitlab-ci.d/crossbuilds.yml +14 -2
index bd6473a75a..2da92e4a6f 100644
@@ -10,7 +10,7 @@
          --target-list-exclude="aarch64-softmmu i386-softmmu microblaze-softmmu
            mips-softmmu mipsel-softmmu mips64-softmmu ppc64-softmmu sh4-softmmu
            xtensa-softmmu"
-    - make -j$(expr $(nproc) + 1) all check-build
+    - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS
 
  # Job to cross-build specific accelerators.
  #
@@ -37,7 +37,7 @@
      - cd build
      - PKG_CONFIG_PATH=$PKG_CONFIG_PATH
        ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system
-    - make -j$(expr $(nproc) + 1) all check-build
+    - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS
 
  cross-armel-system:
    extends: .cross_system_build_job
@@ -69,6 +69,18 @@ cross-arm64-user:
    variables:
      IMAGE: debian-arm64-cross
 
+cross-i386-system:
+  extends: .cross_system_build_job
+  variables:
+    IMAGE: fedora-i386-cross
+    MAKE_CHECK_ARGS: check-qtest
+
+cross-i386-user:
+  extends: .cross_user_build_job
+  variables:
+    IMAGE: fedora-i386-cross
+    MAKE_CHECK_ARGS: check
+
  cross-mips-system:
    extends: .cross_system_build_job
    variables:
tests/docker/dockerfiles/fedora-i386-cross.docker +15 -3
index cd16cd1bfa..a6e411291b 100644
@@ -1,14 +1,26 @@
-FROM fedora:30
+FROM fedora:31
  ENV PACKAGES \
+    bzip2 \
+    diffutils \
+    findutils \
      gcc \
+    git \
+    libtasn1-devel.i686 \
+    libzstd-devel.i686 \
+    make \
+    meson \
+    ninja-build \
      glib2-devel.i686 \
      glibc-devel.i686 \
      glibc-static.i686 \
      gnutls-devel.i686 \
      nettle-devel.i686 \
+    perl-Test-Harness \
      pixman-devel.i686 \
-    zlib-devel.i686 \
-    libzstd-devel.i686
+    zlib-devel.i686
+
+ENV QEMU_CONFIGURE_OPTS --extra-cflags=-m32 --disable-vhost-user
+ENV PKG_CONFIG_PATH /usr/lib/pkgconfig
 
  RUN dnf install -y $PACKAGES
  RUN rpm -q $PACKAGES | sort > /packages.txt
#2 lore raw
In reply to Thomas Huth
Quoted 8 lines · Thomas Huth

After adding some missing packages, it's possible to check 32-bit builds and tests with the fedora-i386-cross container in the gitlab-CI, too. Unfortunately, the code in subprojects/ ignores the --extra-cflags (on purpose), so the vhost-user part has to be disabled for this.

While we're at it, update the container to Fedora 31. Unfortunately the gcc from the later versions emits some very dubious format-truncation warnings, so Fedora 32 and 33 are currently unsuitable for this job.

Queued to pr/161220-testing-1, thanks.

Signature · 1 line
Alex Bennée