drivers: nvdimm: cleanup include of badblocks.h
PATCH 1/1 drivers: nvdimm: cleanup include of badblocks.h
* drivers/nvdimm/core.c doesn't use anything from badblocks.h on its own, thus including it isn't needed. There's indeed indirect use, via funcs in nd.h, but this one already includes badblocks.h.
* drivers/nvdimm/claim.c calls stuff from badblocks.h and therefore should include it on its own (instead of relying any other header doing that)
* drivers/nvdimm/btt.h doesn't really need anything from badblocks.h and can easily live with a forward declaration of struct badblocks (just having pointers to it, but not dereferencing it anywhere)
--- drivers/nvdimm/btt.h | 3 ++- drivers/nvdimm/claim.c | 1 + drivers/nvdimm/core.c | 1 - 3 files changed, 3 insertions(+), 2 deletions(-)
drivers/nvdimm/btt.h +2 -1
@@ -7,7 +7,6 @@#ifndef _LINUX_BTT_H#define _LINUX_BTT_H -#include <linux/badblocks.h> #include <linux/types.h> #define BTT_SIG_LEN 16
@@ -197,6 +196,8 @@ struct arena_info {int log_index[2 ]; }; +struct badblocks ; +/** * struct btt - handle for a BTT instance * @btt_disk: Pointer to the gendisk for BTT device
drivers/nvdimm/claim.c +1 -0
@@ -4,6 +4,7 @@*/ #include <linux/device.h> #include <linux/sizes.h> +#include <linux/badblocks.h> #include "nd-core.h" #include "pmem.h" #include "pfn.h"
drivers/nvdimm/core.c +0 -1
@@ -3,7 +3,6 @@* Copyright(c) 2013-2015 Intel Corporation. All rights reserved. */ #include <linux/libnvdimm.h> -#include <linux/badblocks.h> #include <linux/suspend.h> #include <linux/export.h> #include <linux/module.h>
Signature · 4 lines
2.11.0 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Quoted 11 lines · metux IT consult
*
drivers/nvdimm/core.cdoesn't use anything frombadblocks.hon its own, thus including it isn't needed. There's indeed indirect use, via funcs innd.h, but this one already includesbadblocks.h.*
drivers/nvdimm/claim.ccalls stuff frombadblocks.hand therefore should include it on its own (instead of relying any other header doing that)*
drivers/nvdimm/btt.hdoesn't really need anything frombadblocks.hand can easily live with a forward declaration of struct badblocks (just having pointers to it, but not dereferencing it anywhere)
Thanks, looks ok to me.
It was commit aa9ad44a42b4 ("libnvdimm: move poison list functions to a new 'badrange' file") that left the straggling include in core.c.
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]